Re: [Inkscape-devel] LPE on clip/mask - Bug 1241902
Hi to all
I haven't tried it, but is the problem around the non commutativity
of
composition?
njh
Not is about the type of LPE, some go well -usualy deformation ones- some not -redefinition of path, because this effect is for a clip or mask so result path is vieaw through it. I couldent find another way to explain it :(
In last patch i upload a method to specify in the effect itself if is allowed to handle clips or mask.
Regards, Jabier.
Think I fing a better way to handle this: Remove all of my patch except the code in sp-lpe-item. Add/modiffy the function "doBeforeEffec" in each effect you want to have clip or mask: sp_lpe_item_apply_to_mask(SP_ITEM(lpeitem)); sp_lpe_item_apply_to_clippath(SP_ITEM(lpeitem)); Now compiling and testing. soon a patch.
Regards and thanks for the bug report.
El lun, 23-06-2014 a las 11:24 +0200, Jabiertxo escribió:
Hi. I see the problem. Well, some effects apply well and some not because the effect "remove partialy the fills and you view trhought".
I think is a good feature to think about a way to define the effects whith LPE on clip or mask enabled/disabled.
Maybe the best way can be add a button to the GUI (in the effect GUI itself or more global) to add or remove selected LPE to clippaths or mask.
If last is best i can work to port some LPE.
Regards, Jabier.
El lun, 23-06-2014 a las 10:11 +1000, Nathan Hurst escribió:
I haven't tried it, but is the problem around the non commutativity of composition?
njh
On Sun, Jun 22, 2014 at 04:37:48PM -0700, Josh Andler wrote:
Yeah, definitely not what I'd expect... also, if you do this with the hatches lpe and switch to the node tool, it's displaying like you can modify things in a way that it can't/shouldn't.
Cheers, Josh
On Sun, Jun 22, 2014 at 4:17 PM, Johan Engelen <jbc.engelen@...2984....> wrote:
It works as expected for pure rectangles svg:rect, because that it the old behavior and an oversight in the fix. Try it with a path as clippath (rect -> object-to-path).
Sorry for the confusion, Johan
On 23-6-2014 0:50, Josh Andler wrote:
1. Drew a Star
- Applied rectangle as clippath
- Applied sketch to clipped star
The results were as expected and no different than if I
- Drew Star
- Applied sketch to star
- Applied rectangle as clippath
Should I have expected something different visually or behavior wise than to end up with a clipped star that shows sketch being applied?
The only other potentially relevant things I can think to mention were that I selected items using the selector tool and there were no groups present.
Cheers, Josh
On Sun, Jun 22, 2014 at 3:29 PM, Johan Engelen <jbc.engelen@...3132......
wrote:
- draw a path
- apply a rectangle as clippath
- apply lpe sketch => weirdness
Johan
On 23-6-2014 0:19, Josh Andler wrote:
Can you supply a weird one? I just applied sketch to an object and then applied said object as a clippath to something else and it looked as expected.
Cheers, Josh
On Sun, Jun 22, 2014 at 3:08 PM, Johan Engelen < jbc.engelen@...2592...> wrote:
Hi all, Recently, a fix to Bug 1241902 was committed. But... I have second thoughts now. Do we really want to apply LPEs to clip and masks? Now, clips on a path with, say, LPE Sketch, works very weird.
I now think that we really don't want to apply LPEs on clips/masks.
cheers, Johan
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems
Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 26-6-2014 16:14, Jabiertxo Arraiza Cenoz wrote:
In last patch i upload a method to specify in the effect itself if is allowed to handle clips or mask.
I'm not sure, and think we should not add more hacks to this; I don't think it is good to add a flag for this to the LPE classes. For one thing, I think it is not a good idea to change behavior silently depending on what effect is applied. Perhaps a UI toggle is more suited here (say, a toggle in the Apply LPE chooser dialog).
Jabier, could you please for now remove the calls to sp_lpe_item_apply_to_mask and sp_lpe_item_apply_to_clippath, until we figure out a good solution? No need to remove the functions themselves (add a comment with a link to the bug report). I've reopened the bug report.
Thanks, regards, Johan
Hi Johan. I revert it.
About the last patch, my code is easy changeable by a ui toogle in each effect or in some of them. I also dislike the become complexity but think is need for correct work in the cases i tested.
Another approach could be a button in all/some LPE gui to apply the effect to the clip/mask. This remove the sweet live effect but simplify the code.
Whats your opinion?
Cheers, Jabier.
El vie, 27-06-2014 a las 00:36 +0200, Johan Engelen escribió:
On 26-6-2014 16:14, Jabiertxo Arraiza Cenoz wrote:
In last patch i upload a method to specify in the effect itself if is allowed to handle clips or mask.
I'm not sure, and think we should not add more hacks to this; I don't think it is good to add a flag for this to the LPE classes. For one thing, I think it is not a good idea to change behavior silently depending on what effect is applied. Perhaps a UI toggle is more suited here (say, a toggle in the Apply LPE chooser dialog).
Jabier, could you please for now remove the calls to sp_lpe_item_apply_to_mask and sp_lpe_item_apply_to_clippath, until we figure out a good solution? No need to remove the functions themselves (add a comment with a link to the bug report). I've reopened the bug report.
Thanks, regards, Johan
participants (2)
-
Jabiertxo Arraiza Cenoz -
Johan Engelen