I just did a change to NRRect's default constructor.
Prior to this it was leaving all of its members uninitialized, and valgrind found that some like this were being checked for 'empty'. So random behavior could have been seen.
I also did a fix under display, but that was an array index going below zero, but I think the loop would have exited anyway, so I don't expect that change to really affect the program.
I'm mainly concerned that some bugs might have been caused by 'new' NRRect variables being seen as non-empty and now they'll show up as empty.
BTW, these were the first two things I found by getting to run under Valgrind and seeing what was reported right off the bat. I'll probably try to actually explore the app a little more under valgrind, but I think these two were a good start.
How did you get inkscape to run under valgrind? When I tried it, it seemed to go wrong because the GC is incompatible.
On Sat, 2008-03-01 at 01:14 -0800, Jon A. Cruz wrote:
I just did a change to NRRect's default constructor.
Prior to this it was leaving all of its members uninitialized, and valgrind found that some like this were being checked for 'empty'. So random behavior could have been seen.
I also did a fix under display, but that was an array index going below zero, but I think the loop would have exited anyway, so I don't expect that change to really affect the program.
I'm mainly concerned that some bugs might have been caused by 'new' NRRect variables being seen as non-empty and now they'll show up as empty.
BTW, these were the first two things I found by getting to run under Valgrind and seeing what was reported right off the bat. I'll probably try to actually explore the app a little more under valgrind, but I think these two were a good start.
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Mar 1, 2008, at 1:52 AM, Joel Holdsworth wrote:
How did you get inkscape to run under valgrind? When I tried it, it seemed to go wrong because the GC is incompatible.
_INKSCAPE_GC=disable valgrind --tool=memcheck ./inkscape
It won't really help find leaks, but uninitialized variables, etc., should be caught
participants (2)
-
Joel Holdsworth -
Jon A. Cruz