Linked offset broken in trunk
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results: 1. Draw any shape 2. Add a linked offset to the shape 3. Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.png
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
Sorry, it's "dynamic offset" that is broken. I've been working too much. :P
To reproduce results: 1. Draw any shape 2. Add a dynamic offset to the shape 3. Drag the linked offset handle out or in.
On Thu, Mar 17, 2016 at 10:24 PM, C R <cajhne@...400...> wrote:
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results:
- Draw any shape
- Add a linked offset to the shape
- Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.png
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
I couldent reproduce it with current trunk r14720 Debian Stretch. Could provide a SVG as example?
Thanks in advance.
El jue, 17-03-2016 a las 23:12 +0000, C R escribió:
Sorry, it's "dynamic offset" that is broken. I've been working too much. :P
To reproduce results:
- Draw any shape
- Add a dynamic offset to the shape
- Drag the linked offset handle out or in.
On Thu, Mar 17, 2016 at 10:24 PM, C R <cajhne@...400...> wrote:
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results:
- Draw any shape
- Add a linked offset to the shape
- Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.png
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Here's a video of the issue:
http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_problem.ogv
I updated to the latest inkscape-trunk to be sure it hadn't been fixed.
Here also is the svg file with the star in a noticeably corrupted state: http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_test.svg
I'm running Ubuntu 15.10 with Gnome 3, as you can see from the video.
Thanks again for looking into it, Jabier. :) -C
On Sat, Mar 19, 2016 at 7:50 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
I couldent reproduce it with current trunk r14720 Debian Stretch. Could provide a SVG as example?
Thanks in advance.
El jue, 17-03-2016 a las 23:12 +0000, C R escribió:
Sorry, it's "dynamic offset" that is broken. I've been working too much. :P
To reproduce results:
- Draw any shape
- Add a dynamic offset to the shape
- Drag the linked offset handle out or in.
On Thu, Mar 17, 2016 at 10:24 PM, C R <cajhne@...400...> wrote:
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results:
- Draw any shape
- Add a linked offset to the shape
- Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.png
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Thanks finaly I could reproduce it. Im trying with a rounded star and here are no problem (or very tiny), when use a cusp star i see it.
Thanks!
El dom, 20-03-2016 a las 00:44 +0000, C R escribió:
Here's a video of the issue:
http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_prob lem.ogv
I updated to the latest inkscape-trunk to be sure it hadn't been fixed.
Here also is the svg file with the star in a noticeably corrupted state: http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_test .svg
I'm running Ubuntu 15.10 with Gnome 3, as you can see from the video.
Thanks again for looking into it, Jabier. :) -C
On Sat, Mar 19, 2016 at 7:50 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
I couldent reproduce it with current trunk r14720 Debian Stretch. Could provide a SVG as example?
Thanks in advance.
El jue, 17-03-2016 a las 23:12 +0000, C R escribió:
Sorry, it's "dynamic offset" that is broken. I've been working too much. :P
To reproduce results:
- Draw any shape
- Add a dynamic offset to the shape
- Drag the linked offset handle out or in.
On Thu, Mar 17, 2016 at 10:24 PM, C R <cajhne@...400...> wrote:
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results:
- Draw any shape
- Add a linked offset to the shape
- Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.p ng
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
You have an idea how much time could this bug happen?
Cheers.
El dom, 20-03-2016 a las 00:44 +0000, C R escribió:
Here's a video of the issue:
http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_prob lem.ogv
I updated to the latest inkscape-trunk to be sure it hadn't been fixed.
Here also is the svg file with the star in a noticeably corrupted state: http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_test .svg
I'm running Ubuntu 15.10 with Gnome 3, as you can see from the video.
Thanks again for looking into it, Jabier. :) -C
On Sat, Mar 19, 2016 at 7:50 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
I couldent reproduce it with current trunk r14720 Debian Stretch. Could provide a SVG as example?
Thanks in advance.
El jue, 17-03-2016 a las 23:12 +0000, C R escribió:
Sorry, it's "dynamic offset" that is broken. I've been working too much. :P
To reproduce results:
- Draw any shape
- Add a dynamic offset to the shape
- Drag the linked offset handle out or in.
On Thu, Mar 17, 2016 at 10:24 PM, C R <cajhne@...400...> wrote:
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results:
- Draw any shape
- Add a linked offset to the shape
- Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.p ng
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
You have an idea how much time could this bug happen?
Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
I re-installed 0.91 stable release, and opened the same file generated by inkscape-trunk, to see what would happen.
As expected, Inkscape 0.91 (r13725) interperets the offset correctly. I jiggled the offset handle a little so Inkscape detected a change, then re-saved the file. Here is the re-saved result for comparison (open in browser to see the difference): http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_0.91_stable...
Also, here is a gif animated comparison of the old offset and new on the same shape: http://www.opendesignstudio.org/inkscape/dynamic_offset_old_new_comparison.g...
-C
On Sun, Mar 20, 2016 at 10:21 AM, C R <cajhne@...400...> wrote:
You have an idea how much time could this bug happen?
Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
Is a bug "know" bug. https://bugs.launchpad.net/inkscape/+bug/1507049
Thanks for the info!
El dom, 20-03-2016 a las 11:58 +0000, C R escribió:
I re-installed 0.91 stable release, and opened the same file generated by inkscape-trunk, to see what would happen.
As expected, Inkscape 0.91 (r13725) interperets the offset correctly. I jiggled the offset handle a little so Inkscape detected a change, then re-saved the file. Here is the re-saved result for comparison (open in browser to see the difference): http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_0.91 _stable.svg
Also, here is a gif animated comparison of the old offset and new on the same shape: http://www.opendesignstudio.org/inkscape/dynamic_offset_old_new_compa rison.gif
-C
On Sun, Mar 20, 2016 at 10:21 AM, C R <cajhne@...400...> wrote:
You have an idea how much time could this bug happen?
Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
Thanks for the update and the work. I'm glad to see the regression is still available in trunk. Maybe applying the regression would be easier than trying to fix the code?
-C
On Sun, Mar 20, 2016 at 12:56 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
Is a bug "know" bug. https://bugs.launchpad.net/inkscape/+bug/1507049
Thanks for the info!
El dom, 20-03-2016 a las 11:58 +0000, C R escribió:
I re-installed 0.91 stable release, and opened the same file generated by inkscape-trunk, to see what would happen.
As expected, Inkscape 0.91 (r13725) interperets the offset correctly. I jiggled the offset handle a little so Inkscape detected a change, then re-saved the file. Here is the re-saved result for comparison (open in browser to see the difference): http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_0.91 _stable.svg
Also, here is a gif animated comparison of the old offset and new on the same shape: http://www.opendesignstudio.org/inkscape/dynamic_offset_old_new_compa rison.gif
-C
On Sun, Mar 20, 2016 at 10:21 AM, C R <cajhne@...400...> wrote:
You have an idea how much time could this bug happen?
Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
To me yes.
Because livarotot is going to dead on inkscape at some point and the bug than originate the broken revision have less scope than the resulting bug, I think the best is not investigate over it and revert the revision. with a comment to the bug not solved.
All the best, Jabier.
El dom, 20-03-2016 a las 18:18 +0000, C R escribió:
Thanks for the update and the work. I'm glad to see the regression is still available in trunk. Maybe applying the regression would be easier than trying to fix the code?
-C
On Sun, Mar 20, 2016 at 12:56 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
Is a bug "know" bug. https://bugs.launchpad.net/inkscape/+bug/1507049
Thanks for the info!
El dom, 20-03-2016 a las 11:58 +0000, C R escribió:
I re-installed 0.91 stable release, and opened the same file generated by inkscape-trunk, to see what would happen.
As expected, Inkscape 0.91 (r13725) interperets the offset correctly. I jiggled the offset handle a little so Inkscape detected a change, then re-saved the file. Here is the re-saved result for comparison (open in browser to see the difference): http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_ 0.91 _stable.svg
Also, here is a gif animated comparison of the old offset and new on the same shape: http://www.opendesignstudio.org/inkscape/dynamic_offset_old_new_c ompa rison.gif
-C
On Sun, Mar 20, 2016 at 10:21 AM, C R <cajhne@...400...> wrote:
You have an idea how much time could this bug happen?
Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
Would be awesome. :) It's a really crippling problem. Thanks for taking the time to look at it. Can you revert it or do we have to ask someone first?
-C
On Wed, Mar 23, 2016 at 8:09 PM, Jabier Arraiza <jabier.arraiza@...2893...> wrote:
To me yes.
Because livarotot is going to dead on inkscape at some point and the bug than originate the broken revision have less scope than the resulting bug, I think the best is not investigate over it and revert the revision. with a comment to the bug not solved.
All the best, Jabier.
El dom, 20-03-2016 a las 18:18 +0000, C R escribió:
Thanks for the update and the work. I'm glad to see the regression is still available in trunk. Maybe applying the regression would be easier than trying to fix the code?
-C
On Sun, Mar 20, 2016 at 12:56 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
Is a bug "know" bug. https://bugs.launchpad.net/inkscape/+bug/1507049
Thanks for the info!
El dom, 20-03-2016 a las 11:58 +0000, C R escribió:
I re-installed 0.91 stable release, and opened the same file generated by inkscape-trunk, to see what would happen.
As expected, Inkscape 0.91 (r13725) interperets the offset correctly. I jiggled the offset handle a little so Inkscape detected a change, then re-saved the file. Here is the re-saved result for comparison (open in browser to see the difference): http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_ 0.91 _stable.svg
Also, here is a gif animated comparison of the old offset and new on the same shape: http://www.opendesignstudio.org/inkscape/dynamic_offset_old_new_c ompa rison.gif
-C
On Sun, Mar 20, 2016 at 10:21 AM, C R <cajhne@...400...> wrote:
You have an idea how much time could this bug happen?
Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
Hi to all.
Anybody disagree or want to tell somthing on revert back the revission http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/14156 with a comment like: //TODO: need fix for bug: #384688 with fix released in r.14156 //but reverted because bug #1507049 seems has more priority.
Cheers, Jabier.
El mié, 23-03-2016 a las 20:43 +0000, C R escribió:
Would be awesome. :) It's a really crippling problem. Thanks for taking the time to look at it. Can you revert it or do we have to ask someone first?
-C
On Wed, Mar 23, 2016 at 8:09 PM, Jabier Arraiza <jabier.arraiza@...3313... r.es> wrote:
To me yes.
Because livarotot is going to dead on inkscape at some point and the bug than originate the broken revision have less scope than the resulting bug, I think the best is not investigate over it and revert the revision. with a comment to the bug not solved.
All the best, Jabier.
El dom, 20-03-2016 a las 18:18 +0000, C R escribió:
Thanks for the update and the work. I'm glad to see the regression is still available in trunk. Maybe applying the regression would be easier than trying to fix the code?
-C
On Sun, Mar 20, 2016 at 12:56 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
Is a bug "know" bug. https://bugs.launchpad.net/inkscape/+bug/1507049
Thanks for the info!
El dom, 20-03-2016 a las 11:58 +0000, C R escribió:
I re-installed 0.91 stable release, and opened the same file generated by inkscape-trunk, to see what would happen.
As expected, Inkscape 0.91 (r13725) interperets the offset correctly. I jiggled the offset handle a little so Inkscape detected a change, then re-saved the file. Here is the re-saved result for comparison (open in browser to see the difference): http://www.opendesignstudio.org/inkscape/inkscape_dynamic_off set_ 0.91 _stable.svg
Also, here is a gif animated comparison of the old offset and new on the same shape: http://www.opendesignstudio.org/inkscape/dynamic_offset_old_n ew_c ompa rison.gif
-C
On Sun, Mar 20, 2016 at 10:21 AM, C R <cajhne@...400...> wrote:
You have an idea how much time could this bug happen? > > > > Unfortunately, it happens on every shape I've tried. It's 100% of the time, as far as I can tell. Before, I got perfect shapes every time. Now, all the vectors have either a slightly corrupt, or very wavey and corrupt result after applying the offset. It's almost as if the algorithm is trying to apply a smooth effect or something.
The result should be the same as applying a very thick line to the shape, then converting stroke to path, and deleting the interior of the stroke. This effect must be perfect. It should not have to guess or estimate anything, and should be pristinely uniform.
Whatever was done to the calculation of the offset needs to be reverted back to the way it was.
Thanks again for your help, Jabier.
-C
More focused:
The feature is working after 2015-05-22 + time to update inkscape debel at launchpad?
Cheers
El dom, 20-03-2016 a las 00:44 +0000, C R escribió:
Here's a video of the issue:
http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_prob lem.ogv
I updated to the latest inkscape-trunk to be sure it hadn't been fixed.
Here also is the svg file with the star in a noticeably corrupted state: http://www.opendesignstudio.org/inkscape/inkscape_dynamic_offset_test .svg
I'm running Ubuntu 15.10 with Gnome 3, as you can see from the video.
Thanks again for looking into it, Jabier. :) -C
On Sat, Mar 19, 2016 at 7:50 PM, Jabiertxo Arraiza Cenoz < jabier.arraiza@...2893...> wrote:
I couldent reproduce it with current trunk r14720 Debian Stretch. Could provide a SVG as example?
Thanks in advance.
El jue, 17-03-2016 a las 23:12 +0000, C R escribió:
Sorry, it's "dynamic offset" that is broken. I've been working too much. :P
To reproduce results:
- Draw any shape
- Add a dynamic offset to the shape
- Drag the linked offset handle out or in.
On Thu, Mar 17, 2016 at 10:24 PM, C R <cajhne@...400...> wrote:
Hey, just noticed that linked offset now produces very bad results.
I'm using Inkscape 0.91+devel r (Mar 14 2016)
To reproduce results:
- Draw any shape
- Add a linked offset to the shape
- Drag the linked offset handle out or in.
Star and rounded rectangle example with linked offset here: http://www.opendesignstudio.org/inkscape/linked_ofset_problem.p ng
As you can see the results are wavey/garbagey. Whatever changes were made to the linked offset modifier seem to have broken it pretty badly. :/
Thoughts?
-C
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (3)
-
C R -
Jabier Arraiza -
Jabiertxo Arraiza Cenoz