bulia byak wrote:

I think this frenzy of replacements and cleanups should have been done after a release, not now. It's dangerous. Right now Inkscape is severely broken: try to draw a rect or ellipse or spiral - they always start from coordinate origin. This is a visible bug, but I'm terrified to think how many more hidden ones were introduced by all this activity. And we wanted to do a release soon.

What release? I thought that the release was delayed until things were working (such as CVS)? I find your lack of faith disturbing - why are you allowed to make keybinding changes, yet others are not allowed to fix real problems with the code? You claim it is severely broken, yet the fix was to add one line. Please don't over react.

As I have cleaned up the code I have found numerous bugs due to incorrect copy and paste, due to assumptions about code execution order, due to assumptions about the maths that don't scale correctly. Peter and Mental can attest to the the same thing - finding and fixing things like extra whitespace, #if 0s, moving definitions to declarations and replacing pointers with references dig up all sorts of fun bugs which you don't notice visibly until you understand the bug, then you can recreate them at will.

Please someone fix the drawing tools problem ASAP!

Done (I could only find problems with rect, ellipse and spiral, all of which had the same copy+paste code).

cheers, njh