Re: [Inkscape-devel] Strange bug related to "recent file" list
Quoting reply received off-list - maybe someone on the list can comment on the proposal?
On 2015-09-29 21:29 (+0200), Riccardo Bernardini wrote:
Known issue (not fixed yet) tracked here: Bug #1404934 “Crash when opening files (Glib::ConvertError exception)” https://bugs.launchpad.net/inkscape/+bug/1404934
Would it suffice to catch the exception Glib::ConvertError: threw by filename_from_url() at resource-manager.cpp:225, so that the offending entry is skipped and not appended to priorLocations (maybe with some warning output)? If yes, I could try doing the minimal change and submit it.
Riccardo
On Tue, 2015-09-29 at 23:01 +0200, su_v wrote:
Would it suffice to catch the exception Glib::ConvertError: threw by
filename_from_url() at resource-manager.cpp:225, so that the offending entry is skipped and not appended to priorLocations (maybe with some warning output)? If yes, I could try doing the minimal change and submit it.
To Riccardo:
This is a good plan. I would be happy to review the code for you.
Martin,
Hi, I did the change and it seems to work. I reproduced the "recent file list" problem and the "old" inkscape dies, while the new one does not, but prints a warning message.
I only modified resource-manager.cpp and I am attaching a "diff -c" file relative to the two versions of resource-manager.cpp. It is the first time that I contribute some code to inkscape, so if I need to follow a different procedure, please let me know.
Riccardo -- Riccardo Bernardini Tel : +39-0432-55-8271 skype : bernardini.riccardo LinkedIn : https://www.linkedin.com/in/riccardobernardini ________________________________________ Da: Martin Owens [doctormo@...400...] Inviato: martedì 29 settembre 2015 23.59 A: suv-sf@...58... Cc: Riccardo Bernardini; Inkscape Devel List Oggetto: Re: [Inkscape-devel] Strange bug related to "recent file" list
On Tue, 2015-09-29 at 23:01 +0200, su_v wrote:
Would it suffice to catch the exception Glib::ConvertError: threw by
filename_from_url() at resource-manager.cpp:225, so that the offending entry is skipped and not appended to priorLocations (maybe with some warning output)? If yes, I could try doing the minimal change and submit it.
To Riccardo:
This is a good plan. I would be happy to review the code for you.
Martin,
On Wed, 2015-09-30 at 07:23 +0000, Riccardo Bernardini wrote:
Hi, I did the change and it seems to work. I reproduced the "recent file list" problem and the "old" inkscape dies, while the new one does not, but prints a warning message.
I only modified resource-manager.cpp and I am attaching a "diff -c" file relative to the two versions of resource-manager.cpp. It is the first time that I contribute some code to inkscape, so if I need to follow a different procedure, please let me know.
Hi Riccardo,
Thanks for your patch file. If you want to submit the work directly (and learn how it's done) you can find the documentation here:
https://inkscape.org/en/develop/getting-started/#developer-workflow
On the other hand, let me know otherwise so I can make arrangements to get the patch in.
Best Regards, Martin Owens
Da: Martin Owens [doctormo@...400...] Inviato: mercoledì 30 settembre 2015 16.17 A: Riccardo Bernardini Cc: suv-sf@...58...; Inkscape Devel List Oggetto: Re: [Inkscape-devel] Strange bug related to "recent file" list
On Wed, 2015-09-30 at 07:23 +0000, Riccardo Bernardini wrote:
Hi, I did the change and it seems to work. I reproduced the "recent file list" problem and the "old" inkscape dies, while the new one does not, but prints a warning message.
I only modified resource-manager.cpp and I am attaching a "diff -c" file relative to the two versions of resource-manager.cpp. It is the first time that I contribute some code to i>nkscape, so if I need to follow a different procedure, please let me know.
Hi Riccardo,
Thanks for your patch file. If you want to submit the work directly (and learn how it's done) you can find the documentation here:
https://inkscape.org/en/develop/getting-started/#developer-workflow
On the other hand, let me know otherwise so I can make arrangements to get the patch in.
Best Regards, Martin Owens
Hi Martin,
I'll give a try (I like to learn new things :-). Bazaar is my CVS of choice, so I think I will be fine, otherwise, I'll let you know.
Best regards,
Riccardo
On 2015-09-30 22:42 (+0200), Riccardo Bernardini wrote:
Da: Martin Owens [...] Inviato: mercoledì 30 settembre 2015 16.17 A: Riccardo Bernardini Oggetto: Re: [Inkscape-devel] Strange bug related to "recent file" list
On Wed, 2015-09-30 at 07:23 +0000, Riccardo Bernardini wrote:
Hi, I did the change and it seems to work. I reproduced the "recent file list" problem and the "old" inkscape dies, while the new one does not, but prints a warning message.
I only modified resource-manager.cpp and I am attaching a "diff -c" file relative to the two versions of resource-manager.cpp. It is the first time that I contribute some code to i>nkscape, so if I need to follow a different procedure, please let me know.
Hi Riccardo,
Thanks for your patch file. If you want to submit the work directly (and learn how it's done) you can find the documentation here:
https://inkscape.org/en/develop/getting-started/#developer-workflow
On the other hand, let me know otherwise so I can make arrangements to get the patch in.
Best Regards, Martin Owens
Hi Martin,
I'll give a try (I like to learn new things :-). Bazaar is my CVS of choice, so I think I will be fine, otherwise, I'll let you know.
You can attach the patch (preferrably a unified diff against trunk, see attached example) to the bug report, along with a short summary of the proposed change.
It tested successfully (based on the few known examples of borked entries in recently-used.xbel provided by affected users) with Inkscape 0.91+devel r14389 on OS X 10.7.5, btw.
Regards, V
participants (3)
-
Martin Owens -
Riccardo Bernardini -
su_v