On Wed, 2014-03-12 at 00:56 +0100, su_v wrote:

...

We don't use svg:switch in Inkscape-generated SVG at the moment, so this is relevant only to externally authored content.

The changed behavior seems to confuse users - maybe there could be more information in the status line if ungrouping a 'conditional group' fails (in trunk)?

See this recent thread on inkscape-user: http://inkscape.13.x6.nabble.com/Can-t-ungroup-Conditional-Group-tt4969707.html#none

The bug linking doesn't really have to do with the scope of the ungroup functionality. The ability to ungroup switches and svg elements was removed and thus we have dangling inconsistent behavior between these elements.

src/selection-chemistry.cpp:797

I can press Ctrl+Click to select sub objects within a switch, I can enter the 'conditional group' using the right click menu and that all works great. We should be able to ungroup them too.

The ungrouping functionality for switch and maybe even svg elements should be put back before release.

Martin,

On Wed, 2014-03-12 at 15:02 +0100, Krzysztof Kosiński wrote:

I think that treating switches as groups is wrong (they should be transparently treated as the object they evaluate to), but this needs more changes than just disabling ungrouping. I'll fix this soon.

I was thinking some more about this issue and perhaps in the future release we need to stop SP_IS_GROUP from seeing switches as groups but instead have a SP_IS_CONTAINER or similar. Because there will be instances in the code where we need to know that an element is any container and we shouldn't have to remember to say IS_SWITCH or IS_SVG or IS_GROUP etc etc.

But there's room for not treating everything as a group too. So have different calls for the two intentions.

Martin,

On Wed, 2014-03-12 at 18:56 +0100, Krzysztof Kosiński wrote:

Switches should be ungroupable again in r13136.

Thanks Krzysztof!