I'm was looking at getting rid of the Inline Function Removal Janitor Item. For the conversion of sp_repr_change_order to repr->changeOrder, we have some code that expects a return code in tree_move: http://www.inkscape.org/doc/doxygen/html/sp-xmlview-tree_8cpp-source.php#l00...

I'm assuming that since sp_repr_change_order always returns TRUE, the proper patch would include removing the variable OK and the assigning and conditional related to it. It seems obvious since you'll get a compiler error if the assignments are not removed. I just wanted to check to make sure my changes are minimal and don't change other behavior.

Also, the last time I looked at these Janitor items, I put some questions in the Wiki. It would be great if these could be answered so that this action item could closed. In particular, whether sp_repr_children, sp_repr_unparent, sp_repr_document, sp_repr_document_root are to be included in this conversion.

Thanks, -- Rob. http://woodpendant.com