
rev 15810:
- open share/examples/live-path-effects-skeletal.svg
Problem: the file does not demonstrate the end result! It just has the untransformed fish, the arc to apply it to, and some texts. An example file must show the capability, not just lead you through a tutorial (though that is nice too).
- select the single-path fish, ctrl+c
- select the arc path above "3", open the lpe dialog
Problem: the first thing I see in the dialog is "Invalid effect". That's a really bad idea. I didn't do anything yet! Why are you proposing that I apply an invalid effect to the path? What is it anyway?
Problem: the dialog does not stay on top! Click on canvas and it sinks. Did you use the standard Dialog class for it? If you did it should take care of that.
- select skeletal strokes (btw why strokes and not stroke?) and cilck apply
Biggest problem: the path simply disappears.
- undo
Console warnings indicate missing sp_documen_done somewhere:
** (inkscape:19449): WARNING **: Incomplete undo transaction:
** (inkscape:19449): WARNING **: Event: Set attribute d to "" on #Element:0x0x88b29f0
What am I doing wrong?

The red helper path in Node tool is not updated when you undo some node edit. What's worse, node positions are now not updated too when that helper path is present. On normal paths without the red helper, it's OK as was before.

If I manually change original-d in XML, the helperpath updates accordingly. Can you tell me what an undo does exactly that is different from manually editting XML?
Thanks, Johan
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: vrijdag 17 augustus 2007 18:19 To: Engelen, J.B.C. (Johan) Cc: inkscape-devel@lists.sourceforge.net Subject: Re: first try of lpe
The red helper path in Node tool is not updated when you undo some node edit. What's worse, node positions are now not updated too when that helper path is present. On normal paths without the red helper, it's OK as was before.
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org

On 8/17/07, J.B.C.Engelen@...1578... <J.B.C.Engelen@...1578...> wrote:
If I manually change original-d in XML, the helperpath updates accordingly. Can you tell me what an undo does exactly that is different from manually editting XML?
As far as I remember, any changes from the XML editor get the "interactive" flag while undo changes have none. This may or may not be the reason, though.

On Fri, 2007-08-17 at 17:54 -0300, bulia byak wrote:
As far as I remember, any changes from the XML editor get the "interactive" flag while undo changes have none. This may or may not be the reason, though.
Do you remember why it was we introduced the "interactive" flag, OOC? I think it was to address some problem that we couldn't solve easily otherwise, but I think I did eventually want to plan a better permanent solution. Unfortunately I've forgotten the details now.
-mental

On 8/18/07, MenTaLguY <mental@...3...> wrote:
Do you remember why it was we introduced the "interactive" flag, OOC? I think it was to address some problem that we couldn't solve easily otherwise, but I think I did eventually want to plan a better permanent solution. Unfortunately I've forgotten the details now.
I think it was so that the d= is recalculated when I manually change the number of rays in a star via XML editor.

Hey Bulia,
Thanks for the bugreport :-) It uncovered some stuff that needed doing baaaadly!
rev 15810:
- open share/examples/live-path-effects-skeletal.svg
Problem: the file does not demonstrate the end result! It just has the untransformed fish, the arc to apply it to, and some texts. An example file must show the capability, not just lead you through a tutorial (though that is nice too).
Works now.
select the single-path fish, ctrl+c
select the arc path above "3", open the lpe dialog
Problem: the first thing I see in the dialog is "Invalid effect". That's a really bad idea. I didn't do anything yet! Why are you proposing that I apply an invalid effect to the path?
Fixed.
What is it anyway?
No clue. Removed it :)
Problem: the dialog does not stay on top! Click on canvas and it sinks. Did you use the standard Dialog class for it? If you did it should take care of that.
On windows here, it stays on top. If I remember correctly it also stays on top for me in Linux.
- select skeletal strokes (btw why strokes and not stroke?)
I am thinking about renaming the whole thing to path along path. Skeletal Strokes isn't quite it.
and cilck apply
Biggest problem: the path simply disappears.
Solved by making the default pattern path "M0,0 L1,1"
- undo
Console warnings indicate missing sp_documen_done somewhere:
** (inkscape:19449): WARNING **: Incomplete undo transaction:
** (inkscape:19449): WARNING **: Event: Set attribute d to "" on #Element:0x0x88b29f0
What am I doing wrong?
I got this aswell :S Working on it...
-Johan

On 8/17/07, J.B.C.Engelen@...1578... <J.B.C.Engelen@...1578...> wrote:
Problem: the file does not demonstrate the end result! It just has the untransformed fish, the arc to apply it to, and some texts. An example file must show the capability, not just lead you through a tutorial (though that is nice too).
Works now.
Thanks, so here's another bug: I edited the skeleton path and now the fish has parts of its head and tail white instead of gray (attached). Something's wrong with the fill of the path.
Also when I convert it to path, it works, but gives an assert:
** (inkscape:20830): CRITICAL **: void sp_shape_update_patheffect(SPShape*, bool): assertion `SP_IS_SHAPE (shape)' failed

On 8/17/07, bulia byak <buliabyak@...400...> wrote:
Thanks, so here's another bug: I edited the skeleton path and now the fish has parts of its head and tail white instead of gray (attached). Something's wrong with the fill of the path.
As of rev 15820, it's broken differently: now there's a lot of random extra line segments along the fish.
participants (3)
-
unknown@example.com
-
bulia byak
-
MenTaLguY