I submitted two patches to the tracker:
[ 840504 ] Remove kde option from configure
This removes the --with-kde option from configure.
[ 840506 ] Remove icon hash from sp_icon_new_full
See text for full explanation but this will fix the bug "Using Object Transformations twice crashes Inkscape" and possibly other untracked/undiscovered mysterious crashes. This is probably a better fix than the last one I submitted, which hasn't been applied anyway.
I see this as the first step in removing the sp_icon routines and replacing them with gtkIconfactory.
Patch [ 840443 ] Removes icons from dialog tab headers. (not mine) may also have the side effect of fixing "Using Object Transformations twice crashes Inkscape", but there are other parts of inkscape that call sp_icon_new that are still trashing memory all over the place but just haven't been noticed yet.
Cheers, Rob. http://members.rogers.com/rcrosbie
_________________________________________________________________ STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=dept/bcomm&pgmarket=en-ca&RU=http%3a%2f%2f...
Icons left in dialogs:
- XML Editor
I believe it's using the icon call just about anywhere we see an icon in a label.
-t
On Nov 12, 2003, at 12:14 AM, Robert Crosbie wrote:
I submitted two patches to the tracker:
[ 840504 ] Remove kde option from configure
This removes the --with-kde option from configure.
[ 840506 ] Remove icon hash from sp_icon_new_full
See text for full explanation but this will fix the bug "Using Object Transformations twice crashes Inkscape" and possibly other untracked/undiscovered mysterious crashes. This is probably a better fix than the last one I submitted, which hasn't been applied anyway.
I see this as the first step in removing the sp_icon routines and replacing them with gtkIconfactory.
Patch [ 840443 ] Removes icons from dialog tab headers. (not mine) may also have the side effect of fixing "Using Object Transformations twice crashes Inkscape", but there are other parts of inkscape that call sp_icon_new that are still trashing memory all over the place but just haven't been noticed yet.
Cheers, Rob. http://members.rogers.com/rcrosbie
STOP MORE SPAM with the new MSN 8 and get 2 months FREE* http://join.msn.com/?page=dept/bcomm&pgmarket=en- ca&RU=http%3a%2f%2fjoin.msn.com%2f%3fpage%3dmisc%2fspecialoffers%26pgma rket%3den-ca
This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Wed, 12 Nov 2003, Robert Crosbie wrote:
I submitted two patches to the tracker:
[ 840504 ] Remove kde option from configure
This removes the --with-kde option from configure.
Thanks, this is applied and committed.
[ 840506 ] Remove icon hash from sp_icon_new_full
See text for full explanation but this will fix the bug "Using Object Transformations twice crashes Inkscape" and possibly other untracked/undiscovered mysterious crashes. This is probably a better fix than the last one I submitted, which hasn't been applied anyway.
Very cool! I've applied this one as well. It'd be interesting to know what other bugs it might fix (I love patches that fix a slew of reported bugs).
I see this as the first step in removing the sp_icon routines and replacing them with gtkIconfactory.
*Nod*
Patch [ 840443 ] Removes icons from dialog tab headers. (not mine) may also have the side effect of fixing "Using Object Transformations twice crashes Inkscape", but there are other parts of inkscape that call sp_icon_new that are still trashing memory all over the place but just haven't been noticed yet.
Robert, thanks for these patches and your other contributions.
I've activated CVS access for you as well as permissions in the tracker. You can now take ownership of bugs and feature requests directly, and help review/integrate patches.
Bryce
participants (3)
-
Bryce Harrington -
Robert Crosbie -
T Ingham