Cloned gradient bug fix
Hi all, I just committed a symptom fix to LP bug #453067. The root cause is evil to fix, and probably no-one will get to it before release. Hope it counts towards the bug score.
regards, Johan
On 24-7-2014 1:00, Johan Engelen wrote:
Hi all, I just committed a symptom fix to LP bug #453067. The root cause is evil to fix, and probably no-one will get to it before release. Hope it counts towards the bug score.
Sorry, forgot the question. Are we ok by changing such crashes into warning messages (and possibly somewhat broken UI behavior) and putting bug pointers in the warning messages? Want to get the release out... (I spent three hours trying to find a better solution for this bug, without a large code rewrite, and failed) - Johan
On Thu, 2014-07-24 at 19:28 +0200, Johan Engelen wrote:
On 24-7-2014 1:00, Johan Engelen wrote:
Hi all, I just committed a symptom fix to LP bug #453067. The root cause is evil to fix, and probably no-one will get to it before release. Hope it counts towards the bug score.
Sorry, forgot the question. Are we ok by changing such crashes into warning messages (and possibly somewhat broken UI behavior) and putting bug pointers in the warning messages? Want to get the release out... (I spent three hours trying to find a better solution for this bug, without a large code rewrite, and failed)
I think in this case, yes.
I added a comment about clones with gradients in the bug report.
Krzysztof and Tomasz, could you have a quick look at this. I think gradients might need to be treated like clips, masks, and patterns.
Thanks,
Tav
Krzysztof and Tomasz, could you have a quick look at this. I think gradients might need to be treated like clips, masks, and patterns.
As for representation in SP Tree, patterns and gradients work the same way. SPPattern refactoring affects rendering and NR tree only.
While working on GSOC i also stumbled upon the problem that when paint servers are deleted and added to SP tree, invalid memory accesses (including malloc internal data corruption) happen.
On Fri, Jul 25, 2014, at 11:54 AM, Tomasz Boczkowski wrote:
While working on GSOC i also stumbled upon the problem that when paint servers are deleted and added to SP tree, invalid memory accesses (including malloc internal data corruption) happen.
Good catch. If nothing is in our bug tracker related to this, be sure to get something added. If it wasn't easy for you to address I'm sure I can run some good valgrind magic on it.
-- Jon A. Cruz jon@...18...
Good catch. If nothing is in our bug tracker related to this, be sure to
get something added. If it wasn't easy for you to address I'm sure I can run some good valgrind magic on it.
Submitted as bug #1348891. Although this bug is related to patterns, the cause for crashing may be the same.
On Fri, Jul 25, 2014 at 9:55 PM, Jon A. Cruz <jon@...18...> wrote:
On Fri, Jul 25, 2014, at 11:54 AM, Tomasz Boczkowski wrote:
While working on GSOC i also stumbled upon the problem that when paint servers are deleted and added to SP tree, invalid memory accesses (including malloc internal data corruption) happen.
Good catch. If nothing is in our bug tracker related to this, be sure to get something added. If it wasn't easy for you to address I'm sure I can run some good valgrind magic on it.
-- Jon A. Cruz jon@...18...
Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (4)
-
Johan Engelen -
Jon A. Cruz -
Tavmjong Bah -
Tomasz Boczkowski