![](https://secure.gravatar.com/avatar/66b27078585111da5ad5374e3b134b3f.jpg?s=120&d=mm&r=g)
In function: sp_attribute_widget_object_modified if (flags && SP_OBJECT_MODIFIED_FLAG) {
Shouldn't this be '&' not '&&' ?
![](https://secure.gravatar.com/avatar/82c0f6eed0ee59676eb45aadd66dac57.jpg?s=120&d=mm&r=g)
On 2011-06-25 7:50, Campbell Barton wrote:
In function: sp_attribute_widget_object_modified if (flags && SP_OBJECT_MODIFIED_FLAG) {
Shouldn't this be '&' not '&&'
Without looking at the context I'd say that it's highly likely you're right (as in 99% certain). And if you're not right than it's a weird piece of code. Have you tried changing it?
![](https://secure.gravatar.com/avatar/66b27078585111da5ad5374e3b134b3f.jpg?s=120&d=mm&r=g)
On Sat, Jun 25, 2011 at 8:10 AM, Jasper van de Gronde <th.v.d.gronde@...528...> wrote:
On 2011-06-25 7:50, Campbell Barton wrote:
In function: sp_attribute_widget_object_modified if (flags && SP_OBJECT_MODIFIED_FLAG) {
Shouldn't this be '&' not '&&'
Without looking at the context I'd say that it's highly likely you're right (as in 99% certain). And if you're not right than it's a weird piece of code. Have you tried changing it?
Nope, was hoping the maintainer could comment.
This could be one of those things which works by accident, since it translates to "if (flags)", which may be needed?, so I rather not change it without knowing the code well.
But I'm also 99% sure this is just a mistake and needs to be changed :)
participants (2)
-
Campbell Barton
-
Jasper van de Gronde