More warnings with gcc4.0
Playing more with the current pre-release of gcc4.0, I found some more warnings due to its greater strictness. Here are the warnings I got with CVS today. 'make clean ; make > /dev/null' is great for getting this listing. People might want to look at their files. I can clean up some of these tomorrow. Actually, this is not very many!
Bob
dropper-context.cpp: In function 'void sp_dropper_c32_color_copy_hex(guint32)': dropper-context.cpp:216: warning: unused variable 'pick'
file.cpp: In function 'void file_import(SPDocument*, const gchar*, Inkscape::Extension::Extension*)': file.cpp:752: warning: unused variable 'repr'
select-context.cpp: In function 'gint sp_select_context_item_handler(SPEventContext*, SPItem*, GdkEvent*)': select-context.cpp:276: warning: unused variable 'selection'
sp-item.cpp: In function 'SPItem* sp_item_first_item_child(SPObject*)': sp-item.cpp:1277: warning: control reaches end of non-void function
sp-pattern.cpp: In function 'void sp_pat_fill(SPPainter*, NRPixBlock*)': sp-pattern.cpp:909: warning: operation on 'px_x' may be undefined sp-pattern.cpp:940: warning: operation on 'px_x' may be undefined
dialogs/stroke-style.cpp: In function 'void sp_stroke_style_any_toggled(GtkToggleButton*, SPWidget*)': dialogs/stroke-style.cpp:1704: warning: unused variable 'items'
display/canvas-arena.cpp: In function 'void sp_canvas_arena_class_init(SPCanvasArenaClass*)': display/canvas-arena.cpp:91: warning: invalid access to non-static data member 'SPCanvasArenaClass::arena_event' of NULL object display/canvas-arena.cpp:91: warning: (perhaps the 'offsetof' macro was used incorrectly)
display/sp-canvas.cpp: In function 'void sp_canvas_item_class_init(SPCanvasItemClass*)': display/sp-canvas.cpp:110: warning: invalid access to non-static data member 'SPCanvasItemClass::event' of NULL object display/sp-canvas.cpp:110: warning: (perhaps the 'offsetof' macro was used incorrectly)
libnrtype/Layout-TNG-Output.cpp: In function 'const char* Inkscape::Text::weight_to_text(PangoWeight)': libnrtype/Layout-TNG-Output.cpp:214: warning: enumeration value 'PANGO_WEIGHT_SEMIBOLD' not handled in switch
livarot/float-line.cpp: In member function 'void FloatLigne::Affiche()': livarot/float-line.cpp:518: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t' livarot/float-line.cpp:524: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
widgets/sp-color-wheel.cpp: In function 'void sp_color_wheel_set_color(SPColorWheel*, const SPColor*)': widgets/sp-color-wheel.cpp:229: warning: operation on 'sat' may be undefined
On 4/20/05, Bob Jamison <rwjj@...127...> wrote:
display/canvas-arena.cpp: In function 'void sp_canvas_arena_class_init(SPCanvasArenaClass*)': display/canvas-arena.cpp:91: warning: invalid access to non-static data member 'SPCanvasArenaClass::arena_event' of NULL object display/canvas-arena.cpp:91: warning: (perhaps the 'offsetof' macro was used incorrectly)
display/sp-canvas.cpp: In function 'void sp_canvas_item_class_init(SPCanvasItemClass*)': display/sp-canvas.cpp:110: warning: invalid access to non-static data member 'SPCanvasItemClass::event' of NULL object display/sp-canvas.cpp:110: warning: (perhaps the 'offsetof' macro was used incorrectly)
These are old and annoying. Doesn't anyone have an idea of how to fix these?
libnrtype/Layout-TNG-Output.cpp: In function 'const char* Inkscape::Text::weight_to_text(PangoWeight)': libnrtype/Layout-TNG-Output.cpp:214: warning: enumeration value 'PANGO_WEIGHT_SEMIBOLD' not handled in switch
livarot/float-line.cpp: In member function 'void FloatLigne::Affiche()': livarot/float-line.cpp:518: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t' livarot/float-line.cpp:524: warning: format '%lu' expects type 'long unsigned int', but argument 2 has type 'size_t'
I fixed all except these.
bulia byak wrote:
On 4/20/05, Bob Jamison <rwjj@...127...> wrote:
display/canvas-arena.cpp: In function 'void sp_canvas_arena_class_init(SPCanvasArenaClass*)': display/canvas-arena.cpp:91: warning: invalid access to non-static data member 'SPCanvasArenaClass::arena_event' of NULL object display/canvas-arena.cpp:91: warning: (perhaps the 'offsetof' macro was used incorrectly)
display/sp-canvas.cpp: In function 'void sp_canvas_item_class_init(SPCanvasItemClass*)': display/sp-canvas.cpp:110: warning: invalid access to non-static data member 'SPCanvasItemClass::event' of NULL object display/sp-canvas.cpp:110: warning: (perhaps the 'offsetof' macro was used incorrectly)
These are old and annoying. Doesn't anyone have an idea of how to fix these?
I think that gtkmm-ification will get rid of this stuff, and the old marshalling junk.
Bob
On Tue, Apr 19, 2005 at 09:30:37PM -0500, Bob Jamison wrote:
bulia byak wrote:
On 4/20/05, Bob Jamison <rwjj@...127...> wrote:
display/canvas-arena.cpp: In function 'void sp_canvas_arena_class_init(SPCanvasArenaClass*)': display/canvas-arena.cpp:91: warning: invalid access to non-static data member 'SPCanvasArenaClass::arena_event' of NULL object display/canvas-arena.cpp:91: warning: (perhaps the 'offsetof' macro was used incorrectly)
display/sp-canvas.cpp: In function 'void sp_canvas_item_class_init(SPCanvasItemClass*)': display/sp-canvas.cpp:110: warning: invalid access to non-static data member 'SPCanvasItemClass::event' of NULL object display/sp-canvas.cpp:110: warning: (perhaps the 'offsetof' macro was used incorrectly)
These are old and annoying. Doesn't anyone have an idea of how to fix these?
I think that gtkmm-ification will get rid of this stuff, and the old marshalling junk.
Actually, I'm not planning on converting over the canvas stuff. It's reasonably encapsulated that I think we can call the C functions. There's a ton of code for the canvas, so that'd be a pretty big project to convert it over to C++. Plus, I'm figuring when we convert to Cairo as a canvas we may be replacing it all anyway.
Bryce
participants (3)
-
Bob Jamison -
Bryce Harrington -
bulia byak