bulia byak wrote:

Hi all,

in the last two days:

• on startup: ** (inkscape:18931): CRITICAL **: gdouble

sp_document_height(SPDocument*): assertion `document->root != NULL' failed

Hi, bulia!

I saw that, too. The problem seems minor. The GUI is too short. However, it was good to see it in a different way. I'm glad that you caught it, sir. :-)

If you look at the diagnostic, it's good that it caught a bad state. The root -was- screwed.

But its handling of the error is all wrong. Inkscape has far too many legacy assert()s and things like that in the source. This could be handled so much better by a little more Adrian Monk-like paranoid parameter checking. And follow that up by smarter error handling. Instead of dying or bailing, try to get back to a quiescent, default, safe state.

Maybe Inkscape needs a document and/or design pertaining to depths of error handling and recovery. Currently the depth is 0.

bob

On Thu, Jun 19, 2008 at 3:57 PM, bulia byak <buliabyak@...400...> wrote:

in the last two days:

Another one - though not as recent and already mentioned but very annoying, so I thought I'd mention it again: 2geom slowness. A several seconds freeze on startup, plus a noticeable (maybe up to half a second) freeze when you press + before it starts to redraw. Debugger reports that both these freezes are spent within 2geom.

Zitat von bulia byak <buliabyak@...400...>:

Hi all,

in the last two days:

• on startup: ** (inkscape:18931): CRITICAL **: gdouble

sp_document_height(SPDocument*): assertion `document->root != NULL' failed

[...]

• a green fish skeleton (!) is visible above the canvas on startup or

loading any document - not an object but some stray helperpath display, likely from a broken LPE

These two are caused by my recent commits. I'm sorry that I haven't fixed this yet. My first attempt was screwed by a broken internet connection, and at the moment I'm not at home and thus can't connect my laptop to the internet to commit a fix.

Both of these errors are harmless, though. The green skeleton is a helperpath from an icon which contains an LPE (namely, the icon for "edit next parameter on canvas"). Part of my recent changes was to add such helperpaths automatically for selected items with LPE applied. The bug is that the path in said icon is not selected but still a helperpath is shown. The console warning message is then displayed because in the helperpath code the item's transform is computed, which needs to access the document's height - but no document exists yet (at least that's what I assume).

A quick way to get rid of both errors (until I have internet access again and can commit a proper fix) is to comment out lines 354 and 355 in sp-lpe-item.cpp, which read

sp_lpe_item_remove_temporary_canvasitems(lpeitem, desktop); sp_lpe_item_add_temporary_canvasitems(lpeitem, desktop);

Could someone please do this for me? Thanks!

Sorry for the hassle (but at least it has initiated a discussion about proper error handling), Max