Fri, 6 Jun 2008 17:15:16 -0400 (EDT) Bob Jamison <rwjj@...127...> kirjoitti:

verbalshadow and I have been having link errors today. The reason is, that sp-filter.o and nr-filter.o both contain all of the methods of NR::Filter.

After a lot of searching, I noticed that sp-filter.cpp #includes nr-filter.cpp. Not the .h, but the .cpp. That can't be right. :-)

Does someone need to fix this? Things work nicely with that line commented out.

Now what the... The most confusing part is that this line has been in codebase for over a year. Like... how our codebase has been compilable for this long with such a bug in it?

To fix it, replace #include "display/nr-filter.cpp" with #include "display/nr-filter.h"

Feel free to make this change and commit it. It'll take some time before I can make it myself (in order of 20 hours)