Re: [Inkscape-devel] LPE cleanup
Hi all,
I just moved almost all 0.47 LPEs to the "experimental" section in the code. This means that they will not show up in the normal 0.47 builds. We need to make sure they work and don't crash, that there is a testfile in the testsuite and that they are useable too.
If you want to build Inkscape with experimental LPEs, make sure "LPE_ENABLE_TEST_EFFECTS" is defined. You can do that by editing config.h (in build.xml for windows, on linux I have no clue), or by editing /src/live_effects/effect.cpp at the start somewhere put: "#define LPE_ENABLE_TEST_EFFECTS"
Cheers, Johan
-----Original Message----- From: Engelen, J.B.C. (Johan) Sent: woensdag 7 januari 2009 23:22 To: bulia byak; Inkscape Devel List; Maximilian Albert; Maximilian Albert Subject: RE: [Inkscape-devel] LPE cleanup
Hi all, yeah, LPE is a mess :-( I'm sorry I contributed to that :-(
Recently, I improved the conditional compile of unfinished effects. Now, the "test effects" are not compiled, unless one #defines LPE_ENABLE_TEST_EFFECTS. So for example, probably nobody here has the dynamic stroke LPE in their list, while I and jfb have. Have a look in /src/live_effects/effect.cpp around line 80 to see how to hide effects that are not finished.
I am very tempted to move *all* new LPEs since 0.47 to the disabled part. Moreover, every effect should have a test svg that tests the effect in the testsuite; with a couple of not so simple cases of the effect working properly.
cheers, Johan
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: woensdag 7 januari 2009 3:57 To: Inkscape Devel List; Maximilian Albert; Maximilian Albert Subject: [Inkscape-devel] LPE cleanup
Hi guys,
what if, as a first step towards 0.47, we clean up the mess
in our LPE
list - remove proofs of concept, hide those that only make
sense in a
tool, merge similar ones per our discussion, remove or fix
those that
crash? Can anyone who's more in the loop please make a list of suggestions?
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about
anything
Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Sat, Jan 24, 2009 at 7:29 PM, <J.B.C.Engelen@...1578...> wrote:
Hi all,
I just moved almost all 0.47 LPEs to the "experimental" section in the code. This means that they will not show up in the normal 0.47 builds.
I think you've been a little overzealous :) Looks like you removed Spiro and the one used for stroke profiles. As a result stroke profiles in Pen/Pencil now crash, and Spiro does not work. Let's not disable LPEs that other code relies upon!
Max, can you please sort the pattern-along-path mess - so we have exactly one LPE of this type and it is used everywhere?
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: maandag 2 februari 2009 18:41 To: Engelen, J.B.C. (Johan) Cc: inkscape-devel@lists.sourceforge.net; Anhalter42@...173...; maximilian.albert@...1439...; scislac@...400... Subject: Re: [Inkscape-devel] LPE cleanup
On Sat, Jan 24, 2009 at 7:29 PM, <J.B.C.Engelen@...1578...> wrote:
Hi all,
I just moved almost all 0.47 LPEs to the "experimental"
section in the
code. This means that they will not show up in the normal
0.47 builds.
I think you've been a little overzealous :) Looks like you removed Spiro and the one used for stroke profiles.
Wow, that was dumb. I've reenabled spiro and freehand. But freehand should really be removed...
sorry that I broke things. I guess I was too annoyed by the LPE mess. :(
As a result stroke profiles in Pen/Pencil now crash, and Spiro does not work. Let's not disable LPEs that other code relies upon!
Max, can you please sort the pattern-along-path mess - so we have exactly one LPE of this type and it is used everywhere?
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
participants (2)
-
unknown＠example.com -
bulia byak