Re: [Inkscape-devel] Inkscape review
Okay, cool. I'll start implementing a whole series of item-only verbs.
As I said, don't make item-oriented variants for _all_ commands, but only for those that make little or no sense for a selection of multiple objects of different types.
I, too, think it should item-oriented. This may complicate the usage of verbs. Perhaps I will invent a "right-clicked" item in SPDesktop or SPView, similar to the "selection" stuff. That way once the verb gets called, it'll know what to take action on. Is there a better way to handle this?
I think the verbs should just take an optional SPItem* attribute, which if set will make them act on that item. That item is easy to figure out by sp_item_at_point, which depending on an argument returns an item with or without going into groups.
_________________________________________________________________ Tired of spam? Get advanced junk mail protection with MSN Premium http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI...
On Sat, 2004-05-15 at 17:15, bulia byak wrote:
I think the verbs should just take an optional SPItem* attribute, which if set will make them act on that item. That item is easy to figure out by sp_item_at_point, which depending on an argument returns an item with or without going into groups.
Well, maybe. That's better than creating special state in SPDesktop.
Ideally, since the code which created the context menu for that item knows the item, it should find some way to pass that on to the menuitem handlers (and therefore to the verb).
There are a lot of places, actually, where somebody "upstream" knows the relevent information. Doing some rearchitecting to plumb that information all the way down is often worth it...
-mental
Tired of spam? Get advanced junk mail protection with MSN Premium http://join.msn.com/?pgmarket=en-ca&page=byoa/prem&xAPID=1994&DI...
This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (2)
-
bulia byak -
MenTaLguY