Hi all,
Inkscape on Windows has had this warning for a looong time now:
(inkscape.exe:2628): Gtk-WARNING **: Could not find the icon 'edit-select-all'. The 'hicolor' theme was not found either, perhaps you need to install it. You can get a copy from: http://icon-theme.freedesktop.org/releases
The select-all icon is displayed correctly in the menu, but is not displayed in the toolbar.
I've been trying to get rid of this warning/error; and as a result I think I've found some legacy dead code concerning icons. Are /src/ui/icons.h and icons.cpp ever used sensibly? The only one calling to these files is edit-widget.cpp. If I remove that call "Icons::init();", nothing changes for me. (all icons are displayed correctly, except for the select all icon in the toolbar)
the code in similar files seems very old and not used: stock-items.cpp stock.h
Who can tell me more about these files? I am planning on deleting them.
Thanks, Johan
On Sun, Oct 12, 2008 at 7:03 PM, <J.B.C.Engelen@...1578...> wrote:
the code in similar files seems very old and not used: stock-items.cpp stock.h
Who can tell me more about these files? I am planning on deleting them.
I'd guess it's now Jon Cruz territory.
It seems to me that icon handling, as well as a few other areas, need a big overhaul. (The worst of them is of course toolbox.cpp)
A valuable improvement this area of the codebase would be to remove the monolithic icons.svg file, and instead provide themable icons as described here: http://live.gnome.org/ThemableAppSpecificIcons - this would allow custom icon themes to easily provide their own icons for Inkscape tools, actions, etc. I think this should also work on Windows, in the sense that the icons would still be shown.
participants (3)
-
unknown＠example.com -
bulia byak -
Krzysztof Kosiński