RE: [Inkscape-devel] shift+click to select broken
Just noticed that shift+click to select multiple objects is broken in HEAD... any suggestions for a fix?
Oops. My fault. Will fix now.
Fixed, please test. I had to make use of sp_document_partial_items_in_box() for this, which was in the code but never used, and fixed a bug in it so it could actually work.
While at it, I changed the behavior of shift-rubberband. Previously it toggled the selected status of all objects it affected, now it always adds to selection. Rationale: the semantics of rubberband ("include everything within this box") and toggle ("deselect what was selected and vice versa") do not mix, imho. Especially given simple rubberband (without shift) always selects objects, regardless of their past status. Shift-click, however, still toggles selection status, so you can select many objects with (shift-)rubberband and then deselect individual ones with shift-clicks. Comments?
And the main change which was the reason to dig into this code at all: now if Shift is pressed before you start dragging, you always get rubberband, even if you start from an object. I admit I stole this from Xara, but it's VERY convenient. Without it, if you had a big background object in your drawing, you simply could not use rubberband because you always ended up dragging the background. Now you can, just press Esc and then Shift-rubberband for a new selection.
_________________________________________________________________ Add photos to your e-mail with MSN 8. Get 2 months FREE*. http://join.msn.com/?page=features/photos&pgmarket=en-ca&RU=http%3a%...
On Fri, 2003-12-19 at 04:25, bulia byak wrote:
And the main change which was the reason to dig into this code at all: now if Shift is pressed before you start dragging, you always get rubberband, even if you start from an object. I admit I stole this from Xara, but it's VERY convenient. Without it, if you had a big background object in your drawing, you simply could not use rubberband because you always ended up dragging the background. Now you can, just press Esc and then Shift-rubberband for a new selection.
Dude! Thank you, this new behavior rocks!
-mental
On Fri, 2003-12-19 at 04:25, bulia byak wrote:
Fixed, please test. I had to make use of sp_document_partial_items_in_box() for this, which was in the code but never used, and fixed a bug in it so it could actually work.
Hrm, I still can't get shift+click (versus shift+drag) to work. :/
-mental
It still doesn't work for me either from most recent CVS.
jon
On Fri, 2003-12-19 at 04:08, MenTaLguY wrote:
On Fri, 2003-12-19 at 04:25, bulia byak wrote:
Fixed, please test. I had to make use of sp_document_partial_items_in_box() for this, which was in the code but never used, and fixed a bug in it so it could actually work.
Hrm, I still can't get shift+click (versus shift+drag) to work. :/
-mental
participants (3)
-
bulia byak
-
Jonathan Phillips
-
MenTaLguY