I updated the Wiki with information on the current testing framework(s). It now has some information on running/creating both unit tests and rendering tests: http://wiki.inkscape.org/wiki/index.php/TestingInkscape
I would welcome any feedback.
Hi Jasper,
The wiki page is nice. It helped me trying out your stuff.
I have a comment that I feel is important: Could you please rename "buildtool dist-cxxtests" to just "buildtool check", so it conforms with "make check", and also important: have btool run the cxxtests executable, so I don't have to go to inkscape's dir manually etc.
My result of running cxxtests was: Failed 22 of 175 tests
That correct?
Cheers, Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Jasper van de Gronde Sent: zaterdag 2 augustus 2008 14:28 To: inkscape Subject: [Inkscape-devel] Test documentation on Wiki
I updated the Wiki with information on the current testing framework(s). It now has some information on running/creating both unit tests and rendering tests: http://wiki.inkscape.org/wiki/index.php/TestingInkscape
I would welcome any feedback.
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
J.B.C.Engelen@...1578... wrote:
Hi Jasper,
The wiki page is nice. It helped me trying out your stuff.
I have a comment that I feel is important: Could you please rename "buildtool dist-cxxtests" to just "buildtool check", so it conforms with "make check", and also important: have btool run the cxxtests executable, so I don't have to go to inkscape's dir manually etc.
Making a buildtool check would indeed be nice, I'll see what I can do (shouldn't be too difficult). (The dist stuff is just to keep build.xml consistent with itself.)
My result of running cxxtests was: Failed 22 of 175 tests
That correct?
I can't check at the moment, but yes, it's something along those lines.
Hi Jasper,
I just tested the render test as well, wonderful! We should really do this in a cron job and publish it somewhere online!
Can you add the SVG testsuite?
(I have added a mingwenv.bat for windows devs, perhaps we should add binaries of tester.cpp so that the rendertest is also available for people that have not set up a build system?)
Thanks! Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Jasper van de Gronde Sent: zaterdag 2 augustus 2008 14:28 To: inkscape Subject: [Inkscape-devel] Test documentation on Wiki
I updated the Wiki with information on the current testing framework(s). It now has some information on running/creating both unit tests and rendering tests: http://wiki.inkscape.org/wiki/index.php/TestingInkscape
I would welcome any feedback.
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
J.B.C.Engelen@...1578... wrote:
Hi Jasper,
I just tested the render test as well, wonderful! We should really do this in a cron job and publish it somewhere online!
If anyone can suggest some hardware that could be used for this that would be great.
Can you add the SVG testsuite?
Unfortunately not. That is, in principle it's very easy to add, just put all the .svg's (except animation perhaps) somwhere in the cases directory (for example cases/w3c) and the tests will be run. However, nearly all of the tests have text in them. As these texts are rendered differently on each system (depending on the exact fonts used, etc.) the W3C references are pretty much useless.
In addition there are other relatively small differences between the way the W3C images are rendered and how Inkscape renders them (and in the few cases I've seen Inkscape is not necessarily worse).
If anyone knows how to eliminate all text from a bunch of SVGs or how to tell Inkscape not to render any text, then it might be possible to add a restricted set of the images and determine manually which files are rendered correctly and which ones aren't (time-consuming, but you only have to do it once, so it's doable).
(I have added a mingwenv.bat for windows devs, perhaps we should add binaries of tester.cpp so that the rendertest is also available for people that have not set up a build system?)
I don't have any problems with it, but I have no idea how other people feel about binaries in SVN. Also, if we were to set up a cron job there should be a lot less demand for people to run it themselves (especially if they don't work on Inkscape themselves).
Jasper van de Gronde wrote:
Can you add the SVG testsuite?
Unfortunately not. That is, in principle it's very easy to add, just put all the .svg's (except animation perhaps) somwhere in the cases directory (for example cases/w3c) and the tests will be run. However, nearly all of the tests have text in them. As these texts are rendered differently on each system (depending on the exact fonts used, etc.) the W3C references are pretty much useless.
In addition there are other relatively small differences between the way the W3C images are rendered and how Inkscape renders them (and in the few cases I've seen Inkscape is not necessarily worse).
If anyone knows how to eliminate all text from a bunch of SVGs or how to tell Inkscape not to render any text, then it might be possible to add a restricted set of the images and determine manually which files are rendered correctly and which ones aren't (time-consuming, but you only have to do it once, so it's doable).
Well it is simple enough to eliminate or hide text with a script. But some of the tests test text, right? Is it possible to find out which fonts actually appear in the test suite and ensure that they are found on the test system in question? Do I remember correctly that batik matches even the font in the SVG test suite?
Aaron Spike
Aaron Spike wrote:
Well it is simple enough to eliminate or hide text with a script. But some of the tests test text, right?
Indeed, those would obviously not be helped by such a procedure.
Is it possible to find out which fonts actually appear in the test suite and ensure that they are found on the test system in question?
Some of the tests use Arial, but a lot just don't specify any font, which seems to result in different fonts on different systems. How does Inkscape select a font in such a case?
Do I remember correctly that batik matches even the font in the SVG test suite?
From what I saw Batik doesn't even match simple shapes exactly. This doesn't necessarily mean it fails to render the shape correctly, just that it's slightly different from the reference image.
Is it possible to find out which fonts actually appear in the test suite and ensure that they are found on the test system in question?
Some of the tests use Arial, but a lot just don't specify any font, which seems to result in different fonts on different systems. How does Inkscape select a font in such a case?
If no font-family can be found for an element then we'll default to "Sans". What that means depends on the underlying font system. On Linux this is fontconfig, so it's whatever is configured there. See man 5 fonts.conf or http://fontconfig.org/fontconfig-user.html, where the example shows Sans resolving to Arial.
Richard.
participants (4)
-
unknown@example.com
-
Aaron Spike
-
Jasper van de Gronde
-
Richard Hughes