Table of Contents:
1) Attributes -- looks like 3d-box tool 2) Style -- may be a bad test? 3) Bezier issue -- no clue 4) Rotate inversion -- no clue
I'm not sure on all of these. I can of course start to look into them, but if you know you've modified these areas in the last year or so please look at the tests.
Thanks, Ted
--- 1 - Attribute test ---
In AttributesTest::testAttributes: ./../../src/attributes-test.h:448: Error: Test failed: "azimuth" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "elevation" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "in" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "limitingConeAngle" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "pointsAtX" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "pointsAtY" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "pointsAtZ" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "result" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "z" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 11 {inkscape:path-effect} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 53 {inkscape:snap-bbox} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 54 {inkscape:snap-nodes} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 55 {inkscape:snap-guide} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 56 {inkscape:snap-center} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 57 {inkscape:snap-intersection-grid-guide} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 58 {inkscape:snap-intersection-line-segments} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 61 {inkscape:bbox-paths} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 62 {inkscape:bbox-nodes} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 74 {inkscape:original-d} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 80 {inkscape:3dbox} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 81 {inkscape:box3dcornerA} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 82 {inkscape:box3dcornerB} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 83 {inkscape:box3dcornerC} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 84 {inkscape:perspective} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 85 {inkscape:box3dface} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 165 {flood-color} not handled" ./../../src/attributes-test.h:491: Warning: "Attribute string with enum 166 {flood-opacity} not handled" ./../../src/attributes-test.h:496: Error: Assertion failed: !found ./../../src/attributes-test.h:501: Error: Test failed: "Enum round-trip through string {flood-color} failed." ./../../src/attributes-test.h:501: Error: Expected (index == postLookup), found (165 != 257) ./../../src/attributes-test.h:501: Error: Test failed: "Enum round-trip through string {flood-opacity} failed." ./../../src/attributes-test.h:501: Error: Expected (index == postLookup), found (166 != 258)
--- 2 - Style ---
Testing style... sp_style_new, sp_style_write_string...Assertion `streq(str0_all, str0_all_exp)' failed sp_style_merge_from_style_string(whitespace, ifset...OK sp_style_merge_from_style_string(whitespace, always...Assertion `streq(str0_all, str0_all_exp)' failed sp_style_merge_from_style_string("fill:", ifset)...OK sp_style_merge_from_style_string("font-family:", always)...Assertion `streq(str0_all, str0_all_exp)' failed sp_style_merge_from_style_string("fill: ", ifset)...OK sp_style_merge_from_style_string("font-family: ", always)...Assertion `streq(str0_all, str0_all_exp)' failed sp_style_merge_from_style_string(":none", ifset)...OK invalid color setting: #4321...Assertion `streq(str0_set, "color:#123")' failed invalid color setting: currentColor...Assertion `streq(str0_set, "color:#123")' failed invalid color setting: #87654321...Assertion `streq(str0_set, "color:#123")' failed invalid color setting: #42...Assertion `streq(str0_set, "color:#123")' failed invalid color setting: aquam...Assertion `streq(str0_set, "color:#123")' failed sp_style_merge_from_style_string(default): ifset...Assertion `streq(ifset_str, str0_all_exp)' failed sp_style_merge_from_style_string(default): always...Assertion `streq(ifset_str, str0_all_exp)' failed sp_style_merge_from_style_string...Assertion `streq(str0_all, str0_all_exp)' failed SP_SCALE24_MUL...OK sp_style_merge_from_dying_parent: opacity...OK style: FAILED (6/18 tests passed)
--- 3 - Bezier issue ---
bezier_pt(1)...Assertion `bezier_pt(1, a, ti) == si * a[0] + ti * a[1]' failed sp_bezier_fit_cubic...Warning: got different control points from previously-coded (diffs=0x3c). Previous: (5, -3) (7.57134, -0.423509) (4.77929, 1.22426) (3, 3) Found: (5, -3) (7.32396, -0.46791) (5.06163, 1.32841) (3, 3) TODO: Update this test case for revised right_tangent implementation.
--- 4 - Rotate issue ---
inverse...Assertion `rot234.inverse() == NR::rotate(-.234)' failed
On Dec 10, 2007, at 9:53 PM, Ted Gould wrote:
./../../src/attributes-test.h:501: Error: Test failed: "Enum round- trip through string {flood-color} failed." ./../../src/attributes-test.h:501: Error: Expected (index == postLookup), found (165 != 257) ./../../src/attributes-test.h:501: Error: Test failed: "Enum round- trip through string {flood-opacity} failed." ./../../src/attributes-test.h:501: Error: Expected (index == postLookup), found (166 != 258)
OK. These are very nasty ones that seriously need attention.
They might even be an indication that our core internals have a fatal design flaw and needs to be fixed ASAP.
Mon, 10 Dec 2007 21:53:05 -0800 Ted Gould <ted@...11...> kirjoitti:
--- 1 - Attribute test ---
In AttributesTest::testAttributes: ./../../src/attributes-test.h:448: Error: Test failed: "azimuth" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "elevation" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false)
These, and the couple similar errors following indicate, that the testing code is expecting, that Inkscape can't handle lighting effects (part of filter effects), but as now Inkscape can handle them, the test gives errors.
On Tue, 2007-12-11 at 11:48 +0200, Niko Kiirala wrote:
Mon, 10 Dec 2007 21:53:05 -0800 Ted Gould <ted@...11...> kirjoitti:
--- 1 - Attribute test ---
In AttributesTest::testAttributes: ./../../src/attributes-test.h:448: Error: Test failed: "azimuth" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ./../../src/attributes-test.h:448: Error: Test failed: "elevation" ./../../src/attributes-test.h:448: Error: Expected (recognized == all_attrs[i].supported), found (true != false)
These, and the couple similar errors following indicate, that the testing code is expecting, that Inkscape can't handle lighting effects (part of filter effects), but as now Inkscape can handle them, the test gives errors.
Can you fix the test so that it checks the right stuff then?
Thanks, Ted
Ted Gould schrieb:
Table of Contents:
- Attributes -- looks like 3d-box tool
Some of them, yes but not all.
I'm not sure on all of these. I can of course start to look into them, but if you know you've modified these areas in the last year or so please look at the tests.
Does a warning like
"Attribute string with enum 85 {inkscape:box3dface} not handled"
mean that this particular attribute was simply not listed in attributes-test.h? In other words, is the correct solution to include the missing attributes in this file? Then it's now corrected for the 3D box related attributes. Don't know about the others, thus I've left them alone.
Max
On Thu, 2007-12-13 at 20:29 +0100, Maximilian Albert wrote:
Does a warning like
"Attribute string with enum 85 {inkscape:box3dface} not handled"
mean that this particular attribute was simply not listed in attributes-test.h? In other words, is the correct solution to include the missing attributes in this file? Then it's now corrected for the 3D box related attributes. Don't know about the others, thus I've left them alone.
I think that has fixed all the 3d box related ones, but there are more. I think the following ones, by their names, are probably related to:
* Paint Bucket fill * Grid Snapping * Live path effects
Can anyone working on those verify it?
Thanks, Ted
PS - Here's the output for your convenience:
In AttributesTest::testAttributes: ../../src/attributes-test.h:457: Error: Test failed: "azimuth" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "elevation" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "in" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "limitingConeAngle" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "pointsAtX" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "pointsAtY" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "pointsAtZ" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "result" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:457: Error: Test failed: "z" ../../src/attributes-test.h:457: Error: Expected (recognized == all_attrs[i].supported), found (true != false) ../../src/attributes-test.h:500: Warning: "Attribute string with enum 11 {inkscape:path-effect} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 53 {inkscape:snap-global} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 54 {inkscape:snap-bbox} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 55 {inkscape:snap-nodes} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 56 {inkscape:snap-guide} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 57 {inkscape:snap-center} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 58 {inkscape:snap-intersection-grid-guide} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 59 {inkscape:snap-intersection-line-segments} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 62 {inkscape:bbox-paths} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 63 {inkscape:bbox-nodes} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 75 {inkscape:original-d} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 169 {flood-color} not handled" ../../src/attributes-test.h:500: Warning: "Attribute string with enum 170 {flood-opacity} not handled" ../../src/attributes-test.h:505: Error: Assertion failed: !found ../../src/attributes-test.h:510: Error: Test failed: "Enum round-trip through string {flood-color} failed." ../../src/attributes-test.h:510: Error: Expected (index == postLookup), found (169 != 261) ../../src/attributes-test.h:510: Error: Test failed: "Enum round-trip through string {flood-opacity} failed." ../../src/attributes-test.h:510: Error: Expected (index == postLookup), found (170 != 262)
participants (4)
-
Jon A. Cruz -
Maximilian Albert -
Niko Kiirala -
Ted Gould