Hi all,
I've just committed a patch William Swanson did for the wishlist bug #169623 "Canvas color option" (https://bugs.launchpad.net/inkscape/+bug/169623). A rather popular wishlist (12 people declared being affected on LP). It compiles and works as expected on Windows XP and Ubuntu.
The canvas color is now set to the drawing background color (defined in the document properties), ignoring alpha. Thus if you choose a fully transparent black, the canvas will be black (instead of white as in the stable Inkscape version). Note that the modification doesn't affect exports (PNGs still use the alpha channel).
Don't hesitate to comment.
Regards, -- Nicolas
PS: Apparently the snap indicator color is broken (it never gets the white stroke it has in the 0.48.x branch when using a dark background - SnapIndicator::set_new_snaptarget is *always* called with pre_snap=false), but it seems that the bug was already in the trunk (also reproduced on Windows XP with 10760, 10700, 10614 and 10568).
I haven't tried but I'm curious: How does that background color affect blurred objects and antialiasing? I mean, the PNG files will have unassociated alpha, how does alpha blending of convoluted objects affect the result? Are the resulting files free of matte fringes in semi-transparent areas?
On 12/20/2011 12:57 PM, Nicolas Dufour wrote:
PS: Apparently the snap indicator color is broken
I don't know if it's broken or not, because I don't recall it being different. But feel free to change it; it has been suggested before by someone to have a tooltip similar to the ones from the measurement tool.
SnapIndicator::set_new_snaptarget is *always* called with pre_snap=false
Not true. I just tested it and at least at my system it behaves as expected. pre_snap is true when doing a pre-snap, and false when doing a regular snap. How did you test this?
Regards,
Diederik
Hi Diederik,
DeĀ : Diederik van Lierop <mail@...1689...> On 12/20/2011 12:57 PM, Nicolas Dufour wrote:
PS: Apparently the snap indicator color is broken
I don't know if it's broken or not, because I don't recall it being different. But feel free to change it; it has been suggested before by someone to have a tooltip similar to the ones from the measurement tool.
Just tested it on Ubuntu, and I confirm that with 0.48.x there's a white stroke on the text that no longer show with the trunk, and thus the blue text alone is very difficult to see on a dark background. Note that replacing it with the style used on the measurement tools is far better than the white stroke IMHO.
SnapIndicator::set_new_snaptarget is *always* called with pre_snap=false
Not true. I just tested it and at least at my system it behaves as expected. pre_snap is true when doing a pre-snap, and false when doing a regular snap. How did you test this?
I made the erroneous assumption that the snap tooltips were different on a dark background, and that it was handled by the pre-snap code. Must admit I completely misunderstood the code, sorry.
Regards, -- Nicolas
On 12/20/2011 09:47 PM, Nicolas Dufour wrote:
Hi Diederik,
De : Diederik van Lierop<mail@...1689...> On 12/20/2011 12:57 PM, Nicolas Dufour wrote:
PS: Apparently the snap indicator color is broken
I don't know if it's broken or not, because I don't recall it being different. But feel free to change it; it has been suggested before by someone to have a tooltip similar to the ones from the measurement tool.
Just tested it on Ubuntu, and I confirm that with 0.48.x there's a white stroke on the text that no longer show with the trunk, and thus the blue text alone is very difficult to see on a dark background. Note that replacing it with the style used on the measurement tools is far better than the white stroke IMHO.
I like measurement tool indicators more then what we have for showing snapping situations, too. Would it be a hard thing to implement? If nothing else, now we have inconsistent visual experience. I've talked to IRC guys about this a few times before, but was never that serious to actually raise that question here. ~suv, I'm pointing at you. ;) This seems about the right time to do so...
Regards, Vlada
On 12/21/2011 01:03 AM, Vladimir Savic wrote:
I like measurement tool indicators more then what we have for showing snapping situations, too. Would it be a hard thing to implement? If nothing else, now we have inconsistent visual experience.
Fixed as of rev. #10816.
Happy new year everyone!
Diederik
participants (4)
-
Diederik van Lierop -
gespertinoļ¼ ...400... -
Nicolas Dufour -
Vladimir Savic