On Dec 6, 2008, at 5:27 PM, Krzysztof Kosiński wrote: Are you sure? Last time I checked, only a few weeks ago, both sets of tests were being run. You just might be looking for the wrong type of output.

Jon A. Cruz wrote: I checked again, they indeed are run - the test I was looking for wasn't appearing in the output because of a runtime error (caused by a typo), and the output of CxxTest tests isn't too appealing as there's no indication of passed tests. I have corrected this now. What remains to be done is making all tests compile again (I just suppressed the compilation of the offending tests). By the way, attribute-test.h spews out a lot of errors, it may be worth looking at. Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/%22make-check%22-doesn%27t-run-unit-tests-tp2087685... Sent from the Inkscape - Dev mailing list archive at Nabble.com.

I have managed to fix the SVG tests, the only roadblock to successful make check compilation now is the XML test. There's a circular dependency: preferences.o -> libspxml.a -> libspsvg.a -> preferences.o. I tried linking with $(all_libs) but it fails. I wonder why does this work with the SVG test and when compiling the main executable. Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/%22make-check%22-doesn%27t-run-unit-tests-tp2087685... Sent from the Inkscape - Dev mailing list archive at Nabble.com.

Krzysztof Kosiński wrote: I've just removed the sp_main_* stubs from the individual headers and put them in a separate file src/test-stubs.cpp to make the unit tests build again on Windows. If someone could add it in the right places in the Makefiles that would be great.

Krzysztof Kosiński wrote: Update: I have a commit-ready version of this, and the number of modifications needed to add an unit test to a directory which doesn't have any dropped from 5 in 2 files to 1 in 1 file. Additionally, there is only one log file to check after running the tests, and there's no need for a stub implementation of preferences to reside in test-stubs.cpp (it would only contain sp_main_gui and sp_main_console until those functions are removed). Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/%22make-check%22-doesn%27t-run-unit-tests-tp2087685... Sent from the Inkscape - Dev mailing list archive at Nabble.com.

Jon A. Cruz wrote: OK, but what are those reasons to keep CxxTests separate? As I see it, this has a number of disadvantages: 1. Lots of error-prone makefile boilerplate needed 2. Test logs are scattered all over the build directory 3. Building and linking the tests takes more time 4. Each test has to specify which libraries it needs 5. We need the test-stubs.cpp file with a stub preferences implementation The only advantages I see are: 1. If some test crashes, others can run (but then it's an obvious error either in the testand should be corrected right away) 2. The number of failed tests shown after "make check" is slightly more meaningful 3. Higher chance of conflicts between test headers (I encountered only one and corrected it already) My single-test implementation uses a variable named CXXTEST_TESTSUITES, to which all test headers are appended in Makefile_inserts. The only test-related thing left in Makefile_inserts is the list of test headers. I think it's more convenient and simpler than the exisitng system. Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/%22make-check%22-doesn%27t-run-unit-tests-tp2087685... Sent from the Inkscape - Dev mailing list archive at Nabble.com.

Jon A. Cruz wrote: Actually, this needs to be done not when a directory is created, but when tests are added to a directory that doesn't have any. Currently there are tests only in 6 directories. The single-test-executable solution just ensures that adding a test to a directory that doesn't have any unit tests yet is equally simple as adding one to a directory that has some - it's much simpler to maintain, and eliminates the need to maintain a list of test log files to be removed during "make distclean". It's also consistent with the Windows build system which uses a single test executable. Jon A. Cruz wrote: OK, so how to redirect all logs to a single file? Jon A. Cruz wrote: A stub implementation of preferences also existed before I did the rewrite, the only difference was that it required less code. Advantage 1: not really an advantage. Advantage 2: this number is so off at the moment as to not be a factor. Advantage 3: strongly possible. The risk of conflicts can be mitigated if tests are kept contained in their respective objects, e.g. any objects the test needs are members of the test suite object, rather than global. Jon A. Cruz wrote: I don't really understand what do you mean by this - the tests have to be listed in Makefiles regardless of the approach, because they have to be passed as arguments to cxxtestgen.pl. Wildcarding cannot be used because Automake doesn't support wildcards or pattern rules. Jon A. Cruz wrote: Your response to disadvantage 3 indicates that running a subset of the tests won't gain us much time, and running the whole test suite ensures that no unforeseen side effects were introduced. Also, you can't run "make check" in a subdirectory, you'd have to run the tests manually after building them. My original disadvantage 3 doesn't really hold because on multi-core machines it may be faster to compile the tests in parallel (make -j). Either way, the differences would be minimal. Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/%22make-check%22-doesn%27t-run-unit-tests-tp2087685... Sent from the Inkscape - Dev mailing list archive at Nabble.com.

Bob Jamison-2 wrote: Er, isn't this the wrong thread? By the way, GIO works on byte streams and has no concept of a "character", so if there's a need to read a file character by character I'll just derive a custom GInputStream that reads whole UTF-8 characters only. Regards, Krzysztof Kosiński -- View this message in context: http://www.nabble.com/%22make-check%22-doesn%27t-run-unit-tests-tp2087685... Sent from the Inkscape - Dev mailing list archive at Nabble.com.