All hands to Merge Requests!
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Good call Martin!
We're moving to Gitlab! Yeah! can't wait for that to happen! A new era for the project will begin. ;-)
--Victor Westmann
2017-06-03 10:59 GMT-07:00 Martin Owens <doctormo@...400...>:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Dear Martin,
I am not sure how to proceed with my bool lpe. Should it be finalized in bzr until some deadline, or should I move it over somehow (manually) to some git server?
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Hi Michael, the remaining items are this I propose to you?
If yes, we can do a merge and add it lately. Ping me if want me to do the merge.
All the best, Jabier.
On Sun, 2017-06-04 at 17:00 +0200, Michael Soegtrop wrote:
Dear Martin,
I am not sure how to proceed with my bool lpe. Should it be finalized in bzr until some deadline, or should I move it over somehow (manually) to some git server?
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Dear Jabier,
I am doing the merge to the latest version right now - there are a few conflicts I need to resolve. Then I will check the compile / functiuonality.
If everything is fine, I would suggest that you commit it to the mainline (or however you call this in bazar). The feature / UI polishing requests you had are much easier to do in git for me.
Best regards,
Michael
On 04.06.2017 22:32, Jabier Arraiza wrote:
Hi Michael, the remaining items are this I propose to you?
If yes, we can do a merge and add it lately. Ping me if want me to do the merge.
All the best, Jabier.
On Sun, 2017-06-04 at 17:00 +0200, Michael Soegtrop wrote:
Dear Martin,
I am not sure how to proceed with my bool lpe. Should it be finalized in bzr until some deadline, or should I move it over somehow (manually) to some git server?
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Perfect. Keep waiting.
Thanks for your work!
Jabier.
On Mon, 2017-06-05 at 12:25 +0200, Michael Soegtrop wrote:
Dear Jabier,
I am doing the merge to the latest version right now - there are a few conflicts I need to resolve. Then I will check the compile / functiuonality.
If everything is fine, I would suggest that you commit it to the mainline (or however you call this in bazar). The feature / UI polishing requests you had are much easier to do in git for me.
Best regards,
Michael
On 04.06.2017 22:32, Jabier Arraiza wrote:
Hi Michael, the remaining items are this I propose to you?
If yes, we can do a merge and add it lately. Ping me if want me to do the merge.
All the best, Jabier.
On Sun, 2017-06-04 at 17:00 +0200, Michael Soegtrop wrote:
Dear Martin,
I am not sure how to proceed with my bool lpe. Should it be finalized in bzr until some deadline, or should I move it over somehow (manually) to some git server?
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Dear Jabier,
I merged with the latest trunk version, tested it and pushed it to BZR. Can you please go ahead?
I will do the feature requests in git then.
One note: I just remembered that I split my two LPEs into two branches (the bool lpe and the embrodery LPE). Shall we proceed with the embordery branch in the same way?
Best regards,
Michael
On 04.06.2017 22:32, Jabier Arraiza wrote:
Hi Michael, the remaining items are this I propose to you?
If yes, we can do a merge and add it lately. Ping me if want me to do the merge.
All the best, Jabier.
On Sun, 2017-06-04 at 17:00 +0200, Michael Soegtrop wrote:
Dear Martin,
I am not sure how to proceed with my bool lpe. Should it be finalized in bzr until some deadline, or should I move it over somehow (manually) to some git server?
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
I commit it this evening.
About embrodery, if is finish to merge mark it for review and I try to do tonight. If not the branch is "moved" to gitlab and you can continue his development here. Anyway I recomend get a fresh local clone of the branches not merged for extra security.
Cheers, Jabier.
On Mon, 2017-06-05 at 15:06 +0200, Michael Soegtrop wrote:
Dear Jabier,
I merged with the latest trunk version, tested it and pushed it to BZR. Can you please go ahead?
I will do the feature requests in git then.
One note: I just remembered that I split my two LPEs into two branches (the bool lpe and the embrodery LPE). Shall we proceed with the embordery branch in the same way?
Best regards,
Michael
On 04.06.2017 22:32, Jabier Arraiza wrote:
Hi Michael, the remaining items are this I propose to you?
If yes, we can do a merge and add it lately. Ping me if want me to do the merge.
All the best, Jabier.
On Sun, 2017-06-04 at 17:00 +0200, Michael Soegtrop wrote:
Dear Martin,
I am not sure how to proceed with my bool lpe. Should it be finalized in bzr until some deadline, or should I move it over somehow (manually) to some git server?
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Dear Martin,
just a note on my branches: the embroidery branch includes the bool LPE from the lpe-bool branch + an embroidery stitch LPE. Javier reviewed the embroidery branch, so this should be taken. The lpe-bool branch can be discarded then. The reason for this duplication is that it was discussed to take the bool LPE into 0.92 but not the embroidery LPE, so I split it back then. But then time was to tight and neither made it.
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Dear Michael,
Can you provide a link to your unmerged branch please?
Best Regards, Martin Owens
On Mon, 2017-06-05 at 22:54 +0200, Michael Soegtrop wrote:
Dear Martin,
just a note on my branches: the embroidery branch includes the bool LPE from the lpe-bool branch + an embroidery stitch LPE. Javier reviewed the embroidery branch, so this should be taken. The lpe-bool branch can be discarded then. The reason for this duplication is that it was discussed to take the bool LPE into 0.92 but not the embroidery LPE, so I split it back then. But then time was to tight and neither made it.
Best regards,
Michael
On 03.06.2017 19:59, Martin Owens wrote:
Dear developers,
There are 23 active merge requests into our bzr branch system. Please go to:
https://code.launchpad.net/inkscape/+activereviews
And find a merge request to review. Reviewing this code, we can decide if it's code we should have or if it's safe to discard.
Some of the items are "needs fixing", if the fix looks interesting or important and you think you can bring it over the line and get it in, please do help. And we can consolidate and clean up the merge requests before the great git gearing.
Give a little of your time for the project to get us to git. Thanks everyone!
Best Regards, Martin Owens Bazaar Sanitation Services
Dear Martin,
they are in the list you linked:
This is the branch containing both, the bool LPE and the embroidery stitching LPE:
https://code.launchpad.net/~msoegtrop/inkscape/embroidery
This branch contains only the bool LPE:
https://code.launchpad.net/~msoegtrop/inkscape/lpe-bool
The embroidery stitch LPE is not yet 100% - it can take a long time if inappropriate options are given, but it is already useful as is. Also it is in no way invasive, so it shouldn't hurt to have it. But I leave it to you which one you take - both are reviewed.
Best regards,
Michael
participants (4)
-
Jabier Arraiza -
Martin Owens -
Michael Soegtrop -
Victor Westmann