On Thu, Nov 03, 2005 at 11:03:06PM -0800, Ted Gould wrote:

On Thu, 2005-11-03 at 17:14 -0800, Bryce Harrington wrote:

...

On Thu, Nov 03, 2005 at 12:48:28AM -0800, Bryce Harrington wrote:

...

On Wed, Nov 02, 2005 at 11:22:59PM -0800, Ted Gould wrote:

...

Is there anyway that we could have this do a make test also? That might motivate more people to write tests, and give faster feedback when they fail...

Yep, easy.

Here's the results from make check.

=================== All 25 tests passed ===================

Running 56 tests........................................................OK! PASS: test-all Testing attributes... attribute lookup...OK attributes: OK (all 1 passed) PASS: attributes-test Testing sp_relative_path_from_path... sp_relative_path_from_path...OK sp_relative_path_from_path: OK (all 1 passed) PASS: dir-util-test Testing extract_uri... url(#foo)...OK url foo ...OK url...OK url ...OK url()...OK url ( ) ...OK url foo bar ...OK extract_uri: OK (all 7 passed) PASS: extract-uri-test Testing mod360.cpp... same_double...OK mod360...OK mod360.cpp: OK (all 2 passed) PASS: mod360-test Testing round... non-neg round...OK non-pos round...OK round: OK (all 2 passed) PASS: round-test

** (process:25020): WARNING **: Could not open units file '/usr/share/inkscape/ui/uni ts.txt': No such file or directory

** (process:25020): WARNING **: * INKSCAPE_DATADIR is: '/usr/share'

** (process:25020): WARNING **: * INKSCAPE_UIDIR is: '/usr/share/inkscape/ui'

Testing gradient... init...OK sp_object_set("gradientTransform")...OK write...OK get_g2d, get_gs2d, set_gs2d...OK gradient: OK (all 4 passed) PASS: sp-gradient-test

** (process:25023): WARNING **: Could not open units file '/usr/share/inkscape/ui/uni ts.txt': No such file or directory

** (process:25023): WARNING **: * INKSCAPE_DATADIR is: '/usr/share'

** (process:25023): WARNING **: * INKSCAPE_UIDIR is: '/usr/share/inkscape/ui'

Testing SPStyleElem... init...OK sp_object_set("type")...OK write...OK build...OK read_content...OK SPStyleElem: OK (all 5 passed) PASS: sp-style-elem-test

** (process:25026): WARNING **: Could not open units file '/usr/share/inkscape/ui/uni ts.txt': No such file or directory

** (process:25026): WARNING **: * INKSCAPE_DATADIR is: '/usr/share'

** (process:25026): WARNING **: * INKSCAPE_UIDIR is: '/usr/share/inkscape/ui'

Testing style... sp_style_new, sp_style_write_string...font-size:medium;font-style:normal;font-variant:normal;font-weight:normal;font-stretch:normal;text-indent:0;text-align:start;text-decoration:none;line-height:normal;letter-spacing:normal;word-spacing:normal;text-transform:none;direction:ltr;block-progression:tb;writing-mode:lr-tb;text-anchor:start;opacity:1;color:#000000;fill:#000000;fill-opacity:1;fill-rule:nonzero;stroke:none;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;marker:none;marker-start:none;marker-mid:none;marker-end:none;stroke-miterlimit:4;stroke-dasharray:none;stroke-dashoffset:0;stroke-opacity:1;visibility:visible;display:inline;overflow:visible;font-family:Bitstream Vera SansOK sp_style_merge_from_style_string(whitespace, ifset...OK sp_style_merge_from_style_string(whitespace, always...OK sp_style_merge_from_style_string("fill:", ifset)...OK sp_style_merge_from_style_string("font-family:", always)...OK sp_style_merge_from_style_string("fill: ", ifset)...OK sp_style_merge_from_style_string("font-family: ", always)...OK sp_style_merge_from_style_string(":none", ifset)...OK invalid color setting: #4321...OK invalid color setting: currentColor...OK invalid color setting: #87654321...OK invalid color setting: #42...OK invalid color setting: aquam...OK sp_style_merge_from_style_string(default): ifset...OK sp_style_merge_from_style_string(default): always...OK sp_style_merge_from_style_string...OK SP_SCALE24_MUL...OK sp_style_merge_from_dying_parent: opacity...OK style: OK (all 18 passed) PASS: style-test Testing bezier-utils.cpp... copy_without_nans_or_adjacent_duplicates...OK bezier_pt(1)...OK bezier_pt(2)...OK bezier_pt(3)...OK compute_max_error_ratio...OK chord_length_parameterize...OK generate_bezier...OK sp_bezier_fit_cubic_full...OK sp_bezier_fit_cubic...Warning: got different control points from previously-coded (diffs=0x3c). Previous: (5, -3) (7.57134, -0.423509) (4.77929, 1.22426) (3, 3) Found: (5, -3) (7.32396, -0.46791) (5.06163, 1.32841) (3, 3) TODO: Update this test case for revised right_tangent implementation. OK bezier-utils.cpp: OK (all 9 passed) PASS: display/bezier-utils-test Testing sp_units_get_pixels, sp_pixels_get_units... 1.0 pt -> 1.0 pt...OK 1.0 pt -> 1.0 pt...OK convert 1.0 pt -> 1.0 pt...OK convert 1.0 pt -> 1.0 pt...OK 5.0 pt -> 5.0 pt...OK 5.0 pt -> 5.0 pt...OK convert 5.0 pt -> 5.0 pt...OK convert 5.0 pt -> 5.0 pt...OK 1.0 in -> 72.0 pt...OK 72.0 pt -> 1.0 in...OK convert 1.0 in -> 72.0 pt...OK convert 72.0 pt -> 1.0 in...OK 2.0 in -> 144.0 pt...OK 144.0 pt -> 2.0 in...OK convert 2.0 in -> 144.0 pt...OK convert 144.0 pt -> 2.0 in...OK 254.0 mm -> 720.0 pt...OK 720.0 pt -> 254.0 mm...OK convert 254.0 mm -> 720.0 pt...OK convert 720.0 pt -> 254.0 mm...OK 254.0 cm -> 7200.0 pt...OK 7200.0 pt -> 254.0 cm...OK convert 254.0 cm -> 7200.0 pt...OK convert 7200.0 pt -> 254.0 cm...OK 254.0 m -> 720000.0 pt...OK 720000.0 pt -> 254.0 m...OK convert 254.0 m -> 720000.0 pt...OK convert 720000.0 pt -> 254.0 m...OK 1.5 mm -> 4.3 pt...OK 4.3 pt -> 1.5 mm...OK convert 1.5 mm -> 4.3 pt...OK convert 4.3 pt -> 1.5 mm...OK sp_units_get_pixels, sp_pixels_get_units: OK (all 32 passed) Testing unit table... sp_units_table_sane...OK unit table: OK (all 1 passed) PASS: helper/units-test Testing in-svg-plane.h... in_svg_plane...OK in-svg-plane.h: OK (all 1 passed) PASS: libnr/in-svg-plane-test Testing Matrix... basic constructors, operator=...OK scale constructor...OK rotate constructor...OK translate constructor...OK test_identity...OK inverse...OK nr_matrix_invert...OK elliptic quadratic form...OK Matrix * rotate...OK translate*scale, scale*translate...OK Matrix * scale...OK Matrix: OK (all 11 passed) PASS: libnr/nr-matrix-test Testing nr-point-fns... L1...OK L2...OK LInfty...OK is_zero...OK atan2...OK unit_vector...OK nr-point-fns: OK (all 7 passed) PASS: libnr/nr-point-fns-test Testing rotate... constructors, comparisons...OK operator=...OK inverse...OK operator*(Point, rotate)...OK operator*(rotate, rotate)...OK operator/(rotate, rotate)...OK rotate: OK (all 6 passed) PASS: libnr/nr-rotate-test Testing rotate-fns... rotate_degrees...OK rotate-fns: OK (all 1 passed) PASS: libnr/nr-rotate-fns-test Testing NR::scale... x,y constructor and operator[] const...OK copy constructor, operator==, operator!=...OK operator=...OK point constructor...OK operator*(Point, scale)...OK operator*(scale, scale)...OK operator/(scale, scale)...OK NR::scale: OK (all 7 passed) PASS: libnr/nr-scale-test Testing translate... constructors, operator[]...OK operator=...OK operator*(translate, translate)...OK operator*(Point, translate)...OK identity...OK translate: OK (all 5 passed) PASS: libnr/nr-translate-test Testing Basic NR::Point operations... X,Y values...OK x,y constructor and operator[] const...OK copy constructor...OK non-const operator[]...OK binary +, -...OK unary-...OK scale, divide...OK dot...OK L1, L2, LInfty norms...OK operator+=...OK operator/=...OK normalize...OK Basic NR::Point operations: OK (all 12 passed) PASS: libnr/nr-types-test Running 48 tests................................................OK! PASS: libnr/test-nr Running 6 tests......OK! PASS: svg/test-svg Testing List Container... range constructor...OK equality tests...OK lessthan tests...OK assignment operator...OK fill constructor...OK container size...OK appending...OK bulk appending...OK prepending...OK single-value insertion...OK single-value erasure...OK pop_front...OK erase_after...OK List Container: OK (all 13 passed) PASS: util/list-container-test Running 2 tests..OK! PASS: xml/test-xml Testing xml_quoted_strlen... xml_quoted_strlen...OK xml_quoted_strlen: OK (all 1 passed) Testing xml_quote_strdup... xml_quote_strdup...OK xml_quote_strdup: OK (all 1 passed) PASS: xml/quote-test Testing XML Transactions... rollback of node addition...OK rollback of node removal...OK rollback of node reordering...OK XML Transactions: OK (all 3 passed) PASS: xml/repr-action-test =================== All 25 tests passed ===================