Extension: Merge Style
Hi devs,
I've committed in r13161 an extension which will take the inline styles from the selected elements, find the common values and create a new css style in the existing or new style element at the top of the document. This replaces the inline styles with a class reference.
<rect style="fill:red;"/> <rect style="fill:red;"/> <rect style="fill:yellow;"/> <rect style="fill:red;stroke:green;"/>
Becomes:
<style> .name_of_choice { fill:red; } </style> <rect class="foo"/> <rect class="foo"/> <rect style="fill:yellow;"/> <rect class="foo" style="stroke:green;"/>
I've added this into the extensions menu under Stylesheets > Merge Styles into CSS. And I decided to push it into trunk instead of just keeping it on my hard drive because it might be useful to other users.
But I'd also like to sound it out too. So any issues you think, I'd love to hear. This should make it easier to make web svg I think.
Best Regards, Martin Owens
Hi Martin
it sounds good, just 1 thing that came up when testing : the script doesn't check if style exist when launching. So this can result in duplicate style if you do it twice on a shape.
Personnally i think that doing 2 different actions : - get_style_from_shape - apply_style would help avoid this situation and give more flexibility.
cheers
----- Mail original ----- De: "Martin Owens" <doctormo@...400...> À: "Inkscape Developer Mailing List" <inkscape-devel@...1239....net> Envoyé: Lundi 17 Mars 2014 15:36:52 Objet: [Inkscape-devel] Extension: Merge Style
Hi devs,
I've committed in r13161 an extension which will take the inline styles from the selected elements, find the common values and create a new css style in the existing or new style element at the top of the document. This replaces the inline styles with a class reference.
<rect style="fill:red;"/> <rect style="fill:red;"/> <rect style="fill:yellow;"/> <rect style="fill:red;stroke:green;"/>
Becomes:
<style> .name_of_choice { fill:red; } </style> <rect class="foo"/> <rect class="foo"/> <rect style="fill:yellow;"/> <rect class="foo" style="stroke:green;"/>
I've added this into the extensions menu under Stylesheets > Merge Styles into CSS. And I decided to push it into trunk instead of just keeping it on my hard drive because it might be useful to other users.
But I'd also like to sound it out too. So any issues you think, I'd love to hear. This should make it easier to make web svg I think.
Best Regards, Martin Owens
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Tue, 2014-03-18 at 14:11 +0100, radar.map35@...8... wrote:
Personnally i think that doing 2 different actions :
- get_style_from_shape
- apply_style
would help avoid this situation and give more flexibility.
This sounds interesting, but I don't understand it. You advocate for a two step process? Would the user copy the style onto the clipboard after the first step?
Thanks for testing Radar.
Note: There's also a bug I need to fix #167937 which is making this extension much less useful.
Best Regards, Martin Owens
Yes a 2-step process i would use with 2 menus. At the end we can imagine there is a class window thatlet's the user interact with this.
But i was not really thinking a using clipboard but more : - get_style : extract css from actual style attribute of the selected object (I would say only one), create and write the class in svg file - apply_style : could provide a text entry (or best a list of available class) and add it to the selected element
the idea here is a bit different from yours but would avoid some strange behaviour it has for example when selected shapes are different (as many as they are).
I'll do some tests But i may submit a bug too.
pygmee
----- Mail original ----- De: "Martin Owens" <doctormo@...400...> À: "radar map35" <radar.map35@...8...> Cc: "Inkscape Developer Mailing List" inkscape-devel@lists.sourceforge.net Envoyé: Mardi 18 Mars 2014 14:15:49 Objet: Re: [Inkscape-devel] Extension: Merge Style
On Tue, 2014-03-18 at 14:11 +0100, radar.map35@...8... wrote:
Personnally i think that doing 2 different actions :
- get_style_from_shape
- apply_style
would help avoid this situation and give more flexibility.
This sounds interesting, but I don't understand it. You advocate for a two step process? Would the user copy the style onto the clipboard after the first step?
Thanks for testing Radar.
Note: There's also a bug I need to fix #167937 which is making this extension much less useful.
Best Regards, Martin Owens
participants (2)
-
unknown＠example.com -
Martin Owens