Hey all,
It appears that the 2 last commits made to trunk had modified files in the 2geom directory. Unfortunately these modifications were done in our in-tree copy only which is effectively forbidden. This message is just a friendly reminder to everyone that the process is that changes are to be made upstream in lib2geom and then brought into Inkscape's copy. Jon, if you do not have commit access to lib2geom please submit a diff of your changes as soon as you can.
Cheers, Josh
On Oct 27, 2011, at 9:16 AM, Josh Andler wrote:
Hey all,
It appears that the 2 last commits made to trunk had modified files in the 2geom directory. Unfortunately these modifications were done in our in-tree copy only which is effectively forbidden. This message is just a friendly reminder to everyone that the process is that changes are to be made upstream in lib2geom and then brought into Inkscape's copy. Jon, if you do not have commit access to lib2geom please submit a diff of your changes as soon as you can.
Yes, that's the plan.
The immediate problem was malformed comments bringing the whole copyright block into the namespace documentation. For those, the fix done was kept minimal so the upstream patch should be no problem.
Are any directories other than the 2geom directory related to internal copies of external libraries? In other words, should modifications in other directories than 2geom/ also be pushed externally?
2011/10/27 Jon Cruz <jon@...18...>:
On Oct 27, 2011, at 9:16 AM, Josh Andler wrote:
Hey all,
It appears that the 2 last commits made to trunk had modified files in the 2geom directory. Unfortunately these modifications were done in our in-tree copy only which is effectively forbidden. This message is just a friendly reminder to everyone that the process is that changes are to be made upstream in lib2geom and then brought into Inkscape's copy. Jon, if you do not have commit access to lib2geom please submit a diff of your changes as soon as you can.
Yes, that's the plan.
The immediate problem was malformed comments bringing the whole copyright block into the namespace documentation. For those, the fix done was kept minimal so the upstream patch should be no problem.
The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@...2689... Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On Fri, Oct 28, 2011 at 10:51 AM, Kris De Gussem <kris.degussem@...400...> wrote:
Are any directories other than the 2geom directory related to internal copies of external libraries? In other words, should modifications in other directories than 2geom/ also be pushed externally?
Depending on the library, possibly. I believe things are being worked on for submitting some changes upstream to libcroco. Likewise, it had been mentioned that there were some usability customizations we made to libgdl which were being discussed to send upstream. If you happen to find anything applicable we can always submit patches upstream if they seem right. (Note: With libcroco not all of our changes really belong upstream, so they're working on being cherry-picked now.
If we have any other in-tree copies of other libs, someone please bring them up.
Cheers, Josh
participants (3)
-
Jon Cruz -
Josh Andler -
Kris De Gussem