I got this error when trying to build the code this evening. I fixed it by putting an include for stdlib.h in arikkei-token.c.
arikkei-token.c: In function `gchar* arikkei_token_strdup(const ArikkeiToken*)': arikkei-token.c:83: `malloc' undeclared (first use this function) arikkei-token.c:83: (Each undeclared identifier is reported only once for each function it appears in.) make[3]: *** [arikkei-token.o] Error 1 make[3]: Leaving directory `/home/bryce/src/Inkscape/inkscape-integration/src/libarikkei' make[2]: *** [all-recursive] Error 1
$ cvs log src/libarikkei/arikkei-token.c
RCS file: /cvsroot/inkscape/inkscape/src/libarikkei/arikkei-token.c,v Working file: src/libarikkei/arikkei-token.c ---------------------------- revision 1.3 date: 2003/11/11 20:03:20; author: magnethead; state: Exp; lines: +1 -2 Patches to make compile on OSX/Darwin. malloc.h replace with unistd.h and Wl in src/Makefile.am removed at --export-dynamic ----------------------------
Looks like this was introduced due to the OSX/Darwin patch. Hopefully my fix doesn't break that.
Bryce
A fresh checkout shows that your change works just as well under OSX / Fink libs. I do want to note however the unistd.h include was a referral from RangerRick at #fink. He said that was the "standard"
feh.
-thomas
On Nov 12, 2003, at 2:36 AM, Bryce Harrington wrote:
I got this error when trying to build the code this evening. I fixed it by putting an include for stdlib.h in arikkei-token.c.
arikkei-token.c: In function `gchar* arikkei_token_strdup(const ArikkeiToken*)': arikkei-token.c:83: `malloc' undeclared (first use this function) arikkei-token.c:83: (Each undeclared identifier is reported only once for each function it appears in.) make[3]: *** [arikkei-token.o] Error 1 make[3]: Leaving directory `/home/bryce/src/Inkscape/inkscape-integration/src/libarikkei' make[2]: *** [all-recursive] Error 1
$ cvs log src/libarikkei/arikkei-token.c
RCS file: /cvsroot/inkscape/inkscape/src/libarikkei/arikkei-token.c,v Working file: src/libarikkei/arikkei-token.c
revision 1.3 date: 2003/11/11 20:03:20; author: magnethead; state: Exp; lines: +1 -2 Patches to make compile on OSX/Darwin. malloc.h replace with unistd.h and Wl in src/Makefile.am removed at --export-dynamic
Looks like this was introduced due to the OSX/Darwin patch. Hopefully my fix doesn't break that.
Bryce
This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
No prob, it's common to have regressions like this when porting, no big deal. This is why we commit such patches right *after* a major release instead of right before it. ;-)
Actually the _correct_ solution to this problem is to use autoconf. One day we will know how, and can take care of it then.
Bryce
On Wed, 12 Nov 2003, T Ingham wrote:
A fresh checkout shows that your change works just as well under OSX / Fink libs. I do want to note however the unistd.h include was a referral from RangerRick at #fink. He said that was the "standard"
feh.
-thomas
On Nov 12, 2003, at 2:36 AM, Bryce Harrington wrote:
I got this error when trying to build the code this evening. I fixed it by putting an include for stdlib.h in arikkei-token.c.
arikkei-token.c: In function `gchar* arikkei_token_strdup(const ArikkeiToken*)': arikkei-token.c:83: `malloc' undeclared (first use this function) arikkei-token.c:83: (Each undeclared identifier is reported only once for each function it appears in.) make[3]: *** [arikkei-token.o] Error 1 make[3]: Leaving directory `/home/bryce/src/Inkscape/inkscape-integration/src/libarikkei' make[2]: *** [all-recursive] Error 1
$ cvs log src/libarikkei/arikkei-token.c
RCS file: /cvsroot/inkscape/inkscape/src/libarikkei/arikkei-token.c,v Working file: src/libarikkei/arikkei-token.c
revision 1.3 date: 2003/11/11 20:03:20; author: magnethead; state: Exp; lines: +1 -2 Patches to make compile on OSX/Darwin. malloc.h replace with unistd.h and Wl in src/Makefile.am removed at --export-dynamic
Looks like this was introduced due to the OSX/Darwin patch. Hopefully my fix doesn't break that.
Bryce
I've started a page to track the necessary work:
http://www.inkscape.org/cgi-bin/wiki.pl?AutoTooling
Step one is to make sure config.h is included everywhere that it should.
Bryce
On Wed, 12 Nov 2003, Jon A. Cruz wrote:
Bryce Harrington wrote:
Actually the _correct_ solution to this problem is to use autoconf. One day we will know how, and can take care of it then.
I think I might know how to address this.
Has anyone else been looking into it, or should I patch away?
This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
participants (3)
-
Bryce Harrington -
Jon A. Cruz -
T Ingham