Hi,

Those two signals are different. Changed is emitted when the referee changes and reference starts pointing to a different object. The special case is when referee is destroyed. Modified signal is emitted when referee attributes or child elements change. I'll add a comment.

SPItem needs to know when SPPattern references in it's style change, so as to call adequate SPPattern::show and SPPattern::hide methods. It is not possible to use SPItem::modified method, because it is not called immedately, but by an idle handler.

Today and yesterday I have worked on solving bugs related to SPPattern refactoring. I've learned how to read valgrind output. The mentioned changes are result of this bughunt.

Hatch tag support has been added to inkscape. I'm working on hatchPaths and rendering.

Tomasz

On Thu, Jul 31, 2014 at 2:31 PM, Tavmjong Bah <tavmjong@...8...> wrote:

Hi Tomasz,

I just looked at your latest code check-in. You've added in style.h:

sigc::connection fill_ps_changed_connection;
sigc::connection stroke_ps_changed_connection;

to the already existing:

 sigc::connection filter_modified_connection;
 sigc::connection fill_ps_modified_connection;
 sigc::connection stroke_ps_modified_connection;

How does "changed" differ from "modified"? This is a place where adding a comment or two would really be helpful to some future developer in understanding the code.

Any progress with hatches?

Tav