Hi all,
In the Roadmap for 0.37 one of the code-cleanup tasks we identified was to go through the codebase and examine some dead code that has been disabled by putting it into '#if 0' blocks.
It's kind of grunt work, but it really needs to be done. We could put it off for a future release, but it'll still be gruntwork. I figure why not get it out of the way? If we all chip in, it won't be that big of a deal to finish. We'd asked for volunteers earlier but at this point maybe it'll be best to just parcel it out.
I've split the review work up into a dozen sub-tasks so we can divide the work amongst ourselves. I did one section (the 'widgets/' subdir) and found it only took an hour or two to complete.
Could I ask each of the following people to tackle the indicated sections?
johan: *-context.cpp files ted: desktop*.cpp and svg-view.cpp files tvon: sp-gradient.cpp, sp-root.cpp ishmal: file.h, interface.cpp, geom.cpp, inkscape.cpp, and style.cpp pjrm: *-chemistry.cpp and seltrans.cpp bulia: knotholder.cpp, nodepath.cpp, rubberband.cpp, object-edit.cpp, and object-ui.cpp bryce: widgets/, dialogs/ mental: display/ rejon: libnrtype/
This then will leave four remaining areas for whomever gets feeling ambitious, or for anyone that'd like to participate that isn't in the above list:
* bonobo/ * svg/ * helper/ * xml/
To do the work, basically just grep for 'if 0' in your section to find the files, and examine each. If you aren't sure what the code does, ask on Jabber, IRC, or the mailing list. Delete the code unless it seems valuable and worth keeping, in which case please write a detailed comment describing a) what it does, b) why it's worth keeping, and c) what needs to be done to bring it back into the codebase proper.
Thanks, Bryce
On 4 Feb 2004, Johan Ceuppens wrote:
On Mon, 2 Feb 2004 22:20:14 -0800 (PST) Bryce Harrington <bryce@...1...> mused:
johan: *-context.cpp files
The changes are in CVS.
Johan
Thanks Johan!
I've committed the changes for dialogs/
We've got 7 of the 16 sections completed now according to the roadmap.
Bryce
On Tue, 3 Feb 2004, Bryce Harrington wrote:
I've committed the changes for dialogs/
We've got 7 of the 16 sections completed now according to the roadmap.
I went ahead and looked at helper/ too. There's only one if 0 in that section, and it's commented as to what it is and why it's disabled so I'm going to leave it in place.
So, that brings us to 8 of 16. Half way there!
Bryce
participants (2)
-
Bryce Harrington
-
Johan Ceuppens