clang-format vs custom indentation
Hello.
clang-format fails my one line patch and proposes to remove the indentation that was before my change. My opinion that the code will become less readable that it is now. How to deal with that?
--- src/ui/dialog/aboutbox.cpp (before formatting) +++ src/ui/dialog/aboutbox.cpp (after formatting) @@ -86,7 +86,7 @@ set_website ( "https://www.inkscape.org"); set_website_label (_("Inkscape website")); set_license_type (Gtk::LICENSE_GPL_3_0); - set_copyright (_("© 2019 Inkscape Developers")); + set_copyright(_("© 2019 Inkscape Developers")); set_comments (_("Open Source Scalable Vector Graphics Editor\n" "Draw Freely."));
https://gitlab.com/techtonik/inkscape/-/jobs/125913035
Hi Anatoly,
if the custom formatting makes sense you can ignore the clang-format CI job.
It's still in "beta" phase with some formatting suggestions that actually do *not* improve legibility (as you noticed) and some preferences for the formatter probably still need to be tweaked to align it better with our coding style(s).
Regards, Patrick
Am 28.11.2018 um 16:14 schrieb anatoly techtonik:
Hello.
clang-format fails my one line patch and proposes to remove the indentation that was before my change. My opinion that the code will become less readable that it is now. How to deal with that?
--- src/ui/dialog/aboutbox.cpp (before formatting) +++ src/ui/dialog/aboutbox.cpp (after formatting) @@ -86,7 +86,7 @@ set_website ( "https://www.inkscape.org"); set_website_label (_("Inkscape website")); set_license_type (Gtk::LICENSE_GPL_3_0);
- set_copyright (_("© 2019 Inkscape Developers"));
- set_copyright(_("© 2019 Inkscape Developers")); set_comments (_("Open Source Scalable Vector Graphics Editor\n" "Draw Freely."));
participants (2)
-
anatoly techtonik -
Patrick Storz