I added statusbar flash to sp_file_save_document saying "Document saved." However I see no way to find out whether the save was actually successful - of course this needs to be displayed only on success. But sp_module_system_save returns nothing useful. Is this by design? In fact it does have a return with value, even though it is declared as void.
While at it, I added a check of sodipodi:modified so that unchanged document is not saved. I wonder why this was not done before - are there any pending problems with sodipodi:modified? It works nice in my testing so far.
_________________________________________________________________ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus&pgmarket=en-ca&RU=http%3a%2...
On Tue, 2003-12-16 at 01:20, bulia byak wrote:
I added statusbar flash to sp_file_save_document saying "Document saved." However I see no way to find out whether the save was actually successful - of course this needs to be displayed only on success. But sp_module_system_save returns nothing useful. Is this by design? In fact it does have a return with value, even though it is declared as void.
No good reason. I'm thinking about switching this to throw an exception as I convert things to C++... Any comments are welcome.
While at it, I added a check of sodipodi:modified so that unchanged document is not saved. I wonder why this was not done before - are there any pending problems with sodipodi:modified? It works nice in my testing so far.
I've tried to keep this up-to-date in all the modules code. In 0.35 it was pretty broken, I think I've fixed it everywhere for 0.36. If you find anyplace where it isn't working - tell me. It wasn't working for any time of extension save before. I believe currently it is cleared twice on saves that use an internally defined module. But this is another thing I'd like to fix as I'm moving all the code to C++. I'm taking the oppurtunity to 'clean things up' as I go.
--Ted
participants (2)
-
bulia byak -
Ted Gould