Re: [Inkscape-devel] Hackfest build-systems discussion]
Whoops, replied to Bryce instead of to all. Let's try sending it to the list.
On Sun, May 03, 2015 at 03:00:30AM +0100, Ken Moffat wrote:
On Sat, May 02, 2015 at 06:34:57PM -0700, Bryce Harrington wrote:
On Sat, May 02, 2015 at 11:39:34PM +0100, Ken Moffat wrote:
On Tue, Apr 28, 2015 at 08:35:00PM -0700, Bryce Harrington wrote:
On Wed, Apr 29, 2015 at 02:51:15AM +0100, Ken Moffat wrote:
Yes, cmake -L appears to know what it is doing (noted some things I
Building seemed to be going well, until
[ 65%] Building CXX object src/CMakeFiles/inkscape.dir/ui/dialog/text-edit.cpp.o /scratch/ken/bazaar/inkscape/src/ui/dialog/text-edit.cpp:29:32: fatal error: gtkspell/gtkspell.h: No such file or directory compilation terminated.
And when I look back at the cmake output it says: -- checking for module 'gtkspell-2.0' -- package 'gtkspell-2.0' not found
What it's doing at that point is shelling out to pkg-config to see if gtkspell is installed.
pkg-config --cflags --libs gtkspell-2.0
Run ^ that on your commandline and see what it says. If you don't have it installed, install it. :-)
I know I don't have it installed. If it is now required, I assumed cmake would tell me.
At this point, I'm looking at r14094. If you will accept that, for the moment, using ./autogen.sh and configure is still a valid comparison, then gtkspell is optional. With autogen.sh and configure I've managed to build it - no sign of gtkspell (nor the coreldraw, vision, whatever) stuff.
Some hours later, after copious swearing (is that required or does it only seem to help ? ;-), I think I've found where the problem is.
With the following patch, I can cmake, build and DESTDIR install inkscape and the man pages, without any additional -D magic. I will note that inkview did not get installed.
I would have thought that the set line I deleted would have done the right thing, but for me it didn't.
If this is acceptable, do you need a SoB or equivalent ?
ĸen
--- inkscape/CMakeScripts/DefineDependsandFlags.cmake.orig 2015-05-03 22:06:01.598985260 +0100 +++ inkscape/CMakeScripts/DefineDependsandFlags.cmake 2015-05-03 22:08:03.313995015 +0100 @@ -290,8 +290,9 @@ list(APPEND INKSCAPE_INCS_SYS ${GTKSPELL_INCLUDE_DIR}) list(APPEND INKSCAPE_LIBS ${GTKSPELL_LIBRARIES}) add_definitions(${GTKSPELL_DEFINITIONS}) + else() + set(WITH_GTKSPELL OFF) endif() - set(WITH_GTKSPELL ${GTKSPELL_FOUND}) endif()
#find_package(OpenSSL)
ĸen
On 2015-05-04 01:31 (+0200), Ken Moffat wrote:
On Sun, May 03, 2015 at 03:00:30AM +0100, Ken Moffat wrote:
On Sat, May 02, 2015 at 06:34:57PM -0700, Bryce Harrington wrote:
On Sat, May 02, 2015 at 11:39:34PM +0100, Ken Moffat wrote:
On Tue, Apr 28, 2015 at 08:35:00PM -0700, Bryce Harrington wrote:
On Wed, Apr 29, 2015 at 02:51:15AM +0100, Ken Moffat wrote:
Yes, cmake -L appears to know what it is doing (noted some things I
Building seemed to be going well, until
[ 65%] Building CXX object src/CMakeFiles/inkscape.dir/ui/dialog/text-edit.cpp.o /scratch/ken/bazaar/inkscape/src/ui/dialog/text-edit.cpp:29:32: fatal error: gtkspell/gtkspell.h: No such file or directory compilation terminated.
And when I look back at the cmake output it says: -- checking for module 'gtkspell-2.0' -- package 'gtkspell-2.0' not found
What it's doing at that point is shelling out to pkg-config to see if gtkspell is installed.
pkg-config --cflags --libs gtkspell-2.0
Run ^ that on your commandline and see what it says. If you don't have it installed, install it. :-)
I know I don't have it installed. If it is now required, I assumed cmake would tell me.
At this point, I'm looking at r14094. If you will accept that, for the moment, using ./autogen.sh and configure is still a valid comparison, then gtkspell is optional. With autogen.sh and configure I've managed to build it - no sign of gtkspell (nor the coreldraw, vision, whatever) stuff.
Some hours later, after copious swearing (is that required or does it only seem to help ? ;-), I think I've found where the problem is.
With the following patch, I can cmake, build and DESTDIR install inkscape and the man pages, without any additional -D magic. I will note that inkview did not get installed.
I would have thought that the set line I deleted would have done the right thing, but for me it didn't.
If this is acceptable, do you need a SoB or equivalent ?
ĸen
--- inkscape/CMakeScripts/DefineDependsandFlags.cmake.orig 2015-05-03 22:06:01.598985260 +0100 +++ inkscape/CMakeScripts/DefineDependsandFlags.cmake 2015-05-03 22:08:03.313995015 +0100 @@ -290,8 +290,9 @@ list(APPEND INKSCAPE_INCS_SYS ${GTKSPELL_INCLUDE_DIR}) list(APPEND INKSCAPE_LIBS ${GTKSPELL_LIBRARIES}) add_definitions(${GTKSPELL_DEFINITIONS})
- else()
set(WITH_GTKSPELL OFF)
- set(WITH_GTKSPELL ${GTKSPELL_FOUND})
endif()
#find_package(OpenSSL)
Thanks - fix committed in r14103.
Regards, V
participants (2)
-
Ken Moffat -
su_v