Updated patch: Undo History dialog
(sorry for posting the patch here -- logins are currently disabled over at sf.net so I can't put it in the tracker)
As I didn't manage to finish this in time for 0.44 I now release what I have early in the release cycle to make sure it gets thoroughly reviewed/tested before 0.45.
I have made the change suggested by mental (see http://sourceforge.net/tracker/index.php?func=detail&aid=1423034&gro...):
An Event struct has been introduced which stores an XML::Event annotated with a Verb used for grouping and icon, and an ustring for description.
A verb and description is passed with each sp_document_(maybe_)done call. I have tried to put accurate verbs in most of the calls, but at some places I'm not sure what a relevant verb would be. Event descriptions, however, is left to be done. Help with this would be appreciated; there are about 250 descriptions to be written and English is not my mother tongue...
-- Gustav Broberg
On 6/29/06, Gustav Broberg <broberg@...370...> wrote:
A verb and description is passed with each sp_document_(maybe_)done call. I have tried to put accurate verbs in most of the calls, but at some places I'm not sure what a relevant verb would be. Event descriptions, however, is left to be done. Help with this would be appreciated; there are about 250 descriptions to be written and English is not my mother tongue...
That's extremely cool, thanks a lot! Don't worry, we'll fill in the descriptions.
The patch works wonderful. Well, honestly I didn't test it much yet, but I committed it already so it does not bitrot (the patch is huge). Everyone is welcome to play with the new toy :)
Gustav, do you have commit access to SVN? If not let me know and I'll set you up (give me your SF id).
bulia byak wrote:
The patch works wonderful. Well, honestly I didn't test it much yet, but I committed it already so it does not bitrot (the patch is huge). Everyone is welcome to play with the new toy :)
The patch worked well when I manually applied it this morning. But when I reversed the patch on my system and did an svn up, it doesn't seem to compile for either linux or win32 any more (yes I did a clean checkout on both to make sure it wasn't anything left over). Did it not commit everything?
-Josh
It doesn't look like some of the new files were committed; I just updated my copy of trunk and didn't get undo-history.h, for example.
Additionally, some things in undo-stack-observer.h, console-output-undo-observer.h, and composite-undo-stack-observer.{h,cpp} were changed that would cause breakage. I've reverted those changes.
- David
Joshua A. Andler wrote:
bulia byak wrote:
The patch works wonderful. Well, honestly I didn't test it much yet, but I committed it already so it does not bitrot (the patch is huge). Everyone is welcome to play with the new toy :)
The patch worked well when I manually applied it this morning. But when I reversed the patch on my system and did an svn up, it doesn't seem to compile for either linux or win32 any more (yes I did a clean checkout on both to make sure it wasn't anything left over). Did it not commit everything?
-Josh
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&da... _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
On 6/29/06, yipdw <yipdw1@...400...> wrote:
It doesn't look like some of the new files were committed;
Sorry, fixed now.
participants (4)
-
bulia byak -
Gustav Broberg -
Joshua A. Andler -
yipdw