Re: [Inkscape-user] [Inkscape-devel] Re : Inkscape 0.48.3
On 16-2-2012 19:32, Nicolas Dufour wrote:
Hi,
De : Josh Andler<scislac@...155...> Ted and all contributors that made this happen, thank you for all your work! Windows& OSX packagers, please do your magic. :)
I'm not the Windows packager, but wanted to compile and test it on XP. And unfortunately, the current revision doesn't compile correctly and returns the following error:
Make error line 302: problem compiling: src/color-profile.cpp: In static member function 'static std ::vectorGlib::ustring Inkscape::ColorProfile::getBaseProfileDirs()': src/color-profile.cpp:824:5: error: 'cmsUInt32Number' was not declared in this scope src/color-profile.cpp:824:21: error: expected ';' before 'pathSize' src/color-profile.cpp:826:46: error: 'pathSize' was not declared in this scope
IIRC we've already had that kind of issue with the trunk on Windows, and thus I guess backporting the fix would solve the issue.
Oh wow, that is very unfortunate :-( Should be fixed now.
-Johan
I fixed the Windows build in 9884. As you can see in the diff, the SVG flood filter (no clue what it does) was not updated to the latest changes regarding LCMS. This means it broke the Windows build, but I think it also means that the flood filter does not work with LCMS in 0.48.3 on other OSses.
Hope Jon can have a look at it.
Ciao, Johan
On 16-2-2012 20:23, Johan Engelen wrote:
On 16-2-2012 19:32, Nicolas Dufour wrote:
Hi,
De : Josh Andler<scislac@...155...> Ted and all contributors that made this happen, thank you for all your work! Windows& OSX packagers, please do your magic. :)
I'm not the Windows packager, but wanted to compile and test it on XP. And unfortunately, the current revision doesn't compile correctly and returns the following error:
Make error line 302: problem compiling: src/color-profile.cpp: In static member function 'static std ::vectorGlib::ustring Inkscape::ColorProfile::getBaseProfileDirs()': src/color-profile.cpp:824:5: error: 'cmsUInt32Number' was not declared in this scope src/color-profile.cpp:824:21: error: expected ';' before 'pathSize' src/color-profile.cpp:826:46: error: 'pathSize' was not declared in this scope
IIRC we've already had that kind of issue with the trunk on Windows, and thus I guess backporting the fix would solve the issue.
Oh wow, that is very unfortunate :-( Should be fixed now.
-Johan
On Feb 16, 2012, at 1:38 PM, Johan Engelen wrote:
I fixed the Windows build in 9884. As you can see in the diff, the SVG flood filter (no clue what it does) was not updated to the latest changes regarding LCMS. This means it broke the Windows build, but I think it also means that the flood filter does not work with LCMS in 0.48.3 on other OSses.
Hope Jon can have a look at it.
Yup.
Will do.
participants (2)
-
Johan Engelen
-
Jon Cruz