2020-07-26 02-30-38 PDTValentin Ionita <vanntile@protonmail.com>oh, well, that's quite funny for me. That is not part of moving dialogs, it's actually from the xml dialog itself
2020-07-26 02-04-57 PDTValentin Ionita <vanntile@protonmail.com>hey, thank you. I have just pushed recently, you're on the latest?
2020-07-26 02-14-14 PDTValentin Ionita <vanntile@protonmail.com>It will not stay that way, but I am thinking that it looks better than how it was before. And has other small advantages
2020-07-27 01-52-58 PDTValentin Ionita <vanntile@protonmail.com>Will add it now, tho
2020-07-26 02-31-50 PDTValentin Ionita <vanntile@protonmail.com>I don't know what it is, but definitely not from me
2020-07-26 02-58-57 PDTValentin Ionita <vanntile@protonmail.com>I will stick around for bugfixes, tho
2020-07-26 02-57-56 PDTValentin Ionita <vanntile@protonmail.com>yes, but there are lots of things that need fixing or improving
2020-07-26 02-44-25 PDTValentin Ionita <vanntile@protonmail.com>I know, I would like to be able to do all these features, but I work with the Gtk API and I can't actually make them work
2020-07-26 02-07-01 PDTValentin Ionita <vanntile@protonmail.com>I don't even see the menu
2020-08-02 23-37-47 PDTValentin Ionita <vanntile@protonmail.com>Can you show me the minimum size you can now collapse a dialog?
2020-08-12 22-11-58 PDTValentin Ionita <vanntile@protonmail.com>Right now my next step is removing the sidebar you are all talking about
2020-07-26 02-13-23 PDTValentin Ionita <vanntile@protonmail.com>I am trying now to make it theme agnostic
2020-07-31 08-54-14 PDTValentin Ionita <vanntile@protonmail.com>Probably, write on dev. I don't know
2020-08-12 06-46-22 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=6Y4cr224oLTGi6M6E) size increasing automatically is something you need to give up for snapping to 0 size and scrolling. You can only have one ()
2020-07-27 02-45-13 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=LnmHM3yf7facbKjMx) 3) that's literally from the theme used. I know that a lot of themes look like that, but I don't have a theme-agnostic solution yet ()
2020-07-26 02-46-56 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=xgHJNh8K662SzLouZ) this could be a feature. ()
2020-07-26 02-18-42 PDTValentin Ionita <vanntile@protonmail.com>afaik, they shouldn't be resizable under a width
2020-07-26 02-05-30 PDTValentin Ionita <vanntile@protonmail.com>For example: open the layers and objects panels
2020-08-12 09-35-40 PDTValentin Ionita <vanntile@protonmail.com>... this was obviously not something that is documented.
2020-07-26 02-55-54 PDTValentin Ionita <vanntile@protonmail.com>I already reimpllemented Gtk::Paned completely, and Gtk::Expander partially
2020-08-12 07-24-49 PDTValentin Ionita <vanntile@protonmail.com>no, it doesn't. that's what I'm saying
2020-08-02 23-32-26 PDTValentin Ionita <vanntile@protonmail.com>ok, thank you, I couldn't figure it out. Windows
2020-08-02 23-28-38 PDTValentin Ionita <vanntile@protonmail.com>2. is actually bug 2 3. is actually not implemented. It's feature 3, I guess
2020-07-26 02-18-21 PDTValentin Ionita <vanntile@protonmail.com>can you make a ss for me?
2020-08-13 02-14-50 PDTValentin Ionita <vanntile@protonmail.com>PS, I rebased.
2020-07-26 10-04-58 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=NkFjCJTXTGRcihL2Y) This can't be solved, at least like you said. Interacting with a window in any way connects the dialogs to it. I have other ideas, but unless I get a code review on desktop and window management, I won't focus on it at all. ()
2020-08-12 07-23-42 PDTValentin Ionita <vanntile@protonmail.com>You must understand that I have made a number of compromises until here, guided by the group. If I need to change something majorly now, even if I will do it or not, I will not be pleased about it
2020-08-13 02-33-14 PDTValentin Ionita <vanntile@protonmail.com>I have had my own problems trying to apply a similar pattern in other cases. I'm not sure if I can do it, somebody else will. I'll backlog it for now
2020-08-12 06-50-43 PDTValentin Ionita <vanntile@protonmail.com>a recording would help me understand
2020-04-05 09-21-36 PDTValentin Ionita <vanntile@protonmail.com>No need for you to worry right now.
2020-08-02 23-38-10 PDTValentin Ionita <vanntile@protonmail.com>I want to check if I can cross bugs 22 and 23
2020-07-26 02-23-36 PDTValentin Ionita <vanntile@protonmail.com>Thank you for your feedback.
2020-08-02 22-28-55 PDTValentin Ionita <vanntile@protonmail.com>And your help. Especially your help
2020-07-26 03-27-38 PDTValentin Ionita <vanntile@protonmail.com>I honestly don't know. What is an instance, for you? If it's one time running Inkscape, what if I want two Inkscape windows and each with its own fill&stroke
2020-07-26 02-24-53 PDTValentin Ionita <vanntile@protonmail.com>But you can resize it, right?
2020-08-13 02-26-25 PDTValentin Ionita <vanntile@protonmail.com>I am sure it will. It's a compromise...
2020-07-26 03-04-40 PDTValentin Ionita <vanntile@protonmail.com>totally functional independent window, right? :laughing:
2020-07-26 10-10-52 PDTValentin Ionita <vanntile@protonmail.com>Thanks, you're so forward thinking
2020-08-12 06-45-42 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=br7PYKFTuHbfnuAAK) I know of it, not necessarily my fault. It's just a bit of how Tav's and my code interact. Not critical ()
2020-07-26 02-23-26 PDTValentin Ionita <vanntile@protonmail.com>yep. Will give it a thought.
2020-07-27 01-56-31 PDTValentin Ionita <vanntile@protonmail.com>Actually my initial plan/timeline included "polishing" week/weeks
2020-08-02 22-28-45 PDTValentin Ionita <vanntile@protonmail.com>I appreciate your message
2020-07-26 02-52-03 PDTValentin Ionita <vanntile@protonmail.com>yes, I think it is. However, using debug windows (in ubuntu), I can see that there is a way of keeping them in front. I wonder what that is ...
2020-08-13 02-21-31 PDTValentin Ionita <vanntile@protonmail.com>With that I agree completely.
2020-04-05 09-20-42 PDTValentin Ionita <vanntile@protonmail.com>Currently, when I don't format the pattern file properly, on my end it crashes formidably. But I'll take my time testing. Thank you for the heads up
2020-07-27 02-54-00 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=nQCCnGmPSptCtz7Tu) If I did, i am unaware of it. I really don't think so. ()
2020-07-26 02-26-13 PDTValentin Ionita <vanntile@protonmail.com>yep
2020-07-26 02-58-30 PDTValentin Ionita <vanntile@protonmail.com>That's a good thing. I'm glad
2020-08-12 07-22-52 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=P4vuKgaG2GzZ6oYg7) please write this on the dev channel ()
2020-08-12 09-20-17 PDTValentin Ionita <vanntile@protonmail.com>Related to your question about popping a dialog by dragging the tab, the lines that interest you are in the following function (and potentially the one above it, tho I doubt it) https://gitlab.com/vanntile/inkscape/-/blob/docking-system-copy/src/ui/dialog/dialog-notebook.cpp#L319
2020-04-05 09-24-03 PDTValentin Ionita <vanntile@protonmail.com>Oh, well, our issues are migrated to gitlab, but I will find the according request
2020-04-05 09-27-20 PDTValentin Ionita <vanntile@protonmail.com>No it couldn't as far as I know. The paint server is not loaded :(
2020-07-27 00-52-19 PDTValentin Ionita <vanntile@protonmail.com>Right now I'm working on a fix for scrolling when a dialog notebook is collapsed
2020-07-26 02-31-59 PDTValentin Ionita <vanntile@protonmail.com>I guess you can drag objects there????
2020-07-27 01-48-32 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=Ewyk4P53BuosvmjCb) Wow, this is so unexpected. I will add to the list of known issues, because I have no idea why it's happening. ()
2020-07-26 02-54-26 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=ttcBgb2eL43nQyiqa) not possible, believe me. I would need to reimplement the whole notebook widget from scratch ()
2020-07-26 02-48-47 PDTValentin Ionita <vanntile@protonmail.com>And I don't think I will
2020-07-26 02-54-31 PDTValentin Ionita <vanntile@protonmail.com>And i just don't know how
2020-07-26 02-43-21 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=FdfJzMysT3zuXoC74) This works on Wayland, and not on X11. Know we know it doesn't work on Windows ()
2020-08-13 02-19-27 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=TrYP4abYC7Pi33Wdb) right now, no. I will give links to the ux team for testing as soon as the windows pipeline finishes ()
2020-07-26 06-30-28 PDTValentin Ionita <vanntile@protonmail.com>Hello, again. Don't want to abuse your time, just wanted to let you know I have already fixed a few things (look at the list here: https://gitlab.com/vanntile/inkscape-gsoc-2020/-/blob/master/TODO.md)
2020-08-02 23-21-18 PDTValentin Ionita <vanntile@protonmail.com>Look, they are not "collapsing" anymore. It's just that you can resize them
2020-04-05 09-56-46 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=fkE6Gm8QKELCKcztx) I will certainly add it to my list of functionalities to be implemented. Right now it's just a private backlog ()
2020-04-05 09-22-04 PDTValentin Ionita <vanntile@protonmail.com>Yes, I will try to document the small number of features it has.
2020-07-26 02-47-00 PDTValentin Ionita <vanntile@protonmail.com>these things compound
2020-07-26 02-59-01 PDTValentin Ionita <vanntile@protonmail.com>Occasionally
2020-08-13 01-24-27 PDTValentin Ionita <vanntile@protonmail.com>try my latest commit. I did a patch hoping it will fix your problem
2020-04-05 09-55-03 PDTValentin Ionita <vanntile@protonmail.com>So problem solved on your end? I really don't know how your version didn't crash. I had an operation which was dependent on the title tag
2020-07-26 02-05-18 PDTValentin Ionita <vanntile@protonmail.com>if so, you could try to focus on trying expanding and minimizing dialogs.
2020-07-26 02-25-40 PDTValentin Ionita <vanntile@protonmail.com>That's a size allocation algorithm written by me running in the background. I build it on previous specs, which are not totally user-friendly. I will deffer this task until I fix other bugs
2020-04-05 09-51-05 PDTValentin Ionita <vanntile@protonmail.com>Ok, so I have tested a bit and now I am ready for a round of questions and answers. But first, let me tell you how it works on my end. The .svg file you provided makes my Inkscape crash when I put it into the paint folder. However, if I add a *title* tag, it runs and add a new page to the paint servers dialog with the title used. Now, what are you precisely doing?
2020-08-02 23-22-15 PDTValentin Ionita <vanntile@protonmail.com>Now we are a bit biased, because we have experienced "collapsing". But for someone who can only resize the notebooks, it shouldn't be that obtrusive that there is scrolling
2020-07-26 02-22-50 PDTValentin Ionita <vanntile@protonmail.com>I will try to do something, but that thing in blender is quite complex (Sorry, I don't feel as powerful with Gtk as I feel with web technologies)
2020-07-27 02-47-11 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=pKBbhWdEKkmd5jbX5) I really don't understand how the things work. I will ask at the next gsoc meeting ()
2020-07-26 03-03-01 PDTValentin Ionita <vanntile@protonmail.com>Well, it make sense. I have never tried using them.
2020-08-12 11-38-51 PDTValentin Ionita <vanntile@protonmail.com>Nevermind, I haven't seen this link you sent me when I wrote that
2020-07-26 02-05-45 PDTValentin Ionita <vanntile@protonmail.com>and the reconfigure, and use the arrow to make them smaller and larger
2020-08-13 02-22-12 PDTValentin Ionita <vanntile@protonmail.com>It is not my best work (from "what you can see"), because I was restricted and hit in the guts so many times by Gtk, but i tried to make it my best work from the code point of view.
2020-07-26 02-58-44 PDTValentin Ionita <vanntile@protonmail.com>4-5 weeks
2020-07-27 02-51-05 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=2ZGP4uzjpsJd8iZGX) Oh, I guess it receives the keyboard events. Obviously. I'll have to ask how to send them to the main window or ... ()
2020-08-02 23-31-08 PDTValentin Ionita <vanntile@protonmail.com>oh, cool
2020-07-27 02-47-46 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=25PiwtqSHyGrxvXka) No idea, but will add it to the list ()
2020-07-26 02-07-07 PDTValentin Ionita <vanntile@protonmail.com>Is that even possible?
2020-08-12 06-49-22 PDTValentin Ionita <vanntile@protonmail.com>I see it's a cross-platform bug, now that I am aware of it, will check it
2020-07-27 02-43-27 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=LnmHM3yf7facbKjMx) 1) and it won't be for a while. It needs to stay a stable feature. The strings are already tagged for translation, afaik ()
2020-08-13 00-22-49 PDTValentin Ionita <vanntile@protonmail.com>Put it on public. I'll comment there
2020-07-26 02-08-27 PDTValentin Ionita <vanntile@protonmail.com>oh, wow
2020-07-26 02-18-47 PDTValentin Ionita <vanntile@protonmail.com>it might be a bug
2020-07-26 03-13-43 PDTValentin Ionita <vanntile@protonmail.com>how did you reproduce that. I couldn't find a pattern for it. I did it twice
2020-07-27 01-39-09 PDTValentin Ionita <vanntile@protonmail.com>Can I abuse you a bit and ask you to test right now? I have fixed three things and I think you're gonna like them: 1. a collapsed dialog notebook doesn't scroll anymore 2. a floating dialog stays above the Inkscape window (works on X11) 3. Dialog notebooks are scrollable horizontally and they can be snapped until the edge, so you get the most out of your space
2020-04-05 09-57-22 PDTValentin Ionita <vanntile@protonmail.com>It's still an incomplete feature. However, even incomplete, I see how it could be useful to people
2020-07-27 00-52-35 PDTValentin Ionita <vanntile@protonmail.com>It works, but it still has an animation, somehow
2020-07-26 03-40-04 PDTValentin Ionita <vanntile@protonmail.com>Removing the signals would be ideal (I did it in a couple of them). As an example, there is the Prototype Dialog.
2020-07-27 01-51-50 PDTValentin Ionita <vanntile@protonmail.com>wait, do you mean it doesn't expand for you when it's collapsed and clicking a tab?
2020-07-26 02-08-13 PDTValentin Ionita <vanntile@protonmail.com>Honestly, I just don't think it compiled right
2020-07-26 02-13-42 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=GSMwo5zFjRkve4Fkj) right now, yes, because I don't know how to remove that behavior. Yet ()
2020-07-26 03-07-35 PDTValentin Ionita <vanntile@protonmail.com>Can you record it?
2020-07-26 03-17-27 PDTValentin Ionita <vanntile@protonmail.com>whaaaat? strange
2020-08-02 23-20-41 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=nCagaPrzQCk5vSzih) you're right ()
2020-04-05 09-56-16 PDTValentin Ionita <vanntile@protonmail.com>I will take my time in the next couple of days to do that.
2020-07-26 02-52-25 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=CFAJ3dtvZgjtPzyRC) well, scrolling would clash with this. definitely ()
2020-08-13 03-37-18 PDTValentin Ionita <vanntile@protonmail.com>And thank you a lot for the thorough testing until now.
2020-07-26 06-30-58 PDTValentin Ionita <vanntile@protonmail.com>The code is on my latest pipeline, as always. https://gitlab.com/vanntile/inkscape/-/pipelines/170877664
2020-07-26 03-39-30 PDTValentin Ionita <vanntile@protonmail.com>The whole purpose of this way of writing dialogs I have done is not having signale that track the desktop at all. Because all dialogs get updated (a callback) whenever the document changes, the active window changes or the selection changes.
2020-08-02 23-39-09 PDTValentin Ionita <vanntile@protonmail.com>They look sensible, I think I can cross them
2020-07-26 02-32-07 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=fqga8mcLx6vwhfXDw) me neither ()
2020-08-12 22-08-14 PDTValentin Ionita <vanntile@protonmail.com>Hey, I am fixing the bugs from last night. I have already fixed the first two and now I'm trying to understand what you did with the windows things to make it work... partially
2020-07-27 01-54-47 PDTValentin Ionita <vanntile@protonmail.com>thanks, I was stressed out by what you said and it motivated me
2020-07-26 03-05-16 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=yWFXvy5P6A9hxjaGe) this seems normal to me ()
2020-07-27 02-55-32 PDTValentin Ionita <vanntile@protonmail.com>Because I only tried to make them like that when collapsed
2020-08-02 22-28-27 PDTValentin Ionita <vanntile@protonmail.com>I just want to make things work. I am sad when I am unable to.
2020-07-27 00-08-40 PDTValentin Ionita <vanntile@protonmail.com>Taking your feedback from yesterday into consideration I worked all morning and fixed how closing InkscapeWindows works. Now, if you have floating dialogs and multiple Inkscape windows, if the floating dialogs are attached to the windows you are trying to close, they will focus on another InkscapeWindow, if it exist. If there is only one, then they will close also. I think this is the best state of the micro-feature, I don't plan on changing it again.
2020-07-26 02-43-50 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=t8p7xjK62JhYDdFxr) same kind of argument as above ()
2020-08-02 23-20-15 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=mc25kbm5rNR4RnTDE) God, it's so annoying. It doesn't always happen to jump down and when I am doing changes and test, it doesn't immediately show and I think I solved it.... ()
2020-07-27 02-45-43 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=662TtwDhQpN4AQ6Z9) That is a mistake that I will have to correct. Thanks, will add it to the list ()
2020-08-13 02-18-53 PDTValentin Ionita <vanntile@protonmail.com>save god
2020-07-26 03-41-38 PDTValentin Ionita <vanntile@protonmail.com>Also, removing signals would help the app itself.
2020-08-02 22-27-24 PDTValentin Ionita <vanntile@protonmail.com>Thank you so much :pray:
2020-07-27 01-53-20 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=aHKYfDLeCnJPnBcL9) oh, got it, will try to find out a way to fix it ()
2020-07-26 02-06-09 PDTValentin Ionita <vanntile@protonmail.com>(It worked perfectly on my theme, but I guess I need to make them independent)
2020-07-26 10-06-31 PDTValentin Ionita <vanntile@protonmail.com>Sure, will have a list of those, then
2020-07-27 01-56-05 PDTValentin Ionita <vanntile@protonmail.com>I like to work fast :)
2020-07-26 10-07-30 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=T9TWNFdXejmbsfapr) Definitely from Tav (as he has been the main driver since the beginning. We worked together last year also, so we're familiar with each other). For the others, more recently I had enough help. At the beginning, not so much ()
2020-08-12 06-51-09 PDTValentin Ionita <vanntile@protonmail.com>These two bugs
2020-08-12 07-29-07 PDTValentin Ionita <vanntile@protonmail.com>This is so close to me being finished with it, and if there are major problems, talk aloud and stop the merge.
2020-07-27 02-44-16 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=LnmHM3yf7facbKjMx) 2) just like in the menu, I haven't done a mistake, just that I want to keep things uniform. If many people complain, I'll ask for a solution ()
2020-08-13 02-18-55 PDTValentin Ionita <vanntile@protonmail.com>at last
2020-07-27 01-52-06 PDTValentin Ionita <vanntile@protonmail.com>for the moment
2020-04-05 09-19-14 PDTValentin Ionita <vanntile@protonmail.com>thanks :smile:
2020-07-26 02-14-32 PDTValentin Ionita <vanntile@protonmail.com>ok, this I didn't know. will note down
2020-08-12 06-50-59 PDTValentin Ionita <vanntile@protonmail.com>Also, could you please mention the bugs on the dev channel?
2020-07-26 03-38-28 PDTValentin Ionita <vanntile@protonmail.com>I actually haven't customised every dialog to work with the new DialogBase. I only barely changed some of them, for them to work as they were before.
2020-08-02 22-29-34 PDTValentin Ionita <vanntile@protonmail.com>Actually, right now I have an idea of how to fix an UX bug. gonna get to work. will read your feedback in a couple of hours
2020-07-26 03-05-08 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=wPCWmkDcaaLLMoTeb) this is problematic ()
2020-08-13 00-18-29 PDTValentin Ionita <vanntile@protonmail.com>Yeah, I had a logic mistake. It still has some header rendering issues, but I am definite that those are above my possibilites
2020-04-05 09-54-06 PDTValentin Ionita <vanntile@protonmail.com>you're on the latest build of Inkscape, aren't you? Can you tell me what Help > About Inkscape says?
2020-08-12 09-36-26 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=ND2fbJdk2QiusLFCb) None that I could think of. I would have chosen a single signal instead of two, if there was an alternative ()
2020-08-13 02-18-28 PDTValentin Ionita <vanntile@protonmail.com>That's the date of the creation of the first commit form the squashed commits
2020-08-12 06-47-58 PDTValentin Ionita <vanntile@protonmail.com>thanks
2020-08-13 02-20-07 PDTValentin Ionita <vanntile@protonmail.com>THANK you
2020-07-26 02-19-45 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=6xynWWHPkeCGK3XgD) I know, I did too ()
2020-07-26 02-13-01 PDTValentin Ionita <vanntile@protonmail.com>yes, I know, I haven't considered that different themes have different heights :cold_sweat:
2020-07-26 02-08-34 PDTValentin Ionita <vanntile@protonmail.com>That's going to be a problem
2020-08-12 06-46-46 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=c7uS9uxsu9pfhvyJk) This sounds like an issue, can you show me? ()
2020-04-05 09-58-24 PDTValentin Ionita <vanntile@protonmail.com>Ok, thank you for the feedback, have a great evening/night/day
2020-08-13 03-37-33 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=tkASpikw9y8trirJG) I'm always on my laptop 😅 ()
2020-07-26 02-31-15 PDTValentin Ionita <vanntile@protonmail.com>you are trying to put a dialog in itself. and it doesn't work. as it should
2020-07-26 02-06-51 PDTValentin Ionita <vanntile@protonmail.com>from the menu. I have no clue why it looks like that on your machine
2020-07-26 03-42-31 PDTValentin Ionita <vanntile@protonmail.com>And my way of writing things has simplified a lot of things, and when the actions would be ready to replace verbs, it would be fairly easy to replace them. (Right now, I can't use actions for the dialogs, I still need verbs)
2020-08-13 01-38-10 PDTValentin Ionita <vanntile@protonmail.com>could you show me? I just can't reproduce it on my machine
2020-07-27 00-51-56 PDTValentin Ionita <vanntile@protonmail.com>Great
2020-08-12 06-45-13 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=wZa5Sf7RBsDb9Y3Xs) this is totally from Gtk, it's so unreliable. I have a solution for X11, one for Wayland, and apparently Windows would need that too. But I am unable to code that, for obvious reasons. ()
2020-07-26 02-48-18 PDTValentin Ionita <vanntile@protonmail.com>No, just this rotated, for now
2020-07-27 01-52-54 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=W6SpHwqghScbp5Fji) don't even know how to call it :cold_sweat: ()
2020-07-26 02-05-53 PDTValentin Ionita <vanntile@protonmail.com>I already know of some bugs myself
2020-07-26 02-08-22 PDTValentin Ionita <vanntile@protonmail.com>units is still on the repo
2020-07-26 02-50-04 PDTValentin Ionita <vanntile@protonmail.com>I thought of that, but the initial specs were different. So I kept it like this for now
2020-08-13 02-18-05 PDTValentin Ionita <vanntile@protonmail.com>It's a result of how squash rebasses work. Believe me, it's a good one
2020-07-27 01-48-51 PDTValentin Ionita <vanntile@protonmail.com>Also, the scrollbar shouldn't appear but you should be able to scroll if it's under it's minimum size
2020-08-02 22-26-52 PDTValentin Ionita <vanntile@protonmail.com>Hello, I have made some major modifications to the dialogs. When you have time, can you check if the following bugs (from my TODO list) are still active or finished? - Bug 16 - Bug 17 - Bug 20 - Bug 22 - Bug 23 I have removed "collapsing/expanding" a dialog, so the following bugs shouldn't be "realistic" anymore: - Bug 4 - Bug 5 - Bug 8 - Bug 19
2020-07-27 01-54-13 PDTValentin Ionita <vanntile@protonmail.com>Yeah, you're right, just wondering how to unselect tabs :shrug:
2020-07-26 02-08-47 PDTValentin Ionita <vanntile@protonmail.com>I'll note it down. this is helpful, thank you
2020-08-13 03-37-07 PDTValentin Ionita <vanntile@protonmail.com>No worries. Relax.
2020-07-26 02-15-59 PDTValentin Ionita <vanntile@protonmail.com>Thank you. I am glad
2020-07-26 10-10-31 PDTValentin Ionita <vanntile@protonmail.com>😅
2020-08-12 09-36-03 PDTValentin Ionita <vanntile@protonmail.com>I am not an expert in gtk, I don't know if anyone know anything about this
2020-07-27 01-49-42 PDTValentin Ionita <vanntile@protonmail.com>I haven't tested those and I don't know how they connect to events or even if I have control over it
2020-07-26 02-16-21 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=YgYLnBYn4XaKKx3EJ) This came up with Tav's original mock, and I kept it around :smile: ()
2020-07-27 01-52-03 PDTValentin Ionita <vanntile@protonmail.com>I'll add that as a windows bug
2020-08-12 07-28-27 PDTValentin Ionita <vanntile@protonmail.com>Could you please write this all on the public channel?
2020-04-05 09-55-35 PDTValentin Ionita <vanntile@protonmail.com>That sounds great. That means that documentation is needed
2020-07-26 03-09-38 PDTValentin Ionita <vanntile@protonmail.com>Ok, will wait until later and then note everything you said
2020-07-26 10-03-16 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=QpnynfP934iFj7T3m) If you will think for it for a while you will realise there is not actual solution to this ()
2020-08-12 22-11-11 PDTValentin Ionita <vanntile@protonmail.com>well, I need to check if there is any crash on wayland currently first
2020-08-13 02-14-39 PDTValentin Ionita <vanntile@protonmail.com>I hate to be so annoying, but whenever you can, a new commit is available.
2020-07-26 02-19-36 PDTValentin Ionita <vanntile@protonmail.com>I am advancing slowly and brewing similar ideas in my head
2020-07-26 03-01-51 PDTValentin Ionita <vanntile@protonmail.com>No, in the demo I have implemented saving, but I haven't had the chance integrating it yet.
2020-07-27 02-55-05 PDTValentin Ionita <vanntile@protonmail.com>[ ](https://chat.inkscape.org/direct/jhofinger?msg=97mq5nvHY2mng3PtG) I didn't actually realize you can make a DialogNotebook with height 0. Will change that ()
2020-07-26 02-40-51 PDTjhofinger <jonathan.hofinger@gmx.de>When there are so many dialogs in a notebook that their title buttons define the notebook's min width, maybe collapse the titles automatically
2020-07-26 02-47-44 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - July 26, 2020 11:47 AM (https://chat.inkscape.org/file-upload/GxiohGZoRdeTnHuNe/Clipboard%20-%20July%2026,%202020%2011:47%20AM)
2020-07-26 02-55-23 PDTjhofinger <jonathan.hofinger@gmx.de>oh :/
2020-07-26 03-02-24 PDTjhofinger <jonathan.hofinger@gmx.de>(currently, that leads to crashes when you do anything in the remaining dialogs)
2020-04-05 09-58-36 PDTjhofinger <jonathan.hofinger@gmx.de>Have a good day!
2020-07-26 02-12-13 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - July 26, 2020 11:12 AM (https://chat.inkscape.org/file-upload/KkgooJthKv2C2LaeR/Clipboard%20-%20July%2026,%202020%2011:12%20AM)
2020-07-26 02-05-25 PDTjhofinger <jonathan.hofinger@gmx.de>yeah
2020-08-13 01-29-41 PDTjhofinger <jonathan.hofinger@gmx.de>on main window close2.txt (https://chat.inkscape.org/file-upload/JpD5rtcNm4YoT6kc3/on%20main%20window%20close2.txt)
2020-08-02 22-27-15 PDTjhofinger <jonathan.hofinger@gmx.de>Cool, will test!
2020-07-26 03-09-40 PDTjhofinger <jonathan.hofinger@gmx.de>For the layers dialog (something is wrong with that one), undocking it into a new window gives the window the subtitle "Dialog Window" instead of "Document 1" as for the other dialogs
2020-04-05 09-54-16 PDTjhofinger <jonathan.hofinger@gmx.de>1.1-dev (6b4d57f, 2020-04-01)
2020-08-02 23-39-23 PDTjhofinger <jonathan.hofinger@gmx.de>:thumbup:
2020-07-26 02-15-44 PDTjhofinger <jonathan.hofinger@gmx.de>also that if you open a dialog again it is highlighted
2020-07-26 03-01-50 PDTjhofinger <jonathan.hofinger@gmx.de>oh, when you close the main window, dependent dialogs should definitely close
2020-08-12 06-50-24 PDTjhofinger <jonathan.hofinger@gmx.de>if you can't reproduce, I'll record a bt
2020-07-26 03-32-49 PDTjhofinger <jonathan.hofinger@gmx.de>do you disconnect the signals when a dialog is closed or hidden? there are some dialogs which cause slowdowns or crashes even without interaction
2020-07-26 02-21-45 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/ss2f1z4ncrwxqu9/2020-07-26%2011-20-32.mkv?dl=0 this is how blender does it
2020-07-27 01-52-51 PDTjhofinger <jonathan.hofinger@gmx.de>[ ](https://chat.inkscape.org/direct/vanntile?msg=wExsQFHSZrztEbo46) it does, but only if you click the tab that is not currently selected. ()
2020-08-02 23-30-45 PDTjhofinger <jonathan.hofinger@gmx.de>Anyway bug 7 seems to be fixed
2020-07-26 03-26-41 PDTjhofinger <jonathan.hofinger@gmx.de>I think having a dialog opened twice in the same instance is probably an invitation for a lot of bugs
2020-04-05 09-22-45 PDTjhofinger <jonathan.hofinger@gmx.de>When you're done, feel free to mark this LP request: https://bugs.launchpad.net/inkscape/+bug/183535 as fix committed :)
2020-08-12 06-44-17 PDTjhofinger <jonathan.hofinger@gmx.de>- I get a console message SPDesktop::getInkscapeWindow: Failed to get window. everytime i close inkscape
2020-08-12 06-46-11 PDTjhofinger <jonathan.hofinger@gmx.de>If you have two dialogs next to each other in an undocked window, dragging the right one below the left one closes the window
2020-07-26 03-20-57 PDTjhofinger <jonathan.hofinger@gmx.de>this was a different way of replication
2020-08-12 22-09-37 PDTjhofinger <jonathan.hofinger@gmx.de>As I said, it's not documented anywhere.
2020-07-26 03-07-04 PDTjhofinger <jonathan.hofinger@gmx.de>Oh this is strange: I just reopened Inkscape and tried to open a dialog again: the text disappeared but nothing else happened. Then I minimized the window and maximized it again, and the dialog was there
2020-07-27 00-19-29 PDTjhofinger <jonathan.hofinger@gmx.de>That sounds perfect. Will test 😊
2020-07-26 03-13-26 PDTjhofinger <jonathan.hofinger@gmx.de>oh wow, that's weird
2020-08-12 10-39-48 PDTjhofinger <jonathan.hofinger@gmx.de>It works on Windows using the wayland code and setting GDK_WIN32_USE_EXPERIMENTAL_OLE2_DND=1
2020-07-26 02-37-22 PDTjhofinger <jonathan.hofinger@gmx.de>When opening new dialogs either from the menu or by keyboard, it should not be placed in a collapsed notebook
2020-08-12 07-22-20 PDTjhofinger <jonathan.hofinger@gmx.de>Also, please save the size of dialogs on close, so I don't have to resize them the next time I open Inkscape
2020-07-26 02-48-40 PDTjhofinger <jonathan.hofinger@gmx.de>okay :) I doubt a lot of people would miss it tbh :D
2020-04-05 09-55-09 PDTjhofinger <jonathan.hofinger@gmx.de>Now I have a new list entry named "test" and I can add patterns
2020-04-05 09-56-05 PDTjhofinger <jonathan.hofinger@gmx.de>Yes. But if the user doesn't provide a title, could the filename be used instead?
2020-07-26 02-31-45 PDTjhofinger <jonathan.hofinger@gmx.de>turns out you can type in this area. haven't seen that before
2020-07-27 01-51-29 PDTjhofinger <jonathan.hofinger@gmx.de>2 works perfectly, also with multiple windows
2020-07-26 02-06-12 PDTjhofinger <jonathan.hofinger@gmx.de>I'm not sure how to open dialogs :D
2020-08-02 23-21-28 PDTjhofinger <jonathan.hofinger@gmx.de>Yes I know
2020-04-05 09-24-26 PDTjhofinger <jonathan.hofinger@gmx.de>(that's how I found the bug, I did some migration work)
2020-07-26 02-52-50 PDTjhofinger <jonathan.hofinger@gmx.de>(floating dialogs in Windows)
2020-07-26 03-13-29 PDTjhofinger <jonathan.hofinger@gmx.de>they are all fully functional
2020-07-26 03-17-00 PDTjhofinger <jonathan.hofinger@gmx.de>it's related to opening the path effect editor
2020-07-26 02-25-05 PDTjhofinger <jonathan.hofinger@gmx.de>yes
2020-08-02 23-30-29 PDTjhofinger <jonathan.hofinger@gmx.de>I understood bug 2 differently
2020-07-27 01-56-15 PDTjhofinger <jonathan.hofinger@gmx.de>that's great :)
2020-08-12 09-20-43 PDTjhofinger <jonathan.hofinger@gmx.de>ah thanks :) I will try to poke it later
2020-08-13 01-29-46 PDTjhofinger <jonathan.hofinger@gmx.de>still crashes, but bt looks different
2020-04-05 09-54-09 PDTjhofinger <jonathan.hofinger@gmx.de>Ah it needs to be an entire tag. now it works
2020-08-02 23-17-42 PDTjhofinger <jonathan.hofinger@gmx.de>20: I can still resize a dialog notebook to "collapsed" size. It still happens and is confusing I think (especially if the dialog that is scrolled into view has tabs as well, such as F&S, so the user wonders where the tabs are gone to)
2020-08-12 11-12-47 PDTjhofinger <jonathan.hofinger@gmx.de>what do you mean by "an issue on your branch"?
2020-07-26 02-32-54 PDTjhofinger <jonathan.hofinger@gmx.de>yeah, definitely not a part of 1.0. Anyway, none of your concern for now
2020-08-02 23-19-29 PDTjhofinger <jonathan.hofinger@gmx.de>4 is probably a duplicate of 20, or am I missing some nuance?
2020-08-13 02-33-26 PDTjhofinger <jonathan.hofinger@gmx.de>Okay.
2020-07-26 02-19-11 PDTjhofinger <jonathan.hofinger@gmx.de>no, currently they don't but it could be a good idea
2020-07-27 02-20-49 PDTjhofinger <jonathan.hofinger@gmx.de>Did you change anything inside the copy/paste code? I've noticed multiple times already that sometimes the clipboard doesn't work at all (i.e. i can't copy files inside file explorer or screenshots to clipboard). It works again when I close Inkscape. I haven't found out yet what triggers it
2020-08-02 23-26-25 PDTjhofinger <jonathan.hofinger@gmx.de>Just some things I noticed while testing: - if you have a big and a small dialog with some elements aligned to bottom at the top (such as Document properties and XML editor) and another notebook below you have to resize the top notebook to an unreasonable size to see the bottom-floating elements of the dialog. This is confusing to users and hard to explain (why should a dialog which isn't even active influence this at all?) - When you pop out a floating dialog, it should have its minimum size without scrollbars - When you close a floating dialog and reopen it, it should still be floating (that's how 1.0 behaves at least)
2020-08-02 22-28-42 PDTjhofinger <jonathan.hofinger@gmx.de>I know that feeling.
2020-08-13 00-16-50 PDTjhofinger <jonathan.hofinger@gmx.de>rendering when dragging from collapsed to non-collapsed is a lot better
2020-07-26 03-18-43 PDTjhofinger <jonathan.hofinger@gmx.de>and I think it requires two documents to be open
2020-07-27 02-46-39 PDTjhofinger <jonathan.hofinger@gmx.de>[ ](https://chat.inkscape.org/direct/vanntile?msg=GCs5m39J2HfEumTSi) I think we follow the GNOME HIG, https://developer.gnome.org/hig/stable/writing-style.html defines where an ellipsis can be. I think it wasn't there in the old docking system. Probably, as soon as the ellipsis is gone, the translation subsystem picks up the name and translates it ()
2020-08-12 10-44-25 PDTjhofinger <jonathan.hofinger@gmx.de>https://gitlab.gnome.org/GNOME/gtk/-/issues/82 took the idea from here
2020-04-05 09-19-10 PDTjhofinger <jonathan.hofinger@gmx.de>pattern.svg (https://chat.inkscape.org/file-upload/LpYnsHrd7cJApTkr9/pattern.svg)
2020-07-26 10-09-19 PDTjhofinger <jonathan.hofinger@gmx.de>good to know :)
2020-07-26 03-01-24 PDTjhofinger <jonathan.hofinger@gmx.de>I think it mainly needs polishing, basic functionality looks fine. Is the dialog arrangement already stored?
2020-07-27 01-49-12 PDTjhofinger <jonathan.hofinger@gmx.de>How so, Ctrl+Scroll/Alt+Scroll?
2020-08-13 01-40-49 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/2xh7u9t4qh8awga/2020-08-13%2010-39-51.mkv?dl=0
2020-08-12 11-13-03 PDTjhofinger <jonathan.hofinger@gmx.de>am confused
2020-08-13 02-27-19 PDTjhofinger <jonathan.hofinger@gmx.de>I'm sorry, I just noticed I uploaded the wrong bt earlier
2020-08-02 23-21-00 PDTjhofinger <jonathan.hofinger@gmx.de>I think it's reasonable to remove collapsing.
2020-07-27 02-21-31 PDTjhofinger <jonathan.hofinger@gmx.de>I haven't noticed that on master, personally
2020-07-26 02-38-02 PDTjhofinger <jonathan.hofinger@gmx.de>Collapsed notebooks should not have a selected tab; and if the user clicks on one, the notebook should automatically expand
2020-07-26 02-43-20 PDTjhofinger <jonathan.hofinger@gmx.de>also, if you drag a dialog out of the docking area it would be great if it automatically spawns a new window
2020-04-05 09-26-09 PDTjhofinger <jonathan.hofinger@gmx.de>Is this supposed to be supported? https://bugs.launchpad.net/inkscape/+bug/397796
2020-07-27 01-54-29 PDTjhofinger <jonathan.hofinger@gmx.de>great progress since yesterday, btw :)
2020-08-13 02-19-38 PDTjhofinger <jonathan.hofinger@gmx.de>ok :)
2020-04-05 09-54-36 PDTjhofinger <jonathan.hofinger@gmx.de>I added test to the root svg element
2020-08-13 03-36-39 PDTjhofinger <jonathan.hofinger@gmx.de>fyi: I won't be home until saturday, so I can't test (compiling on my laptop takes ages)
2020-07-26 02-53-28 PDTjhofinger <jonathan.hofinger@gmx.de>[ ](https://chat.inkscape.org/direct/vanntile?msg=ywLGsjq6igh8tzzKW) you could only scroll the contents, not the title bar ()
2020-07-26 02-57-38 PDTjhofinger <jonathan.hofinger@gmx.de>overall, it feels quite intuitive and adressses a lot lof issues users had with the previous design.
2020-07-27 01-50-40 PDTjhofinger <jonathan.hofinger@gmx.de>One suggestion which is not yet on your list: when a notebook is collapsed, show none of the tabs as selected. When the user clicks a tab, automatically expand the notebook. (Currently, when the notebook is collapsed, clicking just selects the tab, it's a bit confusing that you have to expand the notebook as well).
2020-07-26 09-53-13 PDTjhofinger <jonathan.hofinger@gmx.de>[ ](https://chat.inkscape.org/direct/vanntile?msg=EXaLdgWwPQJmXmYay) I think this one is missing on your list. Still happens to me all the time ()
2020-07-26 03-04-41 PDTjhofinger <jonathan.hofinger@gmx.de>and then dock it in the same window
2020-07-26 02-34-53 PDTjhofinger <jonathan.hofinger@gmx.de>once again something you didn't break, but if we have more scrolling inside dialogs, we should definitely fix that numeric boxes capture the scrolling events for value changes
2020-07-27 02-54-28 PDTjhofinger <jonathan.hofinger@gmx.de>ok, the next time I happen I will ask in the dev chat how to debug it
2020-08-12 06-42-11 PDTjhofinger <jonathan.hofinger@gmx.de>- dragging out to a new window fails
2020-07-26 02-18-08 PDTjhofinger <jonathan.hofinger@gmx.de>a bit like in blender
2020-08-12 07-24-26 PDTjhofinger <jonathan.hofinger@gmx.de>Yes of course. The decision which part of my feedback you decide to implement lies with you.
2020-07-27 01-47-01 PDTjhofinger <jonathan.hofinger@gmx.de>1 looks good
2020-07-26 09-58-16 PDTjhofinger <jonathan.hofinger@gmx.de>instead of opening a closed notebook when opening a new dialog, you should try to add it to an open notebook, preferably one with similar size
2020-07-26 02-45-55 PDTjhofinger <jonathan.hofinger@gmx.de>Could "Hide all tab labels" maybe be a property of the notebook, i.e. it becomes greyed out after clicking, and when I add a new dialog, the label is also hidden?
2020-07-26 02-08-18 PDTjhofinger <jonathan.hofinger@gmx.de>huh only seems to happen when opening from the terminal
2020-07-26 02-35-54 PDTjhofinger <jonathan.hofinger@gmx.de>I think you don't have to show a dialog's name in the hamburger menu if there is only one dialog in this notebook
2020-08-13 00-19-07 PDTjhofinger <jonathan.hofinger@gmx.de>#0 0x0000000001313d67 in Inkscape::UI::Dialog::AttrDialog::setRepr(Inkscape::XML::Node*) () from C:\msys64\home\jonat\inkscape\build\experimental\inkscape\bin\libinkscape_base.dll #1 0x000000000149abf7 in Inkscape::UI::Dialog::XmlTree::deferred_on_tree_select_row(void*) () from C:\msys64\home\jonat\inkscape\build\experimental\inkscape\bin\libinkscape_base.dll #2 0x00000000649f7b2d in libglib-2.0-0!g_main_context_dispatch () from C:\msys64\home\jonat\inkscape\build\experimental\inkscape\bin\libglib-2.0-0.dll #3 0x00000000649f7e88 in libglib-2.0-0!g_main_context_dispatch () from C:\msys64\home\jonat\inkscape\build\experimental\inkscape\bin\libglib-2.0-0.dll #4 0x00000000649f80d1 in libglib-2.0-0!g_main_context_iteration () from C:\msys64\home\jonat\inkscape\build\experimental\inkscape\bin\libglib-2.0-0.dll #5 0x000000000239429d in libgio-2.0-0!g_application_run () from C:\msys64\home\jonat\inkscape\build\experimental\inkscape\bin\libgio-2.0-0.dll #6 0x00000000004038c2 in main () Whenever I close a floating dialog
2020-07-26 02-46-20 PDTjhofinger <jonathan.hofinger@gmx.de>I spent far too much time on hackfixing the win32 theme, I feel you
2020-07-26 03-04-32 PDTjhofinger <jonathan.hofinger@gmx.de>when a dialog is in a separate window, you can open it again in the main window
2020-07-26 10-09-43 PDTjhofinger <jonathan.hofinger@gmx.de>whenever I should test something on Windows, just tell me - I've set up your branch as upstream and can pull whenever you like
2020-07-26 09-33-57 PDTjhofinger <jonathan.hofinger@gmx.de>will check out!
2020-08-02 23-31-32 PDTjhofinger <jonathan.hofinger@gmx.de>also bug 3 was user error (I think I told you), not your concern
2020-08-12 06-50-14 PDTjhofinger <jonathan.hofinger@gmx.de>- If I open F&S as docked, close the notebook and reopen it with Ctrl+Shift+F, Inkscape segfaults. (Happens with other dialogs too)
2020-04-05 09-21-12 PDTjhofinger <jonathan.hofinger@gmx.de>:/
2020-08-02 23-20-08 PDTjhofinger <jonathan.hofinger@gmx.de>5: same as 20
2020-07-26 03-17-40 PDTjhofinger <jonathan.hofinger@gmx.de>and it happened after i oepened path effects
2020-04-05 09-57-19 PDTjhofinger <jonathan.hofinger@gmx.de>Cool!
2020-07-26 03-20-49 PDTjhofinger <jonathan.hofinger@gmx.de>no idea if that helps
2020-07-26 03-04-14 PDTjhofinger <jonathan.hofinger@gmx.de>haha :D
2020-07-27 02-18-00 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/zd5oi8hxyqnma2r/2020-07-27%2011-16-19.mkv?dl=0 if you have a dialog with vertical zero size, defocusing its window causes it to jump up. Sometimes scrolling inside that window is also enough
2020-07-26 03-20-44 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/x5ysvc7nvdu9eb6/2020-07-26%2012-20-14.mkv?dl=0
2020-07-26 02-26-08 PDTjhofinger <jonathan.hofinger@gmx.de>ok :) you have to prioritize, i'm just writing whatever I notice
2020-07-27 02-02-36 PDTjhofinger <jonathan.hofinger@gmx.de>"Move tab to new window" should be in the context menu of the tab, not in the hamburger menu - an entry "move notebook to window" is missing there, though
2020-07-26 02-31-35 PDTjhofinger <jonathan.hofinger@gmx.de>yes, I was just wondering about the green highlight
2020-07-26 10-11-29 PDTjhofinger <jonathan.hofinger@gmx.de>the docking system has annoyed me for so long, great to see some progress - if it becomes more maintainable that way, the entire project wins a lot
2020-08-13 02-27-29 PDTjhofinger <jonathan.hofinger@gmx.de>anyway, fixed now, thanks ;)
2020-07-26 02-56-14 PDTjhofinger <jonathan.hofinger@gmx.de>whoa that sounds like a lot
2020-08-12 07-26-42 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - August 12, 2020 4:26 PM (https://chat.inkscape.org/file-upload/mmQ3WdMMvEQRR5FKs/Clipboard%20-%20August%2012,%202020%204:26%20PM)
2020-08-12 09-34-30 PDTjhofinger <jonathan.hofinger@gmx.de>hmm, on windows neither on_drag_fail nor on_drag_end is ever called...
2020-08-12 06-52-20 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/mwjwrc5pa994srp/2020-08-12%2015-51-44.mkv?dl=0
2020-07-26 02-24-40 PDTjhofinger <jonathan.hofinger@gmx.de>Whenever I open the XML editor, the notebook suddenly becomes very large horizontally
2020-08-02 23-38-26 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - August 3, 2020 8:38 AM (https://chat.inkscape.org/file-upload/3o5HcZSmjho63GK7d/Clipboard%20-%20August%203,%202020%208:38%20AM)
2020-07-26 02-50-23 PDTjhofinger <jonathan.hofinger@gmx.de>"move notebook to new window" really would be cool
2020-08-12 06-42-26 PDTjhofinger <jonathan.hofinger@gmx.de>- the context menu is great
2020-04-05 09-19-53 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - April 5, 2020 6:19 PM (https://chat.inkscape.org/file-upload/NmPNyscGWpPmzNc8P/Clipboard%20-%20April%205,%202020%206:19%20PM)
2020-08-12 22-12-17 PDTjhofinger <jonathan.hofinger@gmx.de>Nice :)
2020-07-26 02-51-58 PDTjhofinger <jonathan.hofinger@gmx.de>revisiting scrolling: the title bar of a notebook should probably be visible all the time
2020-04-05 09-53-09 PDTjhofinger <jonathan.hofinger@gmx.de>Adding a title attribute doesn't change anything.
2020-07-26 02-49-26 PDTjhofinger <jonathan.hofinger@gmx.de>you could automatically close separate dock windows if they don't have a dialog inside anymode
2020-07-26 02-58-16 PDTjhofinger <jonathan.hofinger@gmx.de>I haven't experienced any crashes either
2020-07-26 02-04-36 PDTjhofinger <jonathan.hofinger@gmx.de>Hi, I just checked out and compiled the docking-system-copy branch from your fork. Anything I could test? :)
2020-07-31 08-49-00 PDTjhofinger <jonathan.hofinger@gmx.de>failed locally as well, probably because gtkwayland.h ist not existent on Windows?
2020-07-26 03-10-32 PDTjhofinger <jonathan.hofinger@gmx.de>oh it's not only layers, it just depends whether a second desktop is open
2020-07-26 02-09-47 PDTjhofinger <jonathan.hofinger@gmx.de>ah nvm opened from bin and not from inkscape/bin :D i need a coffee
2020-08-02 23-21-56 PDTjhofinger <jonathan.hofinger@gmx.de>also agree that 8 and 19 are not relevant anymore
2020-08-13 00-23-00 PDTjhofinger <jonathan.hofinger@gmx.de>ok
2020-07-26 03-32-03 PDTjhofinger <jonathan.hofinger@gmx.de>In the old docking system, a lot of crazy things were possible (such as an undocked dialog being docked in another window, and still tracking the old window, which can then be closed, but the dialog remains in the second window and interacting with it causes segfaults), but your way of automatically switching a dialog's context makes a lot more sense
2020-04-05 09-21-40 PDTjhofinger <jonathan.hofinger@gmx.de>Thanks! If you find time, could you document the Paint servers dialog before 1.0?
2020-08-12 06-47-53 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/u0ohbrtyvyt9iht/2020-08-12%2015-47-15.mkv?dl=0
2020-07-26 02-15-36 PDTjhofinger <jonathan.hofinger@gmx.de>I like it so far! especially that you can resize dialogs below their min width
2020-07-26 03-08-38 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/mxa860x5i1z5awy/2020-07-26%2012-08-05.mkv?dl=0
2020-07-26 02-42-50 PDTjhofinger <jonathan.hofinger@gmx.de>it doesn't seem to remember that a dock has been in a separate window when I close that window and reopen the dialog
2020-07-26 03-07-11 PDTjhofinger <jonathan.hofinger@gmx.de>this is reproducible
2020-07-27 01-46-29 PDTjhofinger <jonathan.hofinger@gmx.de>For the third one: I don't see a horizontal scroll bar, but resizing below min width works. When I pull too fast, the dialogs seem to snap at a specific width
2020-08-02 22-28-05 PDTjhofinger <jonathan.hofinger@gmx.de>Thank you for your hard work on this!
2020-07-27 01-05-09 PDTjhofinger <jonathan.hofinger@gmx.de>I probably won't be able to help you there, but if there's something to test on Windows, just tell me
2020-07-27 01-58-10 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - July 27, 2020 10:58 AM (https://chat.inkscape.org/file-upload/GgJqYLtN2QprKYgi6/Clipboard%20-%20July%2027,%202020%2010:58%20AM)
2020-07-26 02-41-49 PDTjhofinger <jonathan.hofinger@gmx.de>I can't seem to drop dialogs on "you can drop dropable dialogs here"
2020-07-26 02-58-35 PDTjhofinger <jonathan.hofinger@gmx.de>certainly, yes; how much more time do you have for this?
2020-08-12 22-09-27 PDTjhofinger <jonathan.hofinger@gmx.de>Okay :) so all I did was removing the Wayland preprocessor directive around on_drag_end (and the if condition), and strarted Inkscape with the flag I mentioned above. I have no idea if there are regressions by using this flag, esp. on older systems though.
2020-07-27 02-21-23 PDTjhofinger <jonathan.hofinger@gmx.de>Also was a problem yesterday
2020-08-13 02-25-56 PDTjhofinger <jonathan.hofinger@gmx.de>From a usability perspective, the horizontal resizing of dialogs probably is only a good idea if dialogs are made a lot more flexible (through Glade-ification for example). That's out of scope for you obviously. The only thing I feel anxious about in the new system is the "dialogs of different height in one scrolling notebook" issue, I guess this will catch complaints
2020-07-26 02-13-21 PDTjhofinger <jonathan.hofinger@gmx.de>are you supposed to be able to scroll when collapsed?
2020-07-26 10-04-18 PDTjhofinger <jonathan.hofinger@gmx.de>why? if they are all visible, show only "hide". If they are all collapsed, show only "make visible". If some are collapsed and some are not, show both.
2020-07-26 03-34-08 PDTjhofinger <jonathan.hofinger@gmx.de>I really think my main pain points are: windows don't stay afloat, docking in empty docking areas and dragging a dialog out to spawn a new window. If this + saving configuration + some design fixes are done, it's pretty amazing
2020-07-26 02-50-05 PDTjhofinger <jonathan.hofinger@gmx.de>also, if there is only one dialog in a separate window, "move tab to new window" doesn't really make sense
2020-08-12 06-42-04 PDTjhofinger <jonathan.hofinger@gmx.de>- you should remove the "you can drop dockable dialogs here"
2020-07-26 02-53-50 PDTjhofinger <jonathan.hofinger@gmx.de>(might be a lot easier said then done)
2020-07-26 03-13-21 PDTjhofinger <jonathan.hofinger@gmx.de>Unbenannt.PNG (https://chat.inkscape.org/file-upload/TDBLajdu4aoRwXEzy/Unbenannt.PNG)
2020-07-26 03-13-33 PDTjhofinger <jonathan.hofinger@gmx.de>let me see if I can replicate that
2020-08-12 11-13-00 PDTjhofinger <jonathan.hofinger@gmx.de>this flag is never mentioned anywhere, not even in the GTK code
2020-07-27 01-53-50 PDTjhofinger <jonathan.hofinger@gmx.de>ideally, don't show any tab as selected when collapsed, since that has no meaning to the user.
2020-07-26 10-05-53 PDTjhofinger <jonathan.hofinger@gmx.de>Definitely better than a crash, but imo it belongs to "known issues"
2020-07-27 02-11-53 PDTjhofinger <jonathan.hofinger@gmx.de>> drag & dropping dialog tabs to undefined areas doesn't work on Windows and X11 (should work on Wayland) I just noticed that the small area on top (green border when dragging something over it) still works
2020-08-13 02-17-30 PDTjhofinger <jonathan.hofinger@gmx.de>Your branch shows that the last commit is an hour old (https://gitlab.com/vanntile/inkscape/-/tree/docking-system-copy), different branch?
2020-07-26 02-18-02 PDTjhofinger <jonathan.hofinger@gmx.de>have you considered making the docks resizable horizontally as well? and when they are resized below a certain width, they disappear
2020-07-26 02-08-23 PDTjhofinger <jonathan.hofinger@gmx.de>looks fine otherwise
2020-07-26 02-52-44 PDTjhofinger <jonathan.hofinger@gmx.de>I think thomas was working on this before the 1.0 release
2020-07-27 01-59-38 PDTjhofinger <jonathan.hofinger@gmx.de>Some quick fixes (hopefully): 1) the title bar of the dialogs is not translated 2) the title still has "..." behind it 3) the top (cropped) dialog ends without a border. Maybe add a bottom border to the notebook (same to the right with the new feature)
2020-07-26 02-07-22 PDTjhofinger <jonathan.hofinger@gmx.de>I'm getting a ton of warnings also, units.xml is e.g. missing
2020-07-26 02-06-03 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - July 26, 2020 11:05 AM (https://chat.inkscape.org/file-upload/9qpDCJCX8ukAHdABF/Clipboard%20-%20July%2026,%202020%2011:05%20AM)
2020-08-02 23-22-32 PDTjhofinger <jonathan.hofinger@gmx.de>Probably true.
2020-07-27 02-48-34 PDTjhofinger <jonathan.hofinger@gmx.de>okay perfect. We had bug reports about a missing space in front of the ellipsis in menu entries on mac in some languages because interface guidelines differ... people _will_ notice, and they will create bug reports
2020-08-12 09-35-56 PDTjhofinger <jonathan.hofinger@gmx.de>any more signals I could try?
2020-08-12 07-27-48 PDTjhofinger <jonathan.hofinger@gmx.de>I think I told you this before, but in this situation, noone will notice that there are controls at the bottom of the Selects & CSS dialog (there are others like this, XML editor for example, or text).
2020-07-26 10-02-59 PDTjhofinger <jonathan.hofinger@gmx.de>I think the fix for the dialogs that remain open after closing is not that simple. Imagine you have a master document with some undocked dialog, and a second inkscape window open. Now you want to close the second window. When it's focused, the dialog suddenly listens to that document, and closing it closes it as well - which the user probably didn't want (that's at least what happens currently on your branch). I'd only close the dialogs when the last instance is closed.
2020-07-26 03-17-11 PDTjhofinger <jonathan.hofinger@gmx.de>at least i managed to make it happen again
2020-07-26 02-22-51 PDTjhofinger <jonathan.hofinger@gmx.de>When right clicking the dock, the Layers dialog is shown as "Page 2" for me - looks like it doesn't find the title of the dialog
2020-07-26 03-04-12 PDTjhofinger <jonathan.hofinger@gmx.de>Clipboard - July 26, 2020 12:04 PM (https://chat.inkscape.org/file-upload/FvDnRjdMqxCuvYkos/Clipboard%20-%20July%2026,%202020%2012:04%20PM)
2020-08-12 07-21-35 PDTjhofinger <jonathan.hofinger@gmx.de>If the automatic resizing is blocked by scrolling, then deactivate it. We can't explain to users why only half of the dialog is visible by default.
2020-08-02 23-21-43 PDTjhofinger <jonathan.hofinger@gmx.de>I just wanted to say that I understand your decision and would probably have done the same
2020-08-13 02-29-59 PDTjhofinger <jonathan.hofinger@gmx.de>Is it possible that whenever a dialog is docked, you trigger a complete re-rendering of the window (like what happens when you change the window size)? I guess that could fix the locking up on Windows. As soon as I resize the window, it immediately functions again.
2020-07-26 03-28-21 PDTjhofinger <jonathan.hofinger@gmx.de>I see your point.
2020-07-26 03-00-26 PDTjhofinger <jonathan.hofinger@gmx.de>nice :)
2020-08-12 07-28-36 PDTjhofinger <jonathan.hofinger@gmx.de>alright
2020-07-26 02-23-13 PDTjhofinger <jonathan.hofinger@gmx.de>I now. For now, we could just add a horizontal scroll bar inside dialogs
2020-04-05 09-57-37 PDTjhofinger <jonathan.hofinger@gmx.de>Oh definitely.
2020-07-27 02-05-13 PDTjhofinger <jonathan.hofinger@gmx.de>Additional idea: closing tab with Middle mouse button click, and reopening with Ctrl+Shift+T just like in a browser
2020-07-26 09-56-34 PDTjhofinger <jonathan.hofinger@gmx.de>Alternating the "Hide labels" is a step in the right direction, but now you can hide them, un-hide them one by one and the menu still says "hide labels". Maybe have both of them, but when all are visible, the "unhide" one is insensitive, and vice versa
2020-07-27 01-46-31 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/wusie0pihgfznsx/2020-07-27%2010-45-10.mkv?dl=0
2020-08-13 02-18-45 PDTjhofinger <jonathan.hofinger@gmx.de>crash is fixed
2020-07-26 02-47-52 PDTjhofinger <jonathan.hofinger@gmx.de>you can't do this kind of arrangement, right?
2020-07-26 02-12-16 PDTjhofinger <jonathan.hofinger@gmx.de>When collapsed, it looks like this for me
2020-07-26 02-36-24 PDTjhofinger <jonathan.hofinger@gmx.de>and maybe change the text to "Highlight Layers" instead of "Layers..."
2020-04-05 09-25-18 PDTjhofinger <jonathan.hofinger@gmx.de>That one as well: https://bugs.launchpad.net/inkscape/+bug/172168
2020-07-26 10-06-27 PDTjhofinger <jonathan.hofinger@gmx.de>do you feel like you get enough feedback from the advisors?
2020-07-27 01-55-48 PDTjhofinger <jonathan.hofinger@gmx.de>My feeling is that some GSoC projects in the past lacked polish and left a lot of work for the maintainers. It looks like you have time to do that :)
2020-08-13 02-18-51 PDTjhofinger <jonathan.hofinger@gmx.de>anything else I should test for?
2020-08-02 22-29-50 PDTjhofinger <jonathan.hofinger@gmx.de>Okay 😊
2020-07-27 01-52-13 PDTjhofinger <jonathan.hofinger@gmx.de>[ ](https://chat.inkscape.org/direct/vanntile?msg=EXaLdgWwPQJmXmYay) that one is still missing from your list ()
2020-04-05 09-19-03 PDTjhofinger <jonathan.hofinger@gmx.de>Sure:
2020-07-27 02-14-06 PDTjhofinger <jonathan.hofinger@gmx.de>- the shortcuts to open a new dialog don't work when a floating window is focused
2020-08-12 07-19-56 PDTjhofinger <jonathan.hofinger@gmx.de>If you redock a floating dialog, close the notebook and open it again, nothing happens. If I close Inkscape afterwards, it segfaults.
2020-07-27 02-06-51 PDTjhofinger <jonathan.hofinger@gmx.de>I don't know if this problem exists on Linux as well, but the floating dialog windows have the unfortunate property that focusing them unfocuses (greys out) the main window. That's a bit annoying. It's also an issue on Master, but if you have an idea how to fix that, that'd be great
2020-07-26 02-51-10 PDTjhofinger <jonathan.hofinger@gmx.de>I can't seem to get a window floating above the canvas, might be another windows limitation
2020-07-27 00-51-42 PDTjhofinger <jonathan.hofinger@gmx.de>The fix looks good to me. :)
2020-04-05 09-20-04 PDTjhofinger <jonathan.hofinger@gmx.de>Now it looks like this in every document
2020-07-27 02-01-50 PDTjhofinger <jonathan.hofinger@gmx.de>Also missing from your list, I think: you can have the same dialog twice in an undocked window (I guess nobody needs that)
2020-07-26 02-14-14 PDTjhofinger <jonathan.hofinger@gmx.de>Also, when I collapse, and then immediately swich to a different tab, it scrolls down to the contents of that tab
2020-04-05 09-52-11 PDTjhofinger <jonathan.hofinger@gmx.de>I placed the file (as it is) in %inkscape%/paint. When I open Inkscape, the paint servers dialog looks like in my screenshot.
2020-04-05 09-56-26 PDTjhofinger <jonathan.hofinger@gmx.de>That would fix both the crash and my problem.
2020-08-12 06-44-58 PDTjhofinger <jonathan.hofinger@gmx.de>if you add a second dialog into an existing floating window, it should increase the size accordingly
2020-07-26 03-32-58 PDTjhofinger <jonathan.hofinger@gmx.de>like icon preview or CSS
2020-07-26 02-19-34 PDTjhofinger <jonathan.hofinger@gmx.de>people often complain that the dialogs are too wide
2020-04-05 09-57-14 PDTjhofinger <jonathan.hofinger@gmx.de>(And especially, patterns from this document shouldn't be displayed if they can't be used, as in my screenshot)
2020-08-13 02-18-18 PDTjhofinger <jonathan.hofinger@gmx.de>ok alright, will test
2020-08-13 02-21-05 PDTjhofinger <jonathan.hofinger@gmx.de>I mean, can you nitpick things? Yes, a lot. Is it an adequate replacement of the old system? Yes, and I'd argue that some things have considerably improved
2020-07-26 02-29-14 PDTjhofinger <jonathan.hofinger@gmx.de>https://www.dropbox.com/s/1gu854je2wkna8z/2020-07-26%2011-27-29.mkv?dl=0 is this supposed to happen?
2020-08-13 02-20-00 PDTjhofinger <jonathan.hofinger@gmx.de>Good job! IMO it should be ready :)