2020-11-15 08-37-33 PST | Rachana <rpodaralla3@gatech.edu> | Hey Jabier, I tried what you suggested and my change does not seem to affect the number of times dobeforeeffect is being called |
2020-11-14 09-57-29 PST | Rachana <rpodaralla3@gatech.edu> | yes |
2020-11-14 09-57-16 PST | Rachana <rpodaralla3@gatech.edu> | okay sure, I will go try that now. Thank you :slightly_smiling_face: |
2020-11-15 08-41-39 PST | Rachana <rpodaralla3@gatech.edu> | awesome, thanks |
2020-11-14 09-52-21 PST | Rachana <rpodaralla3@gatech.edu> | Hi Jabier! I'm working on this MR: https://gitlab.com/inkscape/inkscape/-/merge_requests/2503#note_447551660. You added a comment about my changes adding more loops to the LPE stack |
2020-11-15 08-40-24 PST | Rachana <rpodaralla3@gatech.edu> | yes, but I thought I need to get approval from someone before I can |
2020-11-15 08-37-47 PST | Rachana <rpodaralla3@gatech.edu> | Do you know if its okay to merge yet? |
2020-11-15 14-26-22 PST | Rachana <rpodaralla3@gatech.edu> | no worries! just take a look at it whenever you have some free time |
2020-11-14 09-53-09 PST | Rachana <rpodaralla3@gatech.edu> | I'm new to this part of the code and I was wondering if you could elaborate on what that means |
2020-11-15 08-41-42 PST | Rachana <rpodaralla3@gatech.edu> | :slightly_smiling_face: |
2020-11-14 09-57-05 PST | Jabier Arraiza <jabier.arraiza@marker.es> | if the number of workings are equal Bingo!!!! |
2020-11-14 09-53-12 PST | Jabier Arraiza <jabier.arraiza@marker.es> | is cool adition |
2020-11-15 12-41-31 PST | Jabier Arraiza <jabier.arraiza@marker.es> | Sorry forget it tomorrow update |
2020-11-14 09-57-34 PST | Jabier Arraiza <jabier.arraiza@marker.es> | :) |
2020-11-14 09-56-12 PST | Jabier Arraiza <jabier.arraiza@marker.es> | (plese add some string before press to keep position) |
2020-11-14 09-54-10 PST | Jabier Arraiza <jabier.arraiza@marker.es> | just add in a LPE with scalar widget in the function dobeforeeffect a cout |
2020-11-14 09-56-41 PST | Jabier Arraiza <jabier.arraiza@marker.es> | after it comment your improvement and do it again |
2020-11-14 09-53-04 PST | Jabier Arraiza <jabier.arraiza@marker.es> | yes |
2020-11-14 09-54-59 PST | Jabier Arraiza <jabier.arraiza@marker.es> | add a LPE of this type |
2020-11-14 09-55-32 PST | Jabier Arraiza <jabier.arraiza@marker.es> | and increase the value 1 time (pressing +or-) |
2020-11-14 09-57-16 PST | Jabier Arraiza <jabier.arraiza@marker.es> | you undertand me? |
2020-11-14 09-55-50 PST | Jabier Arraiza <jabier.arraiza@marker.es> | count the number of working show in console |
2020-11-14 09-54-38 PST | Jabier Arraiza <jabier.arraiza@marker.es> | `std::cout < "working" < std::endl;` |
2020-11-15 08-41-04 PST | Jabier Arraiza <jabier.arraiza@marker.es> | I do in some minutes |
2020-11-15 08-39-53 PST | Jabier Arraiza <jabier.arraiza@marker.es> | Yes, you have rights? |