[Webmaster] Rocket.Chat, 2 Users, 19 Messages, 0 Files, 284017 Minutes, in Direct Message Between: anonym_i_ous & Mc
2020-10-13 12-40-27 PDT Mc git grep is magic 2020-10-13 12-53-23 PDT Mc (my thought process when I posted the issue was "heh, that does not really work, let's fix it" -> "that code makes no sense. Wait, no, these options make no sense. Mmmmh... what could make sense here ? Oh, we have ux folks. Let's ask them") 2020-10-13 12-50-21 PDT Mc but even then, I'm like "Hello I'm one of the most active inkscape dev around, I've been using inkscape for 10 years and I do say that this tiny thing miiight need a rethinking" nd the answer is like "nope. works fine" when 30 seconds of testing (just 1/ change to another palette than the default 2/ try anything) show there is something horribly wrong :p 2020-10-13 12-38-38 PDT Mc general advice : 1/ try to look for a word that's not common, and present in the surroundings of what you're looking for -> here I will use "Wrap" 2/ have a general guess at where it is -> it's in the user interface, so we'll look in src/ui/ 3/ git grep '"Wrap"' -> ``` ~/inkscape/src/ui$ git grep '"Wrap"' dialog/swatches.cpp: //TRANSLATORS: "Wrap" indicates how colour swatches are displayed dialog/swatches.cpp: Glib::ustring wrap_label(C_("Swatches","Wrap")); ``` 4/ -> here you go! In that file you'll find that the options are linked to some "_holder->setStyle(...)" calls, so you have to fgind what _holder is. 5/ in swatches.h (the corresponding header file) you'll find it's a PreviewHolder 6/ (but we don't really care ! wer could just git grep ::setStyle -> ``` ~/inkscape/src/ui$ git grep ::setStyle previewholder.cpp:PreviewHolder::setStyle(UI::Widget::PreviewSize size, widget/style-swatch.cpp:void StyleSwatch::setStyle(SPCSSAttr *css) widget/style-swatch.cpp:void StyleSwatch::setStyle(SPStyle *query) ``` 7/ code is in that file :) 2020-10-13 12-45-04 PDT Mc As a side note, I still find that what those two dropdowns do is very unintuitive in general, which is the reason I posted in the ux tracker... I wnated to prompt reflexions about "does anyone put a border ? so do we need that option ?" "If options do nothing, why do we display them ?" "can anyone use the swatches when they are 2 pixels wide ?" "why do the « width » change, change the height ?" and the fact that the answer was mostly "oh everything is fine, here is an ugly squared UI with sliders that adresses none of your points" made me quite sad 2020-10-13 12-56-09 PDT Mc :) 2020-10-13 12-49-38 PDT anonym_i_ous (ref: ux#51) 2020-10-13 12-55-17 PDT anonym_i_ous (continued) but then again, as i have some doubts if people actually change the chip/tile size, i doubt that not closing this would become unwanted (for example after changing the pallete to smth else). 2020-10-13 12-52-35 PDT anonym_i_ous maybe 2020-10-13 11-23-54 PDT anonym_i_ous can u guide me where i can find the code location of the palette options?? 2020-10-13 12-52-18 PDT anonym_i_ous also, one more thing can be improved in ux. that changing the options shouldnt make the menu to disappear. 2020-10-13 12-39-18 PDT anonym_i_ous niice. thanks a lot 2020-10-13 12-51-12 PDT anonym_i_ous haha, yeah, right 2020-10-13 12-48-39 PDT anonym_i_ous not blaming or anyth, but he is a ux/ui person. and so... amh, when we work too much with something, it starts to penetrate in other things as well right!!? i think thats what happened there with him. 2020-10-13 11-23-12 PDT anonym_i_ous hello there 2020-10-13 12-40-10 PDT anonym_i_ous i thought there was some magic way :sweat_smile: 2020-10-13 12-48-21 PDT anonym_i_ous hahahaha. lol yeah i can agreee to that. 2020-10-13 12-40-41 PDT anonym_i_ous (cntd...) like click the action/button and the called command will show up - say in command prompt somehow 2020-10-13 12-56-05 PDT anonym_i_ous yeah, i agree that it would need much thought.
participants (1)
-
no-reply@chat.inkscape.org