The gtest download script could be removed by adding the googletest
source as a git submodule within the Inkscape repo... this is how it's
done in 2geom.
**BUT** I don't think that Launchpad supports submodules, so this
could cause issues with PPA builds.
Does anyone know a way round this?
AV
On 16 July 2017 at 00:02, Marc Jeanmougin <marc@...3062...> wrote:
[...]
>>> + _clang-format
>>>
>>> I'm not sure why this is in the tree. Guessing it was a jenkins-
>>> related thing? I suspect we can drop this.
>>>
>>
>> Is a similar objective than astylerc both need external programs to
>> run maybe we need to select the less intrusibe or the best OS
>> compatibility one
>
> True, yes, not a bad idea. Alternatively, if we're going to have a
> collection of such things, they could be housed in a subdirectory
> somewhere. Projects will often carry configs for vim, emacs, and other
> editors... Having them in one place might also make it easier to spot
> discrepancies in each other's formatting configurations.
clang-format is similar to astyle, but it has the advantage that we can
use it directly without moving the style file: from the man page, iirc
clang-format looks for .clang-format files situated in parent
directories of the formatted file(s).
(Side note: I'd actually be in favor of automatically running
clang-format on MR if it's technically possible (a possibility would be
to run it as a "test" and prevent merges of branches that make tests fail))
--
Marc
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites,
Slashdot.org!
http://sdm.link/slashdot
_______________________________________________
Inkscape-devel mailing list
Inkscape-devel(a)lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/inkscape-devel