On Fri, 17 Dec 2004 11:54:38 +1100, Peter Moulder <Peter.Moulder@...38...> wrote:
Latest CVS still craches on bitmap import. Looks like the person who touched this code recently was pjrm. Peter, could you please look into this? And please test your changes thoroughly before committing. (Of course errors happen, but this is a very obvious bug which should have been caught before committing).
I did indeed test before committing, both by using inkscape and ensuring that the changed code was executed, and even by creating a new unit test program (dir-util-test.cpp). To detect this bug, it isn't sufficient to test the changed code or even to test every caller of the changed code. I suggest that this bug is not caused by inappropriately little testing by the developer.
I did not mean to offend. It just seemed to me that both calling a function with NULL (for automated testing) and importing bitmaps (for workflow testing) are very obvious things to check. Maybe I was wrong. I'm not advocating any change in our process, just being more careful.
Incidentally, please compile your changes before committing, and look for any introduced warnings. E.g. this would have alerted Bulia to a bug he introduced a few days ago which I've now fixed.
Yeah, but to be fair, that bug was in debug code that does not normally run, and it would not crash anyway :)