On Fri, Jun 23, 2017 at 12:23:38PM -0300, Felipe Sanches wrote:
2017-06-23 9:59 GMT-03:00 alvinpenner <penner@...1856...>:
then a query to the git tree will show you precisely where a certain
commit is located
- how exactly would you perform such a query?
visit the webpage: https://gitlab.com/inkscape/inkscape/commit/0868ec95
replacing 0868ec95 with the actual commit you're interested in. That will show you all the metadata such as author, commit date&time, description, code changes, etc...
Alvin, if you haven't already, try:
git show 0868ec95
I find I use this command a lot.
- what is the preferred format for reporting such a commit number in a bug
report?
Please, always refer to the commit hash when reporting a bug, because that is absolutely the most precise way to refer to a commit unambiguously.
In bug reports, a common practice I've seen in the linux and x.org communities is to cut and paste the commit message, so like:
Bug 123 ------------------------------------------------------------------------
... In testing your suggested change, I no longer saw the issue.
Great, thanks for testing. Pushed:
commit 0868ec95edd45394fcf583bf3f1cfa311e8a4c1d Author: Felipe CorrĂȘa da Silva Sanches <juca@...2270...> AuthorDate: Thu Jun 22 21:56:51 2017 -0300 Commit: Felipe CorrĂȘa da Silva Sanches <juca@...2270...> CommitDate: Thu Jun 22 21:58:21 2017 -0300
rename SPIVariableFontAxisOrNormal => SPIFontVariationSettings and implement full parsing of multiple axes and respective design-space coordiantes. ------------------------------------------------------------------------
For the triager it's no extra work to cut and paste the entire description versus just the commit SHA, but it communicates a lot more information to the reader.
Bryce