Hi Diederik,
DeĀ : Diederik van Lierop <mail@...1689...> On 12/20/2011 12:57 PM, Nicolas Dufour wrote:
PS: Apparently the snap indicator color is broken
I don't know if it's broken or not, because I don't recall it being different. But feel free to change it; it has been suggested before by someone to have a tooltip similar to the ones from the measurement tool.
Just tested it on Ubuntu, and I confirm that with 0.48.x there's a white stroke on the text that no longer show with the trunk, and thus the blue text alone is very difficult to see on a dark background. Note that replacing it with the style used on the measurement tools is far better than the white stroke IMHO.
SnapIndicator::set_new_snaptarget is *always* called with pre_snap=false
Not true. I just tested it and at least at my system it behaves as expected. pre_snap is true when doing a pre-snap, and false when doing a regular snap. How did you test this?
I made the erroneous assumption that the snap tooltips were different on a dark background, and that it was handled by the pre-snap code. Must admit I completely misunderstood the code, sorry.
Regards, -- Nicolas