[Inkscape-devel] Review lastFromClipboard

Thanks for the review Krzysztof.

Anybody confirm about first point? If is wrong with no manual XML modification... Second point. Any body can help me? Third point is bad because i like the strokes like the original, I dislike force the style to black and always filled. If is posibol to continue with it i need a better name...you are welcome.

Hi, Jabier.

El lun, 09-09-2013 a las 15:54 +0000, Krzysztof Kosinski escribió:

Review: Disapprove

1. This feature is misleadingly named. It will apply the first stroke

shape encountered in the defs. As far as I know, there is no guarantee on the order of defs.

2. The line "if (pattern == (const gchar *)"M 0,0 1,0") continue;" is

wrong - you can't test for pointer equality even when one of the strings is constant.

3. Confusing control flow around the "shape_applied" variable. It

should default to false and be set to true inside the if.