On Fri, 2005-03-11 at 09:26, Bob Jamison wrote:
I downloaded/installed a prerelease snapshot of gcc4.0.0 today, and did a clean build with it. I expected it to produce better warnings than 3.4, since 3.4 was more strict than 3.3. And it does! Here is an example:
./xml/node.h:42: warning: ‘class Inkscape::XML::Node’ has virtual functions but non-virtual destructor ./xml/document.h:23: warning: ‘struct Inkscape::XML::Document’ has virtual functions but non-virtual destructor ./xml/sp-css-attr.h:20: warning: ‘class SPCSSAttr’ has virtual functions but non-virtual destructor
The planned release of 4.0.0 is Apr 15, so it would be wise to keep up with developments.
Huh. I suppose we can add an empty virtual destructor to Inkscape::XML::Node, but in practice it doesn't really matter, as 1) Inkscape::XML::Node destructors are never called, and 2) Inkscape::XML::Nodes are never deleted using that interface anyway.
(Of course the compiler can't know that.)
-mental