On Tue, 14 Feb 2006 mental@...3... wrote:
Log Message:
replaced connectors in connector layout icon with ordinary line to fix weird bug that needs a better solution! basically, connectors in the icon were being confused with connectors in the main document and ids were overlapping and causing problems when trying to extract the connector graph
If the connector code confuses conflates elements with the same ID in different documents, that's a VERY, *VERY* serious issue.
I sincerely hope this isn't a result of inappropriate use of global variables...
Yes, I discovered the problem with icons and multiple documents yesterday afternoon as a result of troubleshooting a bug Tim was seeing, and then chating to JonCruz on jabber. The connector code does confuse IDs currently. And I agree completely with how serious a problem that is.
This comes out of having a single instance of libavoid, rather than one per document. This was really just due to the false assumption on my part doing the Summer of Code work, in not really understanding the ideas of separate documents properly and how that works within Inkscape.
I've been working on the fix this morning, so it will be in the codebase shortly. Tim just commited that change to the icons file to allow him to keep working on his graph layout code without seeing the problem.
Cheers, Michael