Thanks for pointing this out, it's done now.
On Sun, Nov 04, 2007 at 01:23:49AM +0100, J.B.C.Engelen@...1578... wrote:
Please someone have a look at this: http://wiki.inkscape.org/wiki/index.php/Coding_Style#Tabs_and_Alignment_ .28is_there_still_discussion_about_this.3F_I_think_we_settled_on_4_space s_for_indentation_and_.2Ano.2A_tabs_anywhere.29
(the Tabs and Alignment section)
Please make it say: NO TABS , USE 4 SPACES! Should we delete the discussion stuff, or keep it there?
Johan
-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Jon A. Cruz Sent: zondag 4 november 2007 0:54 To: Diederik van Lierop Cc: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] tabs
On Nov 3, 2007, at 2:33 PM, Diederik van Lierop wrote:
After my commit of today, Johan Engelen pointed out that there were
quite some tabstops being used in it instead of spaces. I started an
automated find & replace, replacing all tabs with four spaces in just
that commit. Worked like a charm.
I also found tens of thousands of tabs when searching just *.h in /src.
Now I wonder: should we do a massive search & replace on the full code
base? I've tried and it compiles nicely. It also doesn't mess up the
indenting, at least not in the places I've looked at. Is it worth it? Or
will it give to much troubles in the end afterall?
I've seen a few places where just converting to four spaces will not get the right formatting, so it could be slightly more complex than that.
Trailing whitespace, on the other hand, is safe to purge. Emacs even has a command that does it. :-)
One factor is if things with tabs are properly indented already or not. Another one is edge cases, like when parameters to a function are spread onto more than a single line.
Also, you should check if any of the files in question are missing the formatting footer we've been adding. That's something to put in as a first step.
Once you look to change something you could do is run the files through emacs' indent-region and compare the result to your space-replaced ones. If there is any difference, then those could be marked for later review.