bulia byak wrote:
Excellent! The test file now renders the same as in Batik (but not Adobe, looks like Adobe does not support this attribute). I applied your patch. Please keep contributing :)
I love this project. I will surely look into other areas of it. The next area I am very interested in are the effects.
Now, I'm still not sure we need a right-click menu item for this. Just try to scale one the the bottom row images. They behave quite counter-intuitively. Kinda like broken pattern fill. I know there's logic to it, but it's not easy to grasp. On the other hand, what this attribute provides is easily and interactively achievable via standard scaling and clipping (we don't fully support clipping yet, but it's easy to emulate via object-to-pattern), so investing into learning this logic will not really pay off unless you have very special needs. So, I still think that an "Advanced" tab in Object Properties is the best place for setting this attribute.
Yeah, it doesn't necessarily need a right-click menu item. Even though I am going to be using this as a template engine, most people probably aren't. What I would love to see is user definable Python actions that can be added to the right click menu of specific sp-items. That would be perfect for my situation. But also, having preserveAspectRatio in the object attributes (whether under advanced or not) is necessary in case somebody loads up an SVG and can't figure out how to get it to quit behaving counter-intuitively ;-).
Edward Flick