OK, thanks a lot for the quick reaction and code update. I plan to test again this WE on WinXP, win2k, mdk10.1 (if i manage to build) and debian (ubuntu)
Regards,
Matiphas
-----Original Message----- From: MenTaLguY [mailto:mental@...3...] Sent: vendredi 19 novembre 2004 07:35 To: bulia byak Cc: Gazal, Geraud (GE Healthcare); Inkscape ML Subject: Re: [Inkscape-devel] layer testing
On Thu, 2004-11-18 at 23:30, bulia byak wrote:
Mental: I now fixed that by traversing the chain of all parents in SPItem::isLocked(). Please review this fix. It works but may not be optimal.
I can't think of a better approach. When I realized the problem earlier today I was going to do that myself.
Perhaps better if you can make it inherited in the setter, not getter.
I wouldn't try that unless the getter was unacceptably slow.
Currently, the setter is O(1), and the getter (with inheritance) is O(log n). Doing it the other way around would make the getter O(1), at the expense of making the setter O(n), which would suck much worse for large trees.
It might not be such a big disadvantage if SVG trees were typically deep and narrow, but shallow and broad is the normal case: it's not too unusual to have e.g. 200 children of a single parent, but nesting deeper than 3 or 4 levels is unusual.
Under those circumstances, traversing upwards (even multiple times) is much cheaper than recursively visiting all descendants.
chapter 2 in the same (locked) layer toggle to any shape tool and
try to draw
another shape -> possible (don't know if it is cool or not)
I think it's not cool but it needs fixing in many places,
so unlikely
to be ready for the release.
Hmm. I'd still like to look into it if we could. It's a pretty visible bug.
-mental