Rygle wrote:
Hi guys, just trying to get my head around all this.
No problem.
I committed this and milestoned for release in 0.47, but I assumed that Aaron and/or a release warden would check it out before the proper release. I was trying to flag somehow that this is new and needs to be approved. That's why I set it as Wish List and Fix Committed, not Fix Released. Should I have instead marked it as Fix Released and nominated it for release 0.47? Or just leave any milestoning/nomination because it's automatically in? Seems like it won't get noticed by release wardens then.
There are no release wardens for 0.47 yet. Release wardens impose marshal law during release times to make sure things get out the door in a reasonable amount of time and without any avoidable nasty bugs. During the normal development cycle we average contributors are in charge. If you've been granted commit access the Inkscape community trusts you to decide what goes into the tree.
I'm also unsure, but based on Maximillian's comments, but do some people feel that applying patches treads on toes if the bug is assigned to someone else? I merely wanted to get it into trunk so that people would find any problems with it. I've seen some good patches that didn't make it into 0.46 because they didn't get attention. Should I not commit patches when the bug is assigned to someone else? Please be frank, because I don't want to offend others.
I think sometimes applying a patch assigned to another person could possibly maybe tread on another person's toes perhaps. This time it didn't. I grabbed this patch because the author had written me individually about the change and because there doesn't seem like a lot of people who want to deal with python patches. But I knew that I wasn't going to get around to committing it until the weekend and it is very important to have quick turn around on patches. This shows that we value the work being done and encourages repeat contribution. Just think how discouraging it is when I sit on a two line python patch that is obviously fine. You're timing was excellent.
Feel free to commit a patch. As long as you do due diligence. Meaning: You understand the issue it addresses. You test it locally to see that it does address that issue. You do not notice any major regressions as a result of it. Otherwise ask for a little clarification and help. And if you feel comfortable, go ahead and assign bugs to yourself. :-) And, yeah, it probably doesn't hurt to ask if the bug is assigned to someone else. I know in my situation sometimes I don't comment everything I know on the bug because I don't think of it. There might be some issue I want to check into. So if you ask I'd be more likely to write that in the bug comments. Not trying to hide info; I just don't think of these things all the time.
Thanks for applying this patch!
Aaron
P.S. I'm copying Inkscape-devel to give people a chance to disagree with me. :-)