Joshua, release warden, I do not have "the" solution for https://bugs.launchpad.net/inkscape/+bug/273767 But I have a fix in post #6 of this issue that might prevent further crashing by range overflow. The other one has a deeper impact in everything so I can not judge how it behaves on the other end.
PLs review the first patch and commit.
I agree to concentrate on release critical issues. so please summarise what is still open. And what has to be done.
Thanks, Adib.
On 10/4/09, Joshua A. Andler <scislac@...400...> wrote:
On Sun, 2009-10-04 at 15:58 +0100, Richard Hughes wrote:
- Open file
- On the second line of text in the red box, select "RIA ยท MEL".
- Change the font size
The black is then stripped from all of the black text on that line (even the stuff not selected).
Well, you've certainly opened up a can of worms here. Attached are three independent patches:
That's what I do. ;)
Looks like it's time for the release wardens to make some hard decisions. If you need any more information on the possible impact of each patch, please ask.
I think that the patches read safe, but obviously the can I opened up was on more of an edge case (at least that's how it appears). I'm not sure that it's worth potentially breaking more so close to a release, then again, what do you think Richard? What is the possible impact of the 2nd and 3rd patches?
I will definitely commit the first patch for the release (one less crash, yay!). If you don't think it's worth chancing so close to release, the other 2 can just go in after trunk opens back up (obviously safest option). However, if you feel that it really fixes a deeper issue that we just weren't aware of and the risks aren't terribly high, I will defer to you in this area. As mentioned before, I'm willing to do a .1 for 0.47 (just would prefer not to).
Cheers, Josh
Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel