Re: [Inkscape-devel] inkscape root dir tidying thoughts
On Sat, Jul 22, 2017 at 03:36:12PM -0700, Bryce Harrington wrote:
On Fri, Jul 14, 2017 at 04:41:44PM -0700, Bryce Harrington wrote:
> With the cmake and git conversions complete, and autotools and bzr bits
> removed, I am wondering if there's some additional cleanup of stuff
> accumulated in our repository's root directory. But much of this I'm
> not 100% sure about (and that maybe why others haven't already dealt
> with it).
>
>
> ------------------------------------------------------------------------
> + inkscape.desktop.in
> + inkscape.desktop.template
>
> Is inkscape.desktop.in generated from inkscape.desktop.template? Do we
> need both files?
Still unsure here, leaving them for now.
https://bugs.launchpad.net/inkscape/+bug/1710332
The inkscape.desktop.template file is used by po/CMakeLists.txt but I
haven't found a user of inkscape.desktop.in, but I'm not sure if it is
safe to delete. Also, it looks to me like po/CMakeLists.txt could be
made to load the file from packaging/ instead of the root dir, but I'm
not certain. This would be worth further investigation.
>
------------------------------------------------------------------------
> + mingwenv.bat
> + mingwenv.cmake
> + msys2checkdeps.py
> + msys2installdeps.sh
> + msysenv.sh
> + inkscape.appdata.xml.in
> + Info.plist.in
> + appveyor.sh
> + appveyor.yml
> + .gitlab-ci.yml
> + .snapcraft.yaml
> + packaging/
>
> I know a lot of tools expect config files in the project's root
> directory, but can any of these be moved to packaging/? (Or maybe a
> utils/ dir?)
>
> Several of these have description snippets that are essentially the
> first few paragraphs of the README. If the README is revised (see
> below), it may be worthwhile to resync the text in these from that.
Thanks for creating buildtools/ and moving a few items, hopefully we can
continue migrating build related utility stuff into there.
There's been some cleanup here and other changes:
+ mingwenv.bat
+ msysenv.sh
Reducing the ming and msys files to just these two is helpful, thanks.
I seem to recall there were plans to investigate if these could be moved
as well?
+ inkscape.appdata.xml.in
https://bugs.launchpad.net/inkscape/+bug/1710337
This is used for AppStream, which is used in software centers by Debian,
Ubuntu, and other distros, similar to inkscape.desktop.
The old autotools code referenced this file and appears to have been
processing it into inkscape.appdata.xml, but we don't appear to have any
cmake logic to process it.
+ Info.plist.in
This appears to be an osx packaging file, last updated in 2014, and a
simple grep seems to indicate that nothing is using it. Can we drop it?
If not, it looks like the file could be generated.
+ .snapcraft.yaml
This is now at snap/snapcraft.yaml. Could it perhaps be moved down to
packaging/snapcraft.yaml instead?
Bryce